From: Markus Armbruster <armbru@redhat.com>
To: qemu-devel@nongnu.org
Cc: arei.gonglei@huawei.com, lvivier@redhat.com, amit@kernel.org,
mst@redhat.com, pbonzini@redhat.com, berrange@redhat.com,
eduardo@habkost.net, thuth@redhat.com, david@redhat.com
Subject: [PATCH 1/4] qom: Improve error messages when property has no getter or setter
Date: Wed, 12 Oct 2022 17:37:58 +0200 [thread overview]
Message-ID: <20221012153801.2604340-2-armbru@redhat.com> (raw)
In-Reply-To: <20221012153801.2604340-1-armbru@redhat.com>
When you try to set a property that has no setter, the error message
blames "insufficient permission":
$ qemu-system-x86_64 -S -display none -nodefaults -monitor stdio
QEMU 7.1.50 monitor - type 'help' for more information
(qemu) qom-set /machine type q35
Error: Insufficient permission to perform this operation
This implies it could work with "sufficient permission". It can't.
Change the error message to:
Error: Property 'pc-i440fx-7.2-machine.type' is not writable
Do the same for getting a property that has no getter.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
qom/object.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/qom/object.c b/qom/object.c
index d34608558e..e5cef30f6d 100644
--- a/qom/object.c
+++ b/qom/object.c
@@ -1383,7 +1383,8 @@ bool object_property_get(Object *obj, const char *name, Visitor *v,
}
if (!prop->get) {
- error_setg(errp, QERR_PERMISSION_DENIED);
+ error_setg(errp, "Property '%s.%s' is not readable",
+ object_get_typename(obj), name);
return false;
}
prop->get(obj, v, name, prop->opaque, &err);
@@ -1402,7 +1403,8 @@ bool object_property_set(Object *obj, const char *name, Visitor *v,
}
if (!prop->set) {
- error_setg(errp, QERR_PERMISSION_DENIED);
+ error_setg(errp, "Property '%s.%s' is not writable",
+ object_get_typename(obj), name);
return false;
}
prop->set(obj, v, name, prop->opaque, errp);
--
2.37.2
next prev parent reply other threads:[~2022-10-12 15:42 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-12 15:37 [PATCH 0/4] Replace QERR_PERMISSION_DENIED by better error messages Markus Armbruster
2022-10-12 15:37 ` Markus Armbruster [this message]
2022-10-12 19:24 ` [PATCH 1/4] qom: Improve error messages when property has no getter or setter David Hildenbrand
2022-10-12 15:37 ` [PATCH 2/4] backends: Improve error messages when property can no longer be set Markus Armbruster
2022-10-12 15:38 ` [PATCH 3/4] qtest: Improve error messages when property can not be set right now Markus Armbruster
2022-10-12 18:05 ` Thomas Huth
2022-10-12 19:02 ` David Hildenbrand
2022-10-13 5:02 ` Markus Armbruster
2022-10-27 6:02 ` Markus Armbruster
2022-10-12 15:38 ` [PATCH 4/4] qerror: QERR_PERMISSION_DENIED is no longer used, drop Markus Armbruster
2022-10-26 20:12 ` [PATCH 0/4] Replace QERR_PERMISSION_DENIED by better error messages Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221012153801.2604340-2-armbru@redhat.com \
--to=armbru@redhat.com \
--cc=amit@kernel.org \
--cc=arei.gonglei@huawei.com \
--cc=berrange@redhat.com \
--cc=david@redhat.com \
--cc=eduardo@habkost.net \
--cc=lvivier@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).