From: Alexander Ivanov <alexander.ivanov@virtuozzo.com>
To: qemu-devel@nongnu.org
Cc: den@virtuozzo.com, michael.roth@amd.com, kkostiuk@redhat.com,
marcandre.lureau@gmail.com
Subject: [PATCH v5 7/7] qga: Add HW address getting for FreeBSD
Date: Mon, 17 Oct 2022 09:28:25 +0200 [thread overview]
Message-ID: <20221017072825.72867-8-alexander.ivanov@virtuozzo.com> (raw)
In-Reply-To: <20221017072825.72867-1-alexander.ivanov@virtuozzo.com>
Replace a dumb function in commands-bsd.c by the code of HW address
getting.
Reviewed-by: Konstantin Kostiuk <kkostiuk@redhat.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Signed-off-by: Alexander Ivanov <alexander.ivanov@virtuozzo.com>
---
qga/commands-bsd.c | 15 +++++++++++++++
1 file changed, 15 insertions(+)
diff --git a/qga/commands-bsd.c b/qga/commands-bsd.c
index ebf0fb8b0f..15cade2d4c 100644
--- a/qga/commands-bsd.c
+++ b/qga/commands-bsd.c
@@ -20,6 +20,8 @@
#include <sys/param.h>
#include <sys/ucred.h>
#include <sys/mount.h>
+#include <net/if_dl.h>
+#include <net/ethernet.h>
#include <paths.h>
#if defined(CONFIG_FSFREEZE) || defined(CONFIG_FSTRIM)
@@ -179,7 +181,20 @@ GuestCpuStatsList *qmp_guest_get_cpustats(Error **errp)
bool guest_get_hw_addr(struct ifaddrs *ifa, unsigned char *buf,
bool *obtained, Error **errp)
{
+ struct sockaddr_dl *sdp;
+
*obtained = false;
+
+ if (ifa->ifa_addr->sa_family != AF_LINK) {
+ /* We can get HW address only for AF_LINK family. */
+ g_debug("failed to get MAC address of %s", ifa->ifa_name);
+ return true;
+ }
+
+ sdp = (struct sockaddr_dl *)ifa->ifa_addr;
+ memcpy(buf, sdp->sdl_data + sdp->sdl_nlen, ETHER_ADDR_LEN);
+ *obtained = true;
+
return true;
}
#endif /* HAVE_GETIFADDRS */
--
2.34.1
next prev parent reply other threads:[~2022-10-17 7:47 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-17 7:28 [PATCH v5 0/7] qga: Add FreeBSD support Alexander Ivanov
2022-10-17 7:28 ` [PATCH v5 1/7] qga: Add initial " Alexander Ivanov
2022-10-17 7:28 ` [PATCH v5 2/7] qga: Move Linux-specific FS freeze/thaw code to a separate file Alexander Ivanov
2022-10-17 7:28 ` [PATCH v5 3/7] qga: Add UFS freeze/thaw support for FreeBSD Alexander Ivanov
2022-10-17 7:28 ` [PATCH v5 4/7] qga: Add shutdown/halt/reboot " Alexander Ivanov
2022-10-17 7:28 ` [PATCH v5 5/7] qga: Add support for user password setting in FreeBSD Alexander Ivanov
2022-10-17 7:28 ` [PATCH v5 6/7] qga: Move HW address getting to a separate function Alexander Ivanov
2022-10-17 7:28 ` Alexander Ivanov [this message]
2022-10-26 13:25 ` [PATCH v5 0/7] qga: Add FreeBSD support Alexander Ivanov
2022-10-26 18:00 ` Konstantin Kostiuk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221017072825.72867-8-alexander.ivanov@virtuozzo.com \
--to=alexander.ivanov@virtuozzo.com \
--cc=den@virtuozzo.com \
--cc=kkostiuk@redhat.com \
--cc=marcandre.lureau@gmail.com \
--cc=michael.roth@amd.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).