qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Laurent Vivier <lvivier@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Daniel P. Berrangé" <berrange@redhat.com>,
	xen-devel@lists.xenproject.org, "Eric Blake" <eblake@redhat.com>,
	"Stefano Stabellini" <sstabellini@kernel.org>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Greg Kurz" <groug@kaod.org>, "Jason Wang" <jasowang@redhat.com>,
	"Anthony Perard" <anthony.perard@citrix.com>,
	"Thomas Huth" <thuth@redhat.com>,
	"David Gibson" <david@gibson.dropbear.id.au>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	"Laurent Vivier" <lvivier@redhat.com>,
	"Samuel Thibault" <samuel.thibault@ens-lyon.org>,
	"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
	"Paul Durrant" <paul@xen.org>, "Stefan Weil" <sw@weilnetz.de>,
	"Markus Armbruster" <armbru@redhat.com>
Subject: [PATCH v12 17/17] net: stream: add QAPI events to report connection state
Date: Thu, 20 Oct 2022 11:16:24 +0200	[thread overview]
Message-ID: <20221020091624.48368-18-lvivier@redhat.com> (raw)
In-Reply-To: <20221020091624.48368-1-lvivier@redhat.com>

The netdev reports NETDEV_STREAM_CONNECTED event when the backend
is connected, and NETDEV_STREAM_DISCONNECTED when it is disconnected.

The NETDEV_STREAM_CONNECTED event includes the URI of the destination
address.

Signed-off-by: Laurent Vivier <lvivier@redhat.com>
Acked-by: Michael S. Tsirkin <mst@redhat.com>
---
 net/stream.c  | 11 +++++++++--
 qapi/net.json | 46 ++++++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 55 insertions(+), 2 deletions(-)

diff --git a/net/stream.c b/net/stream.c
index 95d6b910407d..8ad757cefbdf 100644
--- a/net/stream.c
+++ b/net/stream.c
@@ -38,6 +38,7 @@
 #include "io/channel.h"
 #include "io/channel-socket.h"
 #include "io/net-listener.h"
+#include "qapi/qapi-events-net.h"
 
 typedef struct NetStreamState {
     NetClientState nc;
@@ -168,6 +169,8 @@ static gboolean net_stream_send(QIOChannel *ioc,
         s->nc.link_down = true;
         qemu_set_info_str(&s->nc, "");
 
+        qapi_event_send_netdev_stream_disconnected(s->nc.name);
+
         return G_SOURCE_REMOVE;
     }
     buf = buf1;
@@ -243,9 +246,10 @@ static void net_stream_listen(QIONetListener *listener,
     g_assert(addr != NULL);
     uri = socket_uri(addr);
     qemu_set_info_str(&s->nc, uri);
-    g_free(uri);
     qapi_free_SocketAddress(addr);
 
+    qapi_event_send_netdev_stream_connected(s->nc.name, uri);
+    g_free(uri);
 }
 
 static void net_stream_server_listening(QIOTask *task, gpointer opaque)
@@ -317,12 +321,12 @@ static void net_stream_client_connected(QIOTask *task, gpointer opaque)
     g_assert(addr != NULL);
     uri = socket_uri(addr);
     qemu_set_info_str(&s->nc, uri);
-    g_free(uri);
 
     ret = qemu_socket_try_set_nonblock(sioc->fd);
     if (addr->type == SOCKET_ADDRESS_TYPE_FD && ret < 0) {
         qemu_set_info_str(&s->nc, "can't use file descriptor %s (errno %d)",
                           addr->u.fd.str, -ret);
+        g_free(uri);
         qapi_free_SocketAddress(addr);
         goto error;
     }
@@ -338,6 +342,9 @@ static void net_stream_client_connected(QIOTask *task, gpointer opaque)
                                             s, NULL);
     s->nc.link_down = false;
 
+    qapi_event_send_netdev_stream_connected(s->nc.name, uri);
+    g_free(uri);
+
     return;
 error:
     object_unref(OBJECT(s->ioc));
diff --git a/qapi/net.json b/qapi/net.json
index 39388b1b6c41..569ab7fd37e3 100644
--- a/qapi/net.json
+++ b/qapi/net.json
@@ -895,3 +895,49 @@
 ##
 { 'event': 'FAILOVER_NEGOTIATED',
   'data': {'device-id': 'str'} }
+
+##
+# @NETDEV_STREAM_CONNECTED:
+#
+# Emitted when the netdev stream backend is connected
+#
+# @netdev-id: QEMU netdev id that is connected
+# @uri: The Uniform Resource Identifier identifying the destination address
+#
+# Since: 7.2
+#
+# Example:
+#
+# <- { 'event': 'NETDEV_STREAM_CONNECTED',
+#      'data': {'uri': 'tcp:::1:1234', 'netdev-id': 'netdev0'},
+#      'timestamp': {'seconds': 1663330564, 'microseconds': 804317} }
+#
+# or
+#
+# <- { 'event': 'NETDEV_STREAM_CONNECTED',
+#      'data': {'uri': ''unix:/tmp/qemu0', 'netdev-id': 'netdev0'},
+#      'timestamp': {'seconds': 1663330564, 'microseconds': 804317} }
+#
+##
+{ 'event': 'NETDEV_STREAM_CONNECTED',
+  'data': { 'netdev-id': 'str',
+            'uri': 'str' } }
+
+##
+# @NETDEV_STREAM_DISCONNECTED:
+#
+# Emitted when the netdev stream backend is disconnected
+#
+# @netdev-id: QEMU netdev id that is disconnected
+#
+# Since: 7.2
+#
+# Example:
+#
+# <- { 'event': 'NETDEV_STREAM_DISCONNECTED',
+#      'data': {'netdev-id': 'netdev0'},
+#      'timestamp': {'seconds': 1663330937, 'microseconds': 526695} }
+#
+##
+{ 'event': 'NETDEV_STREAM_DISCONNECTED',
+  'data': { 'netdev-id': 'str' } }
-- 
2.37.3



  parent reply	other threads:[~2022-10-20 10:09 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-20  9:16 [PATCH v12 00/17] qapi: net: add unix socket type support to netdev backend Laurent Vivier
2022-10-20  9:16 ` [PATCH v12 01/17] net: introduce convert_host_port() Laurent Vivier
2022-10-20  9:16 ` [PATCH v12 02/17] net: remove the @errp argument of net_client_inits() Laurent Vivier
2022-10-20  9:16 ` [PATCH v12 03/17] net: simplify net_client_parse() error management Laurent Vivier
2022-10-20  9:16 ` [PATCH v12 04/17] qapi: net: introduce a way to bypass qemu_opts_parse_noisily() Laurent Vivier
2022-10-20  9:16 ` [PATCH v12 05/17] net: introduce qemu_set_info_str() function Laurent Vivier
2022-10-20 11:22   ` Philippe Mathieu-Daudé
2022-10-20  9:16 ` [PATCH v12 06/17] qapi: net: add stream and dgram netdevs Laurent Vivier
2022-10-20  9:16 ` [PATCH v12 07/17] net: socket: Don't ignore EINVAL on netdev socket connection Laurent Vivier
2022-10-20  9:16 ` [PATCH v12 08/17] net: stream: " Laurent Vivier
2022-10-20  9:16 ` [PATCH v12 09/17] net: stream: add unix socket Laurent Vivier
2022-10-20 11:29   ` Philippe Mathieu-Daudé
2022-10-20  9:16 ` [PATCH v12 10/17] net: dgram: make dgram_dst generic Laurent Vivier
2022-10-20 11:17   ` Philippe Mathieu-Daudé
2022-10-20 15:08     ` Laurent Vivier
2022-10-20  9:16 ` [PATCH v12 11/17] net: dgram: move mcast specific code from net_socket_fd_init_dgram() Laurent Vivier
2022-10-20  9:16 ` [PATCH v12 12/17] net: dgram: add unix socket Laurent Vivier
2022-10-20 11:04   ` Philippe Mathieu-Daudé
2022-10-20  9:16 ` [PATCH v12 13/17] qemu-sockets: move and rename SocketAddress_to_str() Laurent Vivier
2022-10-20  9:16 ` [PATCH v12 14/17] qemu-sockets: update socket_uri() and socket_parse() to be consistent Laurent Vivier
2022-10-20  9:16 ` [PATCH v12 15/17] net: stream: move to QIO to enable additional parameters Laurent Vivier
2022-10-20 11:05   ` Philippe Mathieu-Daudé
2022-10-20 13:09     ` Philippe Mathieu-Daudé
2022-10-20 13:09   ` Philippe Mathieu-Daudé
2022-10-20 15:23     ` Laurent Vivier
2022-10-20  9:16 ` [PATCH v12 16/17] tests/qtest: netdev: test stream and dgram backends Laurent Vivier
2022-10-20 13:26   ` Philippe Mathieu-Daudé
2022-10-20 14:48     ` Laurent Vivier
2022-10-20  9:16 ` Laurent Vivier [this message]
2022-10-20 11:20   ` [PATCH v12 17/17] net: stream: add QAPI events to report connection state Philippe Mathieu-Daudé
2022-10-20 13:40 ` [RFC PATCH 18/17] util/qemu-sockets: Display IPv6 addresses within square brackets Philippe Mathieu-Daudé
2022-10-20 13:50   ` Daniel P. Berrangé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221020091624.48368-18-lvivier@redhat.com \
    --to=lvivier@redhat.com \
    --cc=anthony.perard@citrix.com \
    --cc=armbru@redhat.com \
    --cc=berrange@redhat.com \
    --cc=david@gibson.dropbear.id.au \
    --cc=dgilbert@redhat.com \
    --cc=eblake@redhat.com \
    --cc=groug@kaod.org \
    --cc=jasowang@redhat.com \
    --cc=mst@redhat.com \
    --cc=paul@xen.org \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=samuel.thibault@ens-lyon.org \
    --cc=sstabellini@kernel.org \
    --cc=sw@weilnetz.de \
    --cc=thuth@redhat.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).