From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 57B62C4332F for ; Fri, 21 Oct 2022 10:19:37 +0000 (UTC) Received: from localhost ([::1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1olp7n-0003cl-Vl for qemu-devel@archiver.kernel.org; Fri, 21 Oct 2022 06:19:36 -0400 Received: from [::1] (helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oloXi-0005EV-Rl for qemu-devel@archiver.kernel.org; Fri, 21 Oct 2022 05:42:18 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oloXV-0004ys-Iw for qemu-devel@nongnu.org; Fri, 21 Oct 2022 05:42:07 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oloXU-0008Cu-5z for qemu-devel@nongnu.org; Fri, 21 Oct 2022 05:42:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1666345323; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HWFs6Ey6gOSX0j5UiIYZMTxWGzZHU1ACMbPbsoVaxIc=; b=OCRTGITt+SQ+zzpk8fS2zJCWgieFKncyz/gdi30WlZ+hzZE2ptMznhcQ7Q/WTVtDpIWdX2 AGERqAFeP1cojD4AhOanljCHOl1gYJn63BNM07mallsLjN0DIjWHvD36y2wKFw1LkbEqtP PYK88piWCL0bRpWG9zi0kqDzoPwDfmc= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-246-r7AfPqY6NQ-Q2yMecedJPg-1; Fri, 21 Oct 2022 05:41:58 -0400 X-MC-Unique: r7AfPqY6NQ-Q2yMecedJPg-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 7DF2B857F92; Fri, 21 Oct 2022 09:41:47 +0000 (UTC) Received: from maya.cloud.tilaa.com (ovpn-208-31.brq.redhat.com [10.40.208.31]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0A586141C6A9; Fri, 21 Oct 2022 09:41:38 +0000 (UTC) Date: Fri, 21 Oct 2022 11:40:52 +0200 From: Stefano Brivio To: Markus Armbruster Cc: Laurent Vivier , qemu-devel@nongnu.org, Paul Durrant , Thomas Huth , "Daniel P. =?UTF-8?B?QmVy?= =?UTF-8?B?cmFuZ8Op?=" , "Dr. David Alan Gilbert" , Greg Kurz , Stefano Stabellini , David Gibson , Eric Blake , xen-devel@lists.xenproject.org, "Michael S. Tsirkin" , Stefan Weil , Paolo Bonzini , Jason Wang , Samuel Thibault , Anthony Perard , Laine Stump Subject: Re: [PATCH v13 17/17] net: stream: add QAPI events to report connection state Message-ID: <20221021114052.339f6aac@elisabeth> In-Reply-To: <87lep935hn.fsf@pond.sub.org> References: <20221020162558.123284-1-lvivier@redhat.com> <20221020162558.123284-18-lvivier@redhat.com> <87pmel4th4.fsf@pond.sub.org> <52e989b9-6f8d-99c6-ef04-3ce32006b002@redhat.com> <87lep935hn.fsf@pond.sub.org> Organization: Red Hat MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 3.1 on 10.11.54.7 Received-SPF: pass client-ip=170.10.133.124; envelope-from=sbrivio@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -23 X-Spam_score: -2.4 X-Spam_bar: -- X-Spam_report: (-2.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.251, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" [Cc: Laine, full quote] On Fri, 21 Oct 2022 11:12:20 +0200 Markus Armbruster wrote: > Cc: Stefano Brivio > > Laurent Vivier writes: > > > On 10/21/22 07:48, Markus Armbruster wrote: > >> Laurent Vivier writes: > >> > >>> The netdev reports NETDEV_STREAM_CONNECTED event when the backend > >>> is connected, and NETDEV_STREAM_DISCONNECTED when it is disconnected. > >> > >> Use cases? > > > > This is asked by Stefano Brivio to allow libvirt to detect if connection to passt is lost and to restart passt. > > Let's add something like this to the commit message: > > This lets libvirt notice when the connection is lost somehow, and > restart the peer (such as passt). > > Who's working on the libvirt part? Laine Stump and myself. Nothing to show yet, though. > > I have also a patch to add a "reconnect=seconds" option, but I didn't want to add it to this series. > > It's okay to mention future work in commit messages, but not required. > > >> Could similar event signalling be useful for other kinds of netdev > >> backends? > > > > I was wondering, but it becomes more complicated to be generic. > > Making something complicated and generic where a simpler special > solution would do is the worst. > > Not quite as bad (but still plenty bad) is making a few special > solutions first, then replace them all with a generic solution. > > I believe we should have a good, hard think on possible applications of > a generic solution now. > > There is no need to hold back this series for that. > > If we conclude a generic solution is called for, we better replace this > special solution before it becomes ABI. Either by replacing it before > we release it, or by keeping it unstable until we replace it. -- Stefano