From: Bernhard Beschow <shentey@gmail.com>
To: qemu-devel@nongnu.org
Cc: "Eduardo Habkost" <eduardo@habkost.net>,
"Hervé Poussineau" <hpoussin@reactos.org>,
"Aurelien Jarno" <aurelien@aurel32.net>,
"Igor Mammedov" <imammedo@redhat.com>,
"Gerd Hoffmann" <kraxel@redhat.com>,
"John Snow" <jsnow@redhat.com>,
"Jiaxun Yang" <jiaxun.yang@flygoat.com>,
"Ani Sinha" <ani@anisinha.ca>,
"Marcel Apfelbaum" <marcel.apfelbaum@gmail.com>,
qemu-block@nongnu.org,
"Richard Henderson" <richard.henderson@linaro.org>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Bernhard Beschow" <shentey@gmail.com>
Subject: [PATCH v2 17/43] hw/isa/piix3: Wire up ACPI interrupt internally
Date: Sat, 22 Oct 2022 17:04:42 +0200 [thread overview]
Message-ID: <20221022150508.26830-18-shentey@gmail.com> (raw)
In-Reply-To: <20221022150508.26830-1-shentey@gmail.com>
Now that PIIX3 has the PIC integrated, the ACPI controller can be wired
up internally.
Signed-off-by: Bernhard Beschow <shentey@gmail.com>
---
hw/i386/pc_piix.c | 1 -
hw/isa/piix3.c | 2 ++
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c
index 19fe07a13b..dd4e89acf9 100644
--- a/hw/i386/pc_piix.c
+++ b/hw/i386/pc_piix.c
@@ -313,7 +313,6 @@ static void pc_init1(MachineState *machine,
if (piix4_pm) {
smi_irq = qemu_allocate_irq(pc_acpi_smi_interrupt, first_cpu, 0);
- qdev_connect_gpio_out(DEVICE(piix4_pm), 0, x86ms->gsi[9]);
qdev_connect_gpio_out_named(DEVICE(piix4_pm), "smi-irq", 0, smi_irq);
pcms->smbus = I2C_BUS(qdev_get_child_bus(DEVICE(piix4_pm), "i2c"));
/* TODO: Populate SPD eeprom data. */
diff --git a/hw/isa/piix3.c b/hw/isa/piix3.c
index bbd1dfc373..59599558a1 100644
--- a/hw/isa/piix3.c
+++ b/hw/isa/piix3.c
@@ -355,6 +355,8 @@ static void pci_piix3_realize(PCIDevice *dev, Error **errp)
if (!qdev_realize(DEVICE(&d->pm), BUS(pci_bus), errp)) {
return;
}
+ qdev_connect_gpio_out(DEVICE(&d->pm), 0,
+ qdev_get_gpio_in(DEVICE(&d->pic), 9));
}
}
--
2.38.1
next prev parent reply other threads:[~2022-10-24 2:29 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-22 15:04 [PATCH v2 00/43] Consolidate PIIX south bridges Bernhard Beschow
2022-10-22 15:04 ` [PATCH v2 01/43] hw/i386/pc: Create DMA controllers in " Bernhard Beschow
2022-10-22 15:04 ` [PATCH v2 02/43] hw/i386/pc_piix: Allow for setting properties before realizing PIIX3 south bridge Bernhard Beschow
2022-10-22 15:04 ` [PATCH v2 03/43] hw/isa/piix3: Remove extra ';' outside of functions Bernhard Beschow
2022-10-22 15:04 ` [PATCH v2 04/43] hw/isa/piix3: Add size constraints to rcr_ops Bernhard Beschow
2022-10-22 15:04 ` [PATCH v2 05/43] hw/isa/piix3: Modernize reset handling Bernhard Beschow
2022-10-22 15:04 ` [PATCH v2 06/43] hw/isa/piix3: Prefer pci_address_space() over get_system_memory() Bernhard Beschow
2022-10-22 15:04 ` [PATCH v2 07/43] hw/isa/piix4: Rename wrongly named method Bernhard Beschow
2022-10-22 15:04 ` [PATCH v2 08/43] hw/ide/piix: Introduce TYPE_ macros for PIIX IDE controllers Bernhard Beschow
2022-10-25 23:30 ` Philippe Mathieu-Daudé
2022-10-22 15:04 ` [PATCH v2 09/43] hw/usb/hcd-uhci: Introduce TYPE_ defines for device models Bernhard Beschow
2022-10-27 20:57 ` Philippe Mathieu-Daudé
2022-10-22 15:04 ` [PATCH v2 10/43] hw/i386/pc: Create RTC controllers in south bridges Bernhard Beschow
2022-10-22 15:04 ` [PATCH v2 11/43] hw/i386/pc: No need for rtc_state to be an out-parameter Bernhard Beschow
2022-10-22 15:04 ` [PATCH v2 12/43] hw/isa/piix3: Create USB controller in host device Bernhard Beschow
2022-10-22 15:04 ` [PATCH v2 13/43] hw/isa/piix3: Create power management " Bernhard Beschow
2022-10-22 15:04 ` [PATCH v2 14/43] hw/intc/i8259: Introduce i8259 proxy "isa-pic" Bernhard Beschow
2022-10-24 7:35 ` Philippe Mathieu-Daudé
2022-10-26 19:56 ` B
2022-10-22 15:04 ` [PATCH v2 15/43] hw/isa/piix3: Create ISA PIC in host device Bernhard Beschow
2022-10-22 15:04 ` [PATCH v2 16/43] hw/isa/piix3: Create IDE controller " Bernhard Beschow
2022-10-22 15:04 ` Bernhard Beschow [this message]
2022-10-22 15:04 ` [PATCH v2 18/43] hw/isa/piix3: Remove unused include Bernhard Beschow
2022-10-23 21:05 ` Philippe Mathieu-Daudé
2022-10-22 15:04 ` [PATCH v2 19/43] hw/isa/piix3: Allow board to provide PCI interrupt routes Bernhard Beschow
2022-10-24 5:12 ` Philippe Mathieu-Daudé
2022-10-25 23:34 ` Philippe Mathieu-Daudé
2022-10-26 9:45 ` Bernhard Beschow
2022-10-22 15:04 ` [PATCH v2 20/43] hw/isa/piix3: Resolve redundant PIIX_NUM_PIC_IRQS Bernhard Beschow
2022-10-22 15:04 ` [PATCH v2 21/43] hw/isa/piix3: Rename pci_piix3_props for sharing with PIIX4 Bernhard Beschow
2022-10-24 5:08 ` Philippe Mathieu-Daudé
2022-10-22 15:04 ` [PATCH v2 22/43] hw/isa/piix3: Rename piix3_reset() " Bernhard Beschow
2022-10-24 5:08 ` Philippe Mathieu-Daudé
2022-10-22 15:04 ` [PATCH v2 23/43] hw/isa/piix3: Prefix pci_slot_get_pirq() with "piix3_" Bernhard Beschow
2022-10-24 5:07 ` Philippe Mathieu-Daudé
2022-10-22 15:04 ` [PATCH v2 24/43] hw/isa/piix3: Rename typedef PIIX3State to PIIXState Bernhard Beschow
2022-10-24 5:07 ` Philippe Mathieu-Daudé
2022-10-22 15:04 ` [PATCH v2 25/43] hw/mips/malta: Reuse dev variable Bernhard Beschow
2022-10-24 5:07 ` Philippe Mathieu-Daudé
2022-10-22 15:04 ` [PATCH v2 26/43] meson: Fix dependencies of piix4 southbridge Bernhard Beschow
2022-10-22 15:04 ` [PATCH v2 27/43] hw/isa/piix4: Add missing initialization Bernhard Beschow
2022-10-22 15:04 ` [PATCH v2 28/43] hw/isa/piix4: Move pci_ide_create_devs() call to board code Bernhard Beschow
2022-10-22 15:04 ` [PATCH v2 29/43] hw/isa/piix4: Make PIIX4's ACPI and USB functions optional Bernhard Beschow
2022-10-22 15:04 ` [PATCH v2 30/43] hw/isa/piix4: Allow board to provide PCI interrupt routes Bernhard Beschow
2022-10-22 15:04 ` [PATCH v2 31/43] hw/isa/piix4: Remove unused code Bernhard Beschow
2022-10-22 15:04 ` [PATCH v2 32/43] hw/isa/piix4: Use ISA PIC device Bernhard Beschow
2022-10-22 15:04 ` [PATCH v2 33/43] hw/isa/piix4: Reuse struct PIIXState from PIIX3 Bernhard Beschow
2022-10-22 15:04 ` [PATCH v2 34/43] hw/isa/piix4: Rename reset control operations to match PIIX3 Bernhard Beschow
2022-10-24 5:20 ` Philippe Mathieu-Daudé
2022-10-22 15:05 ` [PATCH v2 35/43] hw/isa/piix4: Prefix pci_slot_get_pirq() with "piix4_" Bernhard Beschow
2022-10-22 15:05 ` [PATCH v2 36/43] hw/isa/piix3: Merge hw/isa/piix4.c Bernhard Beschow
2022-10-22 15:05 ` [PATCH v2 37/43] hw/isa/piix: Harmonize names of reset control memory regions Bernhard Beschow
2022-10-24 5:21 ` Philippe Mathieu-Daudé
2022-10-22 15:05 ` [PATCH v2 38/43] hw/isa/piix: Reuse PIIX3 base class' realize method in PIIX4 Bernhard Beschow
2022-10-22 15:05 ` [PATCH v2 39/43] hw/isa/piix: Rename functions to be shared for interrupt triggering Bernhard Beschow
2022-10-22 15:05 ` [PATCH v2 40/43] hw/isa/piix: Consolidate IRQ triggering Bernhard Beschow
2022-10-22 15:05 ` [PATCH v2 41/43] hw/isa/piix: Share PIIX3 base class with PIIX4 Bernhard Beschow
2022-10-22 15:05 ` [PATCH v2 42/43] hw/isa/piix: Drop the "3" from the PIIX base class Bernhard Beschow
2022-10-22 15:05 ` [PATCH v2 43/43] hw/i386/acpi-build: Resolve PIIX ISA bridge rather than ACPI controller Bernhard Beschow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221022150508.26830-18-shentey@gmail.com \
--to=shentey@gmail.com \
--cc=ani@anisinha.ca \
--cc=aurelien@aurel32.net \
--cc=eduardo@habkost.net \
--cc=f4bug@amsat.org \
--cc=hpoussin@reactos.org \
--cc=imammedo@redhat.com \
--cc=jiaxun.yang@flygoat.com \
--cc=jsnow@redhat.com \
--cc=kraxel@redhat.com \
--cc=marcel.apfelbaum@gmail.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).