From: Bernhard Beschow <shentey@gmail.com>
To: qemu-devel@nongnu.org
Cc: "Eduardo Habkost" <eduardo@habkost.net>,
"Hervé Poussineau" <hpoussin@reactos.org>,
"Aurelien Jarno" <aurelien@aurel32.net>,
"Igor Mammedov" <imammedo@redhat.com>,
"Gerd Hoffmann" <kraxel@redhat.com>,
"John Snow" <jsnow@redhat.com>,
"Jiaxun Yang" <jiaxun.yang@flygoat.com>,
"Ani Sinha" <ani@anisinha.ca>,
"Marcel Apfelbaum" <marcel.apfelbaum@gmail.com>,
qemu-block@nongnu.org,
"Richard Henderson" <richard.henderson@linaro.org>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Bernhard Beschow" <shentey@gmail.com>
Subject: [PATCH v2 42/43] hw/isa/piix: Drop the "3" from the PIIX base class
Date: Sat, 22 Oct 2022 17:05:07 +0200 [thread overview]
Message-ID: <20221022150508.26830-43-shentey@gmail.com> (raw)
In-Reply-To: <20221022150508.26830-1-shentey@gmail.com>
Now that the base class is used for both PIIX3 and PIIX4, the "3"
became misleading.
Signed-off-by: Bernhard Beschow <shentey@gmail.com>
---
hw/i386/acpi-build.c | 2 +-
hw/isa/piix.c | 8 ++++----
include/hw/southbridge/piix.h | 4 ++--
3 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c
index 4f54b61904..c006db72e8 100644
--- a/hw/i386/acpi-build.c
+++ b/hw/i386/acpi-build.c
@@ -1298,7 +1298,7 @@ static void build_piix4_isa_bridge(Aml *table)
* once PCI is converted to AcpiDevAmlIf and would be ble to generate
* AML for bridge itself
*/
- obj = object_resolve_path_type("", TYPE_PIIX3_PCI_DEVICE, &ambiguous);
+ obj = object_resolve_path_type("", TYPE_PIIX_PCI_DEVICE, &ambiguous);
assert(obj && !ambiguous);
scope = aml_scope("_SB.PCI0");
diff --git a/hw/isa/piix.c b/hw/isa/piix.c
index c8c1a99bf1..a361261940 100644
--- a/hw/isa/piix.c
+++ b/hw/isa/piix.c
@@ -463,7 +463,7 @@ static void pci_piix_class_init(ObjectClass *klass, void *data)
}
static const TypeInfo piix_pci_type_info = {
- .name = TYPE_PIIX3_PCI_DEVICE,
+ .name = TYPE_PIIX_PCI_DEVICE,
.parent = TYPE_PCI_DEVICE,
.instance_size = sizeof(PIIXState),
.instance_init = pci_piix_init,
@@ -513,7 +513,7 @@ static void piix3_class_init(ObjectClass *klass, void *data)
static const TypeInfo piix3_info = {
.name = TYPE_PIIX3_DEVICE,
- .parent = TYPE_PIIX3_PCI_DEVICE,
+ .parent = TYPE_PIIX_PCI_DEVICE,
.instance_init = piix3_init,
.class_init = piix3_class_init,
};
@@ -553,7 +553,7 @@ static void piix3_xen_class_init(ObjectClass *klass, void *data)
static const TypeInfo piix3_xen_info = {
.name = TYPE_PIIX3_XEN_DEVICE,
- .parent = TYPE_PIIX3_PCI_DEVICE,
+ .parent = TYPE_PIIX_PCI_DEVICE,
.instance_init = piix3_init,
.class_init = piix3_xen_class_init,
};
@@ -602,7 +602,7 @@ static void piix4_class_init(ObjectClass *klass, void *data)
static const TypeInfo piix4_info = {
.name = TYPE_PIIX4_PCI_DEVICE,
- .parent = TYPE_PIIX3_PCI_DEVICE,
+ .parent = TYPE_PIIX_PCI_DEVICE,
.instance_init = piix4_init,
.class_init = piix4_class_init,
};
diff --git a/include/hw/southbridge/piix.h b/include/hw/southbridge/piix.h
index c9fa0f1aa6..c21b69e2be 100644
--- a/include/hw/southbridge/piix.h
+++ b/include/hw/southbridge/piix.h
@@ -75,9 +75,9 @@ struct PIIXState {
};
typedef struct PIIXState PIIXState;
-#define TYPE_PIIX3_PCI_DEVICE "pci-piix3"
+#define TYPE_PIIX_PCI_DEVICE "pci-piix"
DECLARE_INSTANCE_CHECKER(PIIXState, PIIX_PCI_DEVICE,
- TYPE_PIIX3_PCI_DEVICE)
+ TYPE_PIIX_PCI_DEVICE)
#define TYPE_PIIX3_DEVICE "PIIX3"
#define TYPE_PIIX3_XEN_DEVICE "PIIX3-xen"
--
2.38.1
next prev parent reply other threads:[~2022-10-24 6:02 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-22 15:04 [PATCH v2 00/43] Consolidate PIIX south bridges Bernhard Beschow
2022-10-22 15:04 ` [PATCH v2 01/43] hw/i386/pc: Create DMA controllers in " Bernhard Beschow
2022-10-22 15:04 ` [PATCH v2 02/43] hw/i386/pc_piix: Allow for setting properties before realizing PIIX3 south bridge Bernhard Beschow
2022-10-22 15:04 ` [PATCH v2 03/43] hw/isa/piix3: Remove extra ';' outside of functions Bernhard Beschow
2022-10-22 15:04 ` [PATCH v2 04/43] hw/isa/piix3: Add size constraints to rcr_ops Bernhard Beschow
2022-10-22 15:04 ` [PATCH v2 05/43] hw/isa/piix3: Modernize reset handling Bernhard Beschow
2022-10-22 15:04 ` [PATCH v2 06/43] hw/isa/piix3: Prefer pci_address_space() over get_system_memory() Bernhard Beschow
2022-10-22 15:04 ` [PATCH v2 07/43] hw/isa/piix4: Rename wrongly named method Bernhard Beschow
2022-10-22 15:04 ` [PATCH v2 08/43] hw/ide/piix: Introduce TYPE_ macros for PIIX IDE controllers Bernhard Beschow
2022-10-25 23:30 ` Philippe Mathieu-Daudé
2022-10-22 15:04 ` [PATCH v2 09/43] hw/usb/hcd-uhci: Introduce TYPE_ defines for device models Bernhard Beschow
2022-10-27 20:57 ` Philippe Mathieu-Daudé
2022-10-22 15:04 ` [PATCH v2 10/43] hw/i386/pc: Create RTC controllers in south bridges Bernhard Beschow
2022-10-22 15:04 ` [PATCH v2 11/43] hw/i386/pc: No need for rtc_state to be an out-parameter Bernhard Beschow
2022-10-22 15:04 ` [PATCH v2 12/43] hw/isa/piix3: Create USB controller in host device Bernhard Beschow
2022-10-22 15:04 ` [PATCH v2 13/43] hw/isa/piix3: Create power management " Bernhard Beschow
2022-10-22 15:04 ` [PATCH v2 14/43] hw/intc/i8259: Introduce i8259 proxy "isa-pic" Bernhard Beschow
2022-10-24 7:35 ` Philippe Mathieu-Daudé
2022-10-26 19:56 ` B
2022-10-22 15:04 ` [PATCH v2 15/43] hw/isa/piix3: Create ISA PIC in host device Bernhard Beschow
2022-10-22 15:04 ` [PATCH v2 16/43] hw/isa/piix3: Create IDE controller " Bernhard Beschow
2022-10-22 15:04 ` [PATCH v2 17/43] hw/isa/piix3: Wire up ACPI interrupt internally Bernhard Beschow
2022-10-22 15:04 ` [PATCH v2 18/43] hw/isa/piix3: Remove unused include Bernhard Beschow
2022-10-23 21:05 ` Philippe Mathieu-Daudé
2022-10-22 15:04 ` [PATCH v2 19/43] hw/isa/piix3: Allow board to provide PCI interrupt routes Bernhard Beschow
2022-10-24 5:12 ` Philippe Mathieu-Daudé
2022-10-25 23:34 ` Philippe Mathieu-Daudé
2022-10-26 9:45 ` Bernhard Beschow
2022-10-22 15:04 ` [PATCH v2 20/43] hw/isa/piix3: Resolve redundant PIIX_NUM_PIC_IRQS Bernhard Beschow
2022-10-22 15:04 ` [PATCH v2 21/43] hw/isa/piix3: Rename pci_piix3_props for sharing with PIIX4 Bernhard Beschow
2022-10-24 5:08 ` Philippe Mathieu-Daudé
2022-10-22 15:04 ` [PATCH v2 22/43] hw/isa/piix3: Rename piix3_reset() " Bernhard Beschow
2022-10-24 5:08 ` Philippe Mathieu-Daudé
2022-10-22 15:04 ` [PATCH v2 23/43] hw/isa/piix3: Prefix pci_slot_get_pirq() with "piix3_" Bernhard Beschow
2022-10-24 5:07 ` Philippe Mathieu-Daudé
2022-10-22 15:04 ` [PATCH v2 24/43] hw/isa/piix3: Rename typedef PIIX3State to PIIXState Bernhard Beschow
2022-10-24 5:07 ` Philippe Mathieu-Daudé
2022-10-22 15:04 ` [PATCH v2 25/43] hw/mips/malta: Reuse dev variable Bernhard Beschow
2022-10-24 5:07 ` Philippe Mathieu-Daudé
2022-10-22 15:04 ` [PATCH v2 26/43] meson: Fix dependencies of piix4 southbridge Bernhard Beschow
2022-10-22 15:04 ` [PATCH v2 27/43] hw/isa/piix4: Add missing initialization Bernhard Beschow
2022-10-22 15:04 ` [PATCH v2 28/43] hw/isa/piix4: Move pci_ide_create_devs() call to board code Bernhard Beschow
2022-10-22 15:04 ` [PATCH v2 29/43] hw/isa/piix4: Make PIIX4's ACPI and USB functions optional Bernhard Beschow
2022-10-22 15:04 ` [PATCH v2 30/43] hw/isa/piix4: Allow board to provide PCI interrupt routes Bernhard Beschow
2022-10-22 15:04 ` [PATCH v2 31/43] hw/isa/piix4: Remove unused code Bernhard Beschow
2022-10-22 15:04 ` [PATCH v2 32/43] hw/isa/piix4: Use ISA PIC device Bernhard Beschow
2022-10-22 15:04 ` [PATCH v2 33/43] hw/isa/piix4: Reuse struct PIIXState from PIIX3 Bernhard Beschow
2022-10-22 15:04 ` [PATCH v2 34/43] hw/isa/piix4: Rename reset control operations to match PIIX3 Bernhard Beschow
2022-10-24 5:20 ` Philippe Mathieu-Daudé
2022-10-22 15:05 ` [PATCH v2 35/43] hw/isa/piix4: Prefix pci_slot_get_pirq() with "piix4_" Bernhard Beschow
2022-10-22 15:05 ` [PATCH v2 36/43] hw/isa/piix3: Merge hw/isa/piix4.c Bernhard Beschow
2022-10-22 15:05 ` [PATCH v2 37/43] hw/isa/piix: Harmonize names of reset control memory regions Bernhard Beschow
2022-10-24 5:21 ` Philippe Mathieu-Daudé
2022-10-22 15:05 ` [PATCH v2 38/43] hw/isa/piix: Reuse PIIX3 base class' realize method in PIIX4 Bernhard Beschow
2022-10-22 15:05 ` [PATCH v2 39/43] hw/isa/piix: Rename functions to be shared for interrupt triggering Bernhard Beschow
2022-10-22 15:05 ` [PATCH v2 40/43] hw/isa/piix: Consolidate IRQ triggering Bernhard Beschow
2022-10-22 15:05 ` [PATCH v2 41/43] hw/isa/piix: Share PIIX3 base class with PIIX4 Bernhard Beschow
2022-10-22 15:05 ` Bernhard Beschow [this message]
2022-10-22 15:05 ` [PATCH v2 43/43] hw/i386/acpi-build: Resolve PIIX ISA bridge rather than ACPI controller Bernhard Beschow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221022150508.26830-43-shentey@gmail.com \
--to=shentey@gmail.com \
--cc=ani@anisinha.ca \
--cc=aurelien@aurel32.net \
--cc=eduardo@habkost.net \
--cc=f4bug@amsat.org \
--cc=hpoussin@reactos.org \
--cc=imammedo@redhat.com \
--cc=jiaxun.yang@flygoat.com \
--cc=jsnow@redhat.com \
--cc=kraxel@redhat.com \
--cc=marcel.apfelbaum@gmail.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).