From: Richard Henderson <richard.henderson@linaro.org>
To: qemu-devel@nongnu.org
Cc: stefanha@redhat.com, "Alex Bennée" <alex.bennee@linaro.org>
Subject: [PULL 14/47] accel/tcg: Remove duplicate store to tb->page_addr[]
Date: Wed, 26 Oct 2022 12:10:43 +1000 [thread overview]
Message-ID: <20221026021116.1988449-15-richard.henderson@linaro.org> (raw)
In-Reply-To: <20221026021116.1988449-1-richard.henderson@linaro.org>
When we added the fast path, we initialized page_addr[] early.
These stores in and around tb_page_add() are redundant; remove them.
Fixes: 50627f1b7b1 ("accel/tcg: Add fast path for translator_ld*")
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
accel/tcg/tb-maint.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/accel/tcg/tb-maint.c b/accel/tcg/tb-maint.c
index 9af5cb49e0..7f4e1e1299 100644
--- a/accel/tcg/tb-maint.c
+++ b/accel/tcg/tb-maint.c
@@ -405,7 +405,6 @@ static inline void tb_page_add(PageDesc *p, TranslationBlock *tb,
assert_page_locked(p);
- tb->page_addr[n] = page_addr;
tb->page_next[n] = p->first_tb;
#ifndef CONFIG_USER_ONLY
page_already_protected = p->first_tb != (uintptr_t)NULL;
@@ -461,8 +460,6 @@ TranslationBlock *tb_link_page(TranslationBlock *tb, tb_page_addr_t phys_pc,
tb_page_add(p, tb, 0, phys_pc);
if (p2) {
tb_page_add(p2, tb, 1, phys_page2);
- } else {
- tb->page_addr[1] = -1;
}
/* add in the hash table */
--
2.34.1
next prev parent reply other threads:[~2022-10-26 2:22 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-26 2:10 [PULL 00/47] tcg patch queue Richard Henderson
2022-10-26 2:10 ` [PULL 01/47] Revert "accel/tcg: Init TCG cflags in vCPU thread handler" Richard Henderson
2022-10-26 2:10 ` [PULL 02/47] tcg/loongarch64: Add direct jump support Richard Henderson
2022-10-26 2:10 ` [PULL 03/47] tcg/aarch64: Remove unused code in tcg_out_op Richard Henderson
2022-10-26 2:10 ` [PULL 04/47] accel/tcg: Add a quicker check for breakpoints Richard Henderson
2022-10-26 2:10 ` [PULL 05/47] include/qemu/osdep: Add qemu_build_assert Richard Henderson
2022-10-26 2:10 ` [PULL 06/47] include/qemu/atomic: Use qemu_build_assert Richard Henderson
2022-10-26 2:10 ` [PULL 07/47] include/qemu/thread: Use qatomic_* functions Richard Henderson
2022-10-26 2:10 ` [PULL 08/47] accel/tcg: Make page_alloc_target_data allocation constant Richard Henderson
2022-10-26 2:10 ` [PULL 09/47] accel/tcg: Remove disabled debug in translate-all.c Richard Henderson
2022-10-26 2:10 ` [PULL 10/47] accel/tcg: Split out PageDesc to internal.h Richard Henderson
2022-10-26 2:10 ` [PULL 11/47] accel/tcg: Split out tb-maint.c Richard Henderson
2022-10-26 2:10 ` [PULL 12/47] accel/tcg: Move assert_no_pages_locked to internal.h Richard Henderson
2022-10-26 2:10 ` [PULL 13/47] accel/tcg: Drop cpu_get_tb_cpu_state from TARGET_HAS_PRECISE_SMC Richard Henderson
2022-10-26 2:10 ` Richard Henderson [this message]
2022-10-26 2:10 ` [PULL 15/47] accel/tcg: Introduce tb_{set_}page_addr{0,1} Richard Henderson
2022-10-26 2:10 ` [PULL 16/47] accel/tcg: Rename tb_invalidate_phys_page Richard Henderson
2022-10-26 2:10 ` [PULL 17/47] accel/tcg: Rename tb_invalidate_phys_page_range and drop end parameter Richard Henderson
2022-10-26 2:10 ` [PULL 18/47] accel/tcg: Unify declarations of tb_invalidate_phys_range Richard Henderson
2022-10-26 2:10 ` [PULL 19/47] accel/tcg: Use tb_invalidate_phys_page in page_set_flags Richard Henderson
2022-10-26 2:10 ` [PULL 20/47] accel/tcg: Call tb_invalidate_phys_page for PAGE_RESET Richard Henderson
2022-10-26 2:10 ` [PULL 21/47] accel/tcg: Use page_reset_target_data in page_set_flags Richard Henderson
2022-10-26 2:10 ` [PULL 22/47] accel/tcg: Use tb_invalidate_phys_range " Richard Henderson
2022-10-26 2:10 ` [PULL 23/47] accel/tcg: Move TARGET_PAGE_DATA_SIZE impl to user-exec.c Richard Henderson
2022-10-26 2:10 ` [PULL 24/47] accel/tcg: Simplify page_get/alloc_target_data Richard Henderson
2022-10-26 2:10 ` [PULL 25/47] accel/tcg: Add restore_state_to_opc to TCGCPUOps Richard Henderson
2022-10-29 10:42 ` Alex Bennée
2022-10-31 0:10 ` Richard Henderson
2022-10-31 17:56 ` Christian Schoenebeck
2022-10-31 20:35 ` Richard Henderson
2022-10-31 20:53 ` Stefan Hajnoczi
2022-10-31 21:27 ` Mark Cave-Ayland
2022-10-31 22:03 ` Richard Henderson
2022-10-26 2:10 ` [PULL 26/47] target/alpha: Convert to tcg_ops restore_state_to_opc Richard Henderson
2022-10-26 2:10 ` [PULL 27/47] target/arm: " Richard Henderson
2022-10-26 2:10 ` [PULL 28/47] target/avr: " Richard Henderson
2022-10-26 2:10 ` [PULL 29/47] target/cris: " Richard Henderson
2022-10-26 2:10 ` [PULL 30/47] target/hexagon: " Richard Henderson
2022-10-26 2:11 ` [PULL 31/47] target/hppa: " Richard Henderson
2022-10-26 2:11 ` [PULL 32/47] target/i386: " Richard Henderson
2022-10-26 2:11 ` [PULL 33/47] target/loongarch: " Richard Henderson
2022-10-26 2:11 ` [PULL 34/47] target/m68k: " Richard Henderson
2022-10-26 2:11 ` [PULL 35/47] target/microblaze: " Richard Henderson
2022-10-26 2:11 ` [PULL 36/47] target/mips: " Richard Henderson
2022-10-26 2:11 ` [PULL 37/47] target/nios2: " Richard Henderson
2022-10-26 2:11 ` [PULL 38/47] target/openrisc: " Richard Henderson
2022-10-26 2:11 ` [PULL 39/47] target/ppc: " Richard Henderson
2022-10-26 2:11 ` [PULL 40/47] target/riscv: " Richard Henderson
2022-10-26 2:11 ` [PULL 41/47] target/rx: " Richard Henderson
2022-10-26 2:11 ` [PULL 42/47] target/s390x: " Richard Henderson
2022-10-26 2:11 ` [PULL 43/47] target/sh4: " Richard Henderson
2022-10-26 2:11 ` [PULL 44/47] target/sparc: " Richard Henderson
2022-10-26 2:11 ` [PULL 45/47] target/tricore: " Richard Henderson
2022-10-26 2:11 ` [PULL 46/47] target/xtensa: " Richard Henderson
2022-10-26 2:11 ` [PULL 47/47] accel/tcg: Remove restore_state_to_opc function Richard Henderson
2022-10-26 18:54 ` [PULL 00/47] tcg patch queue Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221026021116.1988449-15-richard.henderson@linaro.org \
--to=richard.henderson@linaro.org \
--cc=alex.bennee@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).