qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Konstantin Kostiuk <kkostiuk@redhat.com>
To: qemu-devel@nongnu.org, "Peter Maydell" <peter.maydell@linaro.org>,
	"Daniel P . Berrangé" <berrange@redhat.com>
Subject: [PULL 7/8] qga: Add HW address getting for FreeBSD
Date: Wed, 26 Oct 2022 20:55:17 +0300	[thread overview]
Message-ID: <20221026175518.2636846-8-kkostiuk@redhat.com> (raw)
In-Reply-To: <20221026175518.2636846-1-kkostiuk@redhat.com>

From: Alexander Ivanov <alexander.ivanov@virtuozzo.com>

Replace a dumb function in commands-bsd.c by the code of HW address
getting.

Reviewed-by: Konstantin Kostiuk <kkostiuk@redhat.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Signed-off-by: Alexander Ivanov <alexander.ivanov@virtuozzo.com>
Signed-off-by: Konstantin Kostiuk <kkostiuk@redhat.com>
---
 qga/commands-bsd.c | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

diff --git a/qga/commands-bsd.c b/qga/commands-bsd.c
index ebf0fb8b0f..15cade2d4c 100644
--- a/qga/commands-bsd.c
+++ b/qga/commands-bsd.c
@@ -20,6 +20,8 @@
 #include <sys/param.h>
 #include <sys/ucred.h>
 #include <sys/mount.h>
+#include <net/if_dl.h>
+#include <net/ethernet.h>
 #include <paths.h>
 
 #if defined(CONFIG_FSFREEZE) || defined(CONFIG_FSTRIM)
@@ -179,7 +181,20 @@ GuestCpuStatsList *qmp_guest_get_cpustats(Error **errp)
 bool guest_get_hw_addr(struct ifaddrs *ifa, unsigned char *buf,
                        bool *obtained, Error **errp)
 {
+    struct sockaddr_dl *sdp;
+
     *obtained = false;
+
+    if (ifa->ifa_addr->sa_family != AF_LINK) {
+        /* We can get HW address only for AF_LINK family. */
+        g_debug("failed to get MAC address of %s", ifa->ifa_name);
+        return true;
+    }
+
+    sdp = (struct sockaddr_dl *)ifa->ifa_addr;
+    memcpy(buf, sdp->sdl_data + sdp->sdl_nlen, ETHER_ADDR_LEN);
+    *obtained = true;
+
     return true;
 }
 #endif /* HAVE_GETIFADDRS */
-- 
2.25.1



  parent reply	other threads:[~2022-10-26 17:59 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-26 17:55 [PULL 0/8] QEMU Guest Agent patches Konstantin Kostiuk
2022-10-26 17:55 ` [PULL 1/8] qga: Add initial FreeBSD support Konstantin Kostiuk
2022-10-26 17:55 ` [PULL 2/8] qga: Move Linux-specific FS freeze/thaw code to a separate file Konstantin Kostiuk
2022-10-26 17:55 ` [PULL 3/8] qga: Add UFS freeze/thaw support for FreeBSD Konstantin Kostiuk
2022-10-26 17:55 ` [PULL 4/8] qga: Add shutdown/halt/reboot " Konstantin Kostiuk
2022-10-26 17:55 ` [PULL 5/8] qga: Add support for user password setting in FreeBSD Konstantin Kostiuk
2022-10-26 17:55 ` [PULL 6/8] qga: Move HW address getting to a separate function Konstantin Kostiuk
2022-10-26 17:55 ` Konstantin Kostiuk [this message]
2022-10-26 17:55 ` [PULL 8/8] qga: add channel path to error messages Konstantin Kostiuk
2022-10-30 22:28 ` [PULL 0/8] QEMU Guest Agent patches Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221026175518.2636846-8-kkostiuk@redhat.com \
    --to=kkostiuk@redhat.com \
    --cc=berrange@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).