From: "Wang, Lei" <lei4.wang@intel.com>
To: pbonzini@redhat.com
Cc: qemu-devel@nongnu.org, dgilbert@redhat.com, berrange@redhat.com,
xiaoyao.li@intel.com, yang.zhong@linux.intel.com
Subject: [PATCH 5/6] i386: Initialize AMX CPUID leaves with corresponding env->features[] leaves
Date: Wed, 26 Oct 2022 19:00:35 -0700 [thread overview]
Message-ID: <20221027020036.373140-6-lei4.wang@intel.com> (raw)
In-Reply-To: <20221027020036.373140-1-lei4.wang@intel.com>
The AMX-related CPUID value, i.e., CPUID(0x1D,1):EAX, CPUID(0x1D,1):EBX,
CPUID(0x1D,1):ECX and CPUID(0x1E,0):EBX are hard-coded to Sapphire Rapids
without considering future platforms.
Replace these hard-coded values with env->features[], so QEMU can pass the
right value to KVM.
Signed-off-by: Wang, Lei <lei4.wang@intel.com>
---
target/i386/cpu.c | 27 +++++++++++++--------------
1 file changed, 13 insertions(+), 14 deletions(-)
diff --git a/target/i386/cpu.c b/target/i386/cpu.c
index fc120c0694..21d9529d38 100644
--- a/target/i386/cpu.c
+++ b/target/i386/cpu.c
@@ -576,16 +576,16 @@ static CPUCacheInfo legacy_l3_cache = {
#define INTEL_PT_PSB_BITMAP (0x003f << 16) /* Support 2K,4K,8K,16K,32K,64K */
/* CPUID Leaf 0x1D constants: */
-#define INTEL_AMX_TILE_MAX_SUBLEAF 0x1
-#define INTEL_AMX_TOTAL_TILE_BYTES 0x2000
-#define INTEL_AMX_BYTES_PER_TILE 0x400
-#define INTEL_AMX_BYTES_PER_ROW 0x40
-#define INTEL_AMX_TILE_MAX_NAMES 0x8
-#define INTEL_AMX_TILE_MAX_ROWS 0x10
+#define INTEL_SPR_AMX_TILE_MAX_SUBLEAF 0x1
+#define INTEL_SPR_AMX_TOTAL_TILE_BYTES 0x2000
+#define INTEL_SPR_AMX_BYTES_PER_TILE 0x400
+#define INTEL_SPR_AMX_BYTES_PER_ROW 0x40
+#define INTEL_SPR_AMX_TILE_MAX_NAMES 0x8
+#define INTEL_SPR_AMX_TILE_MAX_ROWS 0x10
/* CPUID Leaf 0x1E constants: */
-#define INTEL_AMX_TMUL_MAX_K 0x10
-#define INTEL_AMX_TMUL_MAX_N 0x40
+#define INTEL_SPR_AMX_TMUL_MAX_K 0x10
+#define INTEL_SPR_AMX_TMUL_MAX_N 0x40
void x86_cpu_vendor_words2str(char *dst, uint32_t vendor1,
uint32_t vendor2, uint32_t vendor3)
@@ -5763,12 +5763,11 @@ void cpu_x86_cpuid(CPUX86State *env, uint32_t index, uint32_t count,
if (count == 0) {
/* Highest numbered palette subleaf */
- *eax = INTEL_AMX_TILE_MAX_SUBLEAF;
+ *eax = INTEL_SPR_AMX_TILE_MAX_SUBLEAF;
} else if (count == 1) {
- *eax = INTEL_AMX_TOTAL_TILE_BYTES |
- (INTEL_AMX_BYTES_PER_TILE << 16);
- *ebx = INTEL_AMX_BYTES_PER_ROW | (INTEL_AMX_TILE_MAX_NAMES << 16);
- *ecx = INTEL_AMX_TILE_MAX_ROWS;
+ *eax = env->features[FEAT_1D_1_EAX];
+ *ebx = env->features[FEAT_1D_1_EBX];
+ *ecx = env->features[FEAT_1D_1_ECX];
}
break;
}
@@ -5784,7 +5783,7 @@ void cpu_x86_cpuid(CPUX86State *env, uint32_t index, uint32_t count,
if (count == 0) {
/* Highest numbered palette subleaf */
- *ebx = INTEL_AMX_TMUL_MAX_K | (INTEL_AMX_TMUL_MAX_N << 8);
+ *ebx = env->features[FEAT_1E_0_EBX];
}
break;
}
--
2.34.1
next prev parent reply other threads:[~2022-10-27 2:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-27 2:00 [PATCH 0/6] Support for new CPU model SapphireRapids Wang, Lei
2022-10-27 2:00 ` [PATCH 1/6] i386: Introduce FeatureWordInfo for AMX CPUID leaf 0x1D and 0x1E Wang, Lei
2022-10-27 2:00 ` [PATCH 2/6] i386: Remove unused parameter "uint32_t bit" in feature_word_description() Wang, Lei
2022-10-27 2:00 ` [PATCH 3/6] i386: Introduce new struct "MultiBitFeatureInfo" for multi-bit features Wang, Lei
2022-10-27 2:00 ` [PATCH 4/6] i386: Mask and report unavailable multi-bit feature values Wang, Lei
2022-10-27 2:00 ` Wang, Lei [this message]
2022-10-27 2:00 ` [PATCH 6/6] i386: Add new CPU model SapphireRapids Wang, Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221027020036.373140-6-lei4.wang@intel.com \
--to=lei4.wang@intel.com \
--cc=berrange@redhat.com \
--cc=dgilbert@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=xiaoyao.li@intel.com \
--cc=yang.zhong@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).