From: Igor Mammedov <imammedo@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Julia Suvorova <jusual@redhat.com>,
qemu-devel@nongnu.org, Ani Sinha <ani@anisinha.ca>
Subject: Re: [PATCH v3 5/5] tests/acpi: update tables for new core count test
Date: Thu, 27 Oct 2022 16:11:44 +0200 [thread overview]
Message-ID: <20221027161144.58743fb1@fedora> (raw)
In-Reply-To: <20221027021016-mutt-send-email-mst@kernel.org>
On Thu, 27 Oct 2022 02:11:23 -0400
"Michael S. Tsirkin" <mst@redhat.com> wrote:
> On Tue, Oct 11, 2022 at 01:17:31PM +0200, Julia Suvorova wrote:
> > Changes in the tables (for 275 cores):
> > FACP:
> > + Use APIC Cluster Model (V4) : 1
> >
> > APIC:
> > +[02Ch 0044 1] Subtable Type : 00 [Processor Local APIC]
> > +[02Dh 0045 1] Length : 08
> > +[02Eh 0046 1] Processor ID : 00
> > +[02Fh 0047 1] Local Apic ID : 00
> > +[030h 0048 4] Flags (decoded below) : 00000001
> > + Processor Enabled : 1
> > ...
> > +
> > +[81Ch 2076 1] Subtable Type : 00 [Processor Local APIC]
> > +[81Dh 2077 1] Length : 08
> > +[81Eh 2078 1] Processor ID : FE
> > +[81Fh 2079 1] Local Apic ID : FE
> > +[820h 2080 4] Flags (decoded below) : 00000001
> > + Processor Enabled : 1
> > + Runtime Online Capable : 0
> > +
> > +[824h 2084 1] Subtable Type : 09 [Processor Local x2APIC]
> > +[825h 2085 1] Length : 10
> > +[826h 2086 2] Reserved : 0000
> > +[828h 2088 4] Processor x2Apic ID : 000000FF
> > +[82Ch 2092 4] Flags (decoded below) : 00000001
> > + Processor Enabled : 1
> > +[830h 2096 4] Processor UID : 000000FF
> > ...
> >
> > DSDT:
> > + Processor (C001, 0x01, 0x00000000, 0x00)
> > + {
> > + Method (_STA, 0, Serialized) // _STA: Status
> > + {
> > + Return (CSTA (One))
> > + }
> > +
> > + Name (_MAT, Buffer (0x08) // _MAT: Multiple APIC Table Entry
> > + {
> > + 0x00, 0x08, 0x01, 0x01, 0x01, 0x00, 0x00, 0x00 // ........
> > + })
> > + Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9
> > + {
> > + CEJ0 (One)
> > + }
> > +
> > + Method (_OST, 3, Serialized) // _OST: OSPM Status Indication
> > + {
> > + COST (One, Arg0, Arg1, Arg2)
> > + }
> > + }
> > ...
> > + Processor (C0FE, 0xFE, 0x00000000, 0x00)
> > + {
> > + Method (_STA, 0, Serialized) // _STA: Status
> > + {
> > + Return (CSTA (0xFE))
> > + }
> > +
> > + Name (_MAT, Buffer (0x08) // _MAT: Multiple APIC Table Entry
> > + {
> > + 0x00, 0x08, 0xFE, 0xFE, 0x01, 0x00, 0x00, 0x00 // ........
> > + })
> > + Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9
> > + {
> > + CEJ0 (0xFE)
> > + }
> > +
> > + Method (_OST, 3, Serialized) // _OST: OSPM Status Indication
> > + {
> > + COST (0xFE, Arg0, Arg1, Arg2)
> > + }
> > + }
> > +
> > + Device (C0FF)
> > + {
> > + Name (_HID, "ACPI0007" /* Processor Device */) // _HID: Hardware ID
> > + Name (_UID, 0xFF) // _UID: Unique ID
> > + Method (_STA, 0, Serialized) // _STA: Status
> > + {
> > + Return (CSTA (0xFF))
> > + }
> > +
> > + Name (_MAT, Buffer (0x10) // _MAT: Multiple APIC Table Entry
> > + {
> > + /* 0000 */ 0x09, 0x10, 0x00, 0x00, 0xFF, 0x00, 0x00, 0x00, // ........
> > + /* 0008 */ 0x01, 0x00, 0x00, 0x00, 0xFF, 0x00, 0x00, 0x00 // ........
> > + })
> > + Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device, x=0-9
> > + {
> > + CEJ0 (0xFF)
> > + }
> > +
> > + Method (_OST, 3, Serialized) // _OST: OSPM Status Indication
> > + {
> > + COST (0xFF, Arg0, Arg1, Arg2)
> > + }
> > + }
> > +
> > ...
> >
> > Signed-off-by: Julia Suvorova <jusual@redhat.com>
> > Message-Id: <20220731162141.178443-6-jusual@redhat.com>
>
>
>
> I had to rebase pushed last update to my tree. Could you pls
> disassemble and verify it's correct? Thanks!
new lobs look correct,
though I'd mention in commit log relevant FACP bits:
+ Use APIC Cluster Model (V4) : 1
prev parent reply other threads:[~2022-10-27 14:12 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-11 11:17 [PATCH v3 0/5] hw/smbios: add core_count2 to smbios table type 4 Julia Suvorova
2022-10-11 11:17 ` [PATCH v3 1/5] " Julia Suvorova
2022-10-11 11:17 ` [PATCH v3 2/5] bios-tables-test: teach test to use smbios 3.0 tables Julia Suvorova
2022-10-11 11:17 ` [PATCH v3 3/5] tests/acpi: allow changes for core_count2 test Julia Suvorova
2022-10-14 14:22 ` Igor Mammedov
2022-10-11 11:17 ` [PATCH v3 4/5] bios-tables-test: add test for number of cores > 255 Julia Suvorova
2022-10-14 14:22 ` Igor Mammedov
2022-10-11 11:17 ` [PATCH v3 5/5] tests/acpi: update tables for new core count test Julia Suvorova
2022-10-27 6:11 ` Michael S. Tsirkin
2022-10-27 14:11 ` Igor Mammedov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221027161144.58743fb1@fedora \
--to=imammedo@redhat.com \
--cc=ani@anisinha.ca \
--cc=jusual@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).