qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Alex Williamson <alex.williamson@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Cindy Lu <lulu@redhat.com>,
	jasowang@redhat.com, pbonzini@redhat.com, peterx@redhat.com,
	david@redhat.com, f4bug@amsat.org, sgarzare@redhat.com,
	qemu-devel@nongnu.org
Subject: Re: [PATCH v10 0/2] vhost-vdpa: add support for vIOMMU
Date: Wed, 2 Nov 2022 06:39:11 -0600	[thread overview]
Message-ID: <20221102063911.416a953f.alex.williamson@redhat.com> (raw)
In-Reply-To: <20221102065323-mutt-send-email-mst@kernel.org>

On Wed, 2 Nov 2022 06:54:28 -0400
"Michael S. Tsirkin" <mst@redhat.com> wrote:

> On Mon, Oct 31, 2022 at 08:57:00PM +0800, Cindy Lu wrote:
> > changes in V3
> > 1. Move function vfio_get_xlat_addr to memory.c
> > 2. Use the existing memory listener, while the MR is
> > iommu MR then call the function iommu_region_add/
> > iommu_region_del
> > 
> > changes in V4
> > 1.make the comments in vfio_get_xlat_addr more general
> > 
> > changes in V5
> > 1. Address the comments in the last version
> > 2. Add a new arg in the function vfio_get_xlat_addr, which shows whether
> > the memory is backed by a discard manager. So the device can have its
> > own warning.
> > 
> > changes in V6
> > move the error_report for the unpopulated discard back to
> > memeory_get_xlat_addr
> > 
> > changes in V7
> > organize the error massage to avoid the duplicate information
> > 
> > changes in V8
> > Organize the code follow the comments in the last version
> > 
> > changes in V9
> > Organize the code follow the comments
> > 
> > changes in V10
> > Address the comments  
> 
> This missed this release unfortunately, as vfio changes didn't get
> Alex's ack yet. Tagged but pls ping me after the freeze is lifted
> to make sure I don't forget. Thanks!

I ack'd v9[1], which appears identical for the vfio related pieces.
Thanks,

Alex

[1]https://lore.kernel.org/all/20221030212011.45c3d924.alex.williamson@redhat.com/



  reply	other threads:[~2022-11-02 13:12 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-31 12:57 [PATCH v10 0/2] vhost-vdpa: add support for vIOMMU Cindy Lu
2022-10-31 12:57 ` [PATCH v10 1/2] vfio: move implement of vfio_get_xlat_addr() to memory.c Cindy Lu
2022-11-02 12:45   ` Michael S. Tsirkin
2022-10-31 12:57 ` [PATCH v10 2/2] vhost-vdpa: add support for vIOMMU Cindy Lu
2022-11-02 12:49   ` Michael S. Tsirkin
2022-11-02 10:54 ` [PATCH v10 0/2] " Michael S. Tsirkin
2022-11-02 12:39   ` Alex Williamson [this message]
2022-11-02 12:44     ` Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221102063911.416a953f.alex.williamson@redhat.com \
    --to=alex.williamson@redhat.com \
    --cc=david@redhat.com \
    --cc=f4bug@amsat.org \
    --cc=jasowang@redhat.com \
    --cc=lulu@redhat.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peterx@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=sgarzare@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).