From: "Wang, Lei" <lei4.wang@intel.com>
To: pbonzini@redhat.com
Cc: qemu-devel@nongnu.org, dgilbert@redhat.com, berrange@redhat.com,
xiaoyao.li@intel.com, yang.zhong@linux.intel.com
Subject: [PATCH v2 2/6] i386: Remove unused parameter "uint32_t bit" in feature_word_description()
Date: Wed, 2 Nov 2022 01:52:52 -0700 [thread overview]
Message-ID: <20221102085256.81139-3-lei4.wang@intel.com> (raw)
In-Reply-To: <20221102085256.81139-1-lei4.wang@intel.com>
Parameter "uint32_t bit" is not used in function feature_word_description(),
so remove it.
Signed-off-by: Wang, Lei <lei4.wang@intel.com>
---
target/i386/cpu.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/target/i386/cpu.c b/target/i386/cpu.c
index e98780773c..0083a2a7f7 100644
--- a/target/i386/cpu.c
+++ b/target/i386/cpu.c
@@ -4290,7 +4290,7 @@ static const TypeInfo max_x86_cpu_type_info = {
.class_init = max_x86_cpu_class_init,
};
-static char *feature_word_description(FeatureWordInfo *f, uint32_t bit)
+static char *feature_word_description(FeatureWordInfo *f)
{
assert(f->type == CPUID_FEATURE_WORD || f->type == MSR_FEATURE_WORD);
@@ -4329,6 +4329,7 @@ static void mark_unavailable_features(X86CPU *cpu, FeatureWord w, uint64_t mask,
CPUX86State *env = &cpu->env;
FeatureWordInfo *f = &feature_word_info[w];
int i;
+ g_autofree char *feat_word_str = feature_word_description(f);
if (!cpu->force_features) {
env->features[w] &= ~mask;
@@ -4341,7 +4342,6 @@ static void mark_unavailable_features(X86CPU *cpu, FeatureWord w, uint64_t mask,
for (i = 0; i < 64; ++i) {
if ((1ULL << i) & mask) {
- g_autofree char *feat_word_str = feature_word_description(f, i);
warn_report("%s: %s%s%s [bit %d]",
verbose_prefix,
feat_word_str,
--
2.34.1
next prev parent reply other threads:[~2022-11-02 8:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-02 8:52 [PATCH v2 0/6] Support for new CPU model SapphireRapids Wang, Lei
2022-11-02 8:52 ` [PATCH v2 1/6] i386: Introduce FeatureWordInfo for AMX CPUID leaf 0x1D and 0x1E Wang, Lei
2022-11-02 8:52 ` Wang, Lei [this message]
2022-11-02 8:52 ` [PATCH v2 3/6] i386: Introduce new struct "MultiBitFeatureInfo" for multi-bit features Wang, Lei
2022-11-02 8:52 ` [PATCH v2 4/6] i386: Mask and report unavailable multi-bit feature values Wang, Lei
2022-11-02 8:52 ` [PATCH v2 5/6] i386: Initialize AMX CPUID leaves with corresponding env->features[] leaves Wang, Lei
2022-11-02 8:52 ` [PATCH v2 6/6] i386: Add new CPU model SapphireRapids Wang, Lei
2022-12-19 5:52 ` [PATCH v2 0/6] Support for " Wang, Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221102085256.81139-3-lei4.wang@intel.com \
--to=lei4.wang@intel.com \
--cc=berrange@redhat.com \
--cc=dgilbert@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=xiaoyao.li@intel.com \
--cc=yang.zhong@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).