* [PATCH] s390x/tcg: Fix LDER instruction format
@ 2022-11-02 9:43 Ilya Leoshkevich
2022-11-02 9:49 ` David Hildenbrand
0 siblings, 1 reply; 2+ messages in thread
From: Ilya Leoshkevich @ 2022-11-02 9:43 UTC (permalink / raw)
To: Richard Henderson, David Hildenbrand
Cc: qemu-devel, qemu-s390x, Christian Borntraeger, Ilya Leoshkevich
It's RRE, not RXE.
Found by running valgrind's none/tests/s390x/bfp-2.
Fixes: 86b59624c4aa ("s390x/tcg: Implement LOAD LENGTHENED short HFP to long HFP")
Signed-off-by: Ilya Leoshkevich <iii@linux.ibm.com>
---
target/s390x/tcg/insn-data.def | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target/s390x/tcg/insn-data.def b/target/s390x/tcg/insn-data.def
index 26523746d64..6028472c323 100644
--- a/target/s390x/tcg/insn-data.def
+++ b/target/s390x/tcg/insn-data.def
@@ -606,7 +606,7 @@
F(0xed04, LDEB, RXE, Z, 0, m2_32u, new, f1, ldeb, 0, IF_BFP)
F(0xed05, LXDB, RXE, Z, 0, m2_64, new_x, x1, lxdb, 0, IF_BFP)
F(0xed06, LXEB, RXE, Z, 0, m2_32u, new_x, x1, lxeb, 0, IF_BFP)
- F(0xb324, LDER, RXE, Z, 0, e2, new, f1, lde, 0, IF_AFP1)
+ F(0xb324, LDER, RRE, Z, 0, e2, new, f1, lde, 0, IF_AFP1)
F(0xed24, LDE, RXE, Z, 0, m2_32u, new, f1, lde, 0, IF_AFP1)
/* LOAD ROUNDED */
F(0xb344, LEDBR, RRF_e, Z, 0, f2, new, e1, ledb, 0, IF_BFP)
--
2.37.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] s390x/tcg: Fix LDER instruction format
2022-11-02 9:43 [PATCH] s390x/tcg: Fix LDER instruction format Ilya Leoshkevich
@ 2022-11-02 9:49 ` David Hildenbrand
0 siblings, 0 replies; 2+ messages in thread
From: David Hildenbrand @ 2022-11-02 9:49 UTC (permalink / raw)
To: Ilya Leoshkevich, Richard Henderson
Cc: qemu-devel, qemu-s390x, Christian Borntraeger
On 02.11.22 10:43, Ilya Leoshkevich wrote:
> It's RRE, not RXE.
>
> Found by running valgrind's none/tests/s390x/bfp-2.
>
> Fixes: 86b59624c4aa ("s390x/tcg: Implement LOAD LENGTHENED short HFP to long HFP")
> Signed-off-by: Ilya Leoshkevich <iii@linux.ibm.com>
> ---
> target/s390x/tcg/insn-data.def | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/target/s390x/tcg/insn-data.def b/target/s390x/tcg/insn-data.def
> index 26523746d64..6028472c323 100644
> --- a/target/s390x/tcg/insn-data.def
> +++ b/target/s390x/tcg/insn-data.def
> @@ -606,7 +606,7 @@
> F(0xed04, LDEB, RXE, Z, 0, m2_32u, new, f1, ldeb, 0, IF_BFP)
> F(0xed05, LXDB, RXE, Z, 0, m2_64, new_x, x1, lxdb, 0, IF_BFP)
> F(0xed06, LXEB, RXE, Z, 0, m2_32u, new_x, x1, lxeb, 0, IF_BFP)
> - F(0xb324, LDER, RXE, Z, 0, e2, new, f1, lde, 0, IF_AFP1)
> + F(0xb324, LDER, RRE, Z, 0, e2, new, f1, lde, 0, IF_AFP1)
> F(0xed24, LDE, RXE, Z, 0, m2_32u, new, f1, lde, 0, IF_AFP1)
> /* LOAD ROUNDED */
> F(0xb344, LEDBR, RRF_e, Z, 0, f2, new, e1, ledb, 0, IF_BFP)
Reviewed-by: David Hildenbrand <david@redhat.com>
--
Thanks,
David / dhildenb
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-11-02 9:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-11-02 9:43 [PATCH] s390x/tcg: Fix LDER instruction format Ilya Leoshkevich
2022-11-02 9:49 ` David Hildenbrand
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).