From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 984E4C4332F for ; Thu, 3 Nov 2022 10:54:57 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oqXrk-0003a7-UA; Thu, 03 Nov 2022 06:54:32 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oqXrj-0003Zo-16; Thu, 03 Nov 2022 06:54:31 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oqXrg-0007Us-Vh; Thu, 03 Nov 2022 06:54:30 -0400 Received: from pps.filterd (m0187473.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 2A39cRp5008919; Thu, 3 Nov 2022 10:54:26 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=pp1; bh=dnnRIJcCPYBmDROhA0QUVxm8fiiecvc3tfCQ2kzknWE=; b=bWEoDQC7LHuoXaWgyt6pxSrP67Vr3MZB50TtnWRAspcSpvIOg7bT6GIUZs2Y6HZtskrY wMRXWBZS2a81DxIbc9mM39Wkvl6ON5a47W1FDGTT4OQn6pezDyMvOOXJdGddAMYFWPKo GDLBG6Vfv1Pa1E52PO5x+Nrl2d1qwgW2XUOebsnG4kf9lVvrtIL/0mJDCv9f4rxKFzim 4FTJ3I9mLBibMr9li8rBfEptII04Bgc+vfmqYjtHQRyjiRA4wl6hh/cByNGj4yfeh3Tq lmrPmvxWgtXzHO78LGZ3W+CaH+2unnktA12NFp6nULfu8KWdaBlafHg913H0kzfUIbH2 pA== Received: from ppma01fra.de.ibm.com (46.49.7a9f.ip4.static.sl-reverse.com [159.122.73.70]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3km9mncnxe-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 03 Nov 2022 10:54:25 +0000 Received: from pps.filterd (ppma01fra.de.ibm.com [127.0.0.1]) by ppma01fra.de.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 2A3ApMsO026960; Thu, 3 Nov 2022 10:54:23 GMT Received: from b06avi18878370.portsmouth.uk.ibm.com (b06avi18878370.portsmouth.uk.ibm.com [9.149.26.194]) by ppma01fra.de.ibm.com with ESMTP id 3kgut9ed70-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 03 Nov 2022 10:54:23 +0000 Received: from d06av22.portsmouth.uk.ibm.com (d06av22.portsmouth.uk.ibm.com [9.149.105.58]) by b06avi18878370.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 2A3Asv4F51970530 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 3 Nov 2022 10:54:57 GMT Received: from d06av22.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 268134C046; Thu, 3 Nov 2022 10:54:21 +0000 (GMT) Received: from d06av22.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id E0C374C040; Thu, 3 Nov 2022 10:54:20 +0000 (GMT) Received: from heavy (unknown [9.171.39.72]) by d06av22.portsmouth.uk.ibm.com (Postfix) with ESMTPS; Thu, 3 Nov 2022 10:54:20 +0000 (GMT) Date: Thu, 3 Nov 2022 11:54:19 +0100 From: Ilya Leoshkevich To: Richard Henderson , qemu-devel@nongnu.org Cc: qemu-s390x@nongnu.org Subject: Re: [PATCH 02/26] target/s390x: Use tcg_constant_* for DisasCompare Message-ID: <20221103105419.2yi7x7cgpcf65kkn@heavy> References: <20221006034421.1179141-1-richard.henderson@linaro.org> <20221006034421.1179141-3-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221006034421.1179141-3-richard.henderson@linaro.org> X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: ELwtXSWVD2w0SK-zonbjh2vIRyfDWdjk X-Proofpoint-GUID: ELwtXSWVD2w0SK-zonbjh2vIRyfDWdjk X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2022-11-03_02,2022-11-03_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 lowpriorityscore=0 priorityscore=1501 spamscore=0 mlxscore=0 mlxlogscore=547 suspectscore=0 impostorscore=0 clxscore=1015 phishscore=0 adultscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2210170000 definitions=main-2211030073 Received-SPF: pass client-ip=148.163.156.1; envelope-from=iii@linux.ibm.com; helo=mx0a-001b2d01.pphosted.com X-Spam_score_int: -19 X-Spam_score: -2.0 X-Spam_bar: -- X-Spam_report: (-2.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Qemu-devel" Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Wed, Oct 05, 2022 at 08:43:57PM -0700, Richard Henderson wrote: > The a and b fields are not modified by the consumer, > and while we need not free a constant, tcg will quietly > ignore such frees, so free_compare need not be changed. > > Signed-off-by: Richard Henderson > --- > target/s390x/tcg/translate.c | 44 ++++++++++++++++++------------------ > 1 file changed, 22 insertions(+), 22 deletions(-) I did not check all the code paths in the consumer, but if there is a bug and a or b ends up being modified, one of the temp_readonly() assertions will catch it. Reviewed-by: Ilya Leoshkevich