From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: qemu-devel@nongnu.org
Cc: "Laurent Vivier" <laurent@vivier.eu>,
"Helge Deller" <deller@gmx.de>, "Drew DeVault" <sir@cmpwn.com>,
"Daniel P . Berrangé" <berrange@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>
Subject: [PATCH v5 5/5] linux-user/syscall: Implement execveat()
Date: Fri, 4 Nov 2022 18:36:32 +0100 [thread overview]
Message-ID: <20221104173632.1052-6-philmd@linaro.org> (raw)
In-Reply-To: <20221104173632.1052-1-philmd@linaro.org>
From: Drew DeVault <sir@cmpwn.com>
References: https://gitlab.com/qemu-project/qemu/-/issues/1007
Signed-off-by: Drew DeVault <sir@cmpwn.com>
Reviewed-by: Laurent Vivier <laurent@vivier.eu>
Message-Id: <20221104081015.706009-1-sir@cmpwn.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
linux-user/syscall.c | 15 +++++++++------
1 file changed, 9 insertions(+), 6 deletions(-)
diff --git a/linux-user/syscall.c b/linux-user/syscall.c
index c3ac6bb4d2..c267db9542 100644
--- a/linux-user/syscall.c
+++ b/linux-user/syscall.c
@@ -696,7 +696,8 @@ safe_syscall4(pid_t, wait4, pid_t, pid, int *, status, int, options, \
#endif
safe_syscall5(int, waitid, idtype_t, idtype, id_t, id, siginfo_t *, infop, \
int, options, struct rusage *, rusage)
-safe_syscall3(int, execve, const char *, filename, char **, argv, char **, envp)
+safe_syscall5(int, execveat, int, dirfd, const char *, filename,
+ char **, argv, char **, envp, int, flags)
#if defined(TARGET_NR_select) || defined(TARGET_NR__newselect) || \
defined(TARGET_NR_pselect6) || defined(TARGET_NR_pselect6_time64)
safe_syscall6(int, pselect6, int, nfds, fd_set *, readfds, fd_set *, writefds, \
@@ -8357,9 +8358,9 @@ static int do_openat(CPUArchState *cpu_env, int dirfd, const char *pathname, int
return safe_openat(dirfd, path(pathname), flags, mode);
}
-static int do_execve(CPUArchState *cpu_env,
+static int do_execveat(CPUArchState *cpu_env, int dirfd,
abi_long pathname, abi_long guest_argp,
- abi_long guest_envp)
+ abi_long guest_envp, int flags)
{
int ret;
char **argp, **envp;
@@ -8439,9 +8440,9 @@ static int do_execve(CPUArchState *cpu_env,
}
if (is_proc_myself(p, "exe")) {
- ret = get_errno(safe_execve(exec_path, argp, envp));
+ ret = get_errno(safe_execveat(dirfd, exec_path, argp, envp, flags));
} else {
- ret = get_errno(safe_execve(p, argp, envp));
+ ret = get_errno(safe_execveat(dirfd, p, argp, envp, flags));
}
unlock_user(p, pathname, 0);
@@ -8979,8 +8980,10 @@ static abi_long do_syscall1(CPUArchState *cpu_env, int num, abi_long arg1,
unlock_user(p, arg2, 0);
return ret;
#endif
+ case TARGET_NR_execveat:
+ return do_execveat(cpu_env, arg1, arg2, arg3, arg4, arg5);
case TARGET_NR_execve:
- return do_execve(cpu_env, arg1, arg2, arg3);
+ return do_execveat(cpu_env, AT_FDCWD, arg1, arg2, arg3, 0);
case TARGET_NR_chdir:
if (!(p = lock_user_string(arg1)))
return -TARGET_EFAULT;
--
2.38.1
next prev parent reply other threads:[~2022-11-04 17:37 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-04 17:36 [PATCH v5 0/5] linux-user: implement execveat Philippe Mathieu-Daudé
2022-11-04 17:36 ` [PATCH v5 1/5] linux-user/strace: Constify struct flags Philippe Mathieu-Daudé
2023-01-25 9:20 ` Laurent Vivier
2022-11-04 17:36 ` [PATCH v5 2/5] linux-user/strace: Extract print_execve_argv() from print_execve() Philippe Mathieu-Daudé
2023-01-25 9:28 ` Laurent Vivier
2022-11-04 17:36 ` [PATCH v5 3/5] linux-user/strace: Add output for execveat() syscall Philippe Mathieu-Daudé
2023-01-25 9:33 ` Laurent Vivier
2022-11-04 17:36 ` [PATCH v5 4/5] linux-user/syscall: Extract do_execve() from do_syscall1() Philippe Mathieu-Daudé
2023-01-25 9:36 ` Laurent Vivier
2022-11-04 17:36 ` Philippe Mathieu-Daudé [this message]
2023-01-25 9:46 ` [PATCH v5 0/5] linux-user: implement execveat Laurent Vivier
2023-01-25 9:47 ` Drew DeVault
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221104173632.1052-6-philmd@linaro.org \
--to=philmd@linaro.org \
--cc=berrange@redhat.com \
--cc=deller@gmx.de \
--cc=laurent@vivier.eu \
--cc=qemu-devel@nongnu.org \
--cc=sir@cmpwn.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).