From: "Alex Bennée" <alex.bennee@linaro.org>
To: qemu-devel@nongnu.org
Cc: fam@euphon.net, berrange@redhat.com, f4bug@amsat.org,
aurelien@aurel32.net, pbonzini@redhat.com, stefanha@redhat.com,
crosa@redhat.com, "Alex Bennée" <alex.bennee@linaro.org>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Thomas Huth" <thuth@redhat.com>,
"Wainer dos Santos Moschetta" <wainersm@redhat.com>,
"Beraldo Leal" <bleal@redhat.com>
Subject: [PATCH v1 4/9] tests/docker: allow user to override check target
Date: Tue, 8 Nov 2022 09:23:03 +0000 [thread overview]
Message-ID: <20221108092308.1717426-5-alex.bennee@linaro.org> (raw)
In-Reply-To: <20221108092308.1717426-1-alex.bennee@linaro.org>
This is useful when trying to bisect a particular failing test behind
a docker run. For example:
make docker-test-clang@fedora \
TARGET_LIST=arm-softmmu \
TEST_COMMAND="meson test qtest-arm/qos-test" \
J=9 V=1
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
---
v1
- fix s/target /target./
- CHECK_TARGET -> TEST_COMMAND
---
tests/docker/Makefile.include | 2 ++
tests/docker/common.rc | 6 +++---
2 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/tests/docker/Makefile.include b/tests/docker/Makefile.include
index c87f14477a..fc7a3b7e71 100644
--- a/tests/docker/Makefile.include
+++ b/tests/docker/Makefile.include
@@ -184,6 +184,7 @@ docker:
@echo ' TARGET_LIST=a,b,c Override target list in builds.'
@echo ' EXTRA_CONFIGURE_OPTS="..."'
@echo ' Extra configure options.'
+ @echo ' TEST_COMMAND="..." Override the default `make check` target.'
@echo ' IMAGES="a b c ..": Restrict available images to subset.'
@echo ' TESTS="x y z .." Restrict available tests to subset.'
@echo ' J=[0..9]* Overrides the -jN parameter for make commands'
@@ -230,6 +231,7 @@ docker-run: docker-qemu-src
$(if $(NETWORK),$(if $(subst $(NETWORK),,1),--net=$(NETWORK)),--net=none) \
-e TARGET_LIST=$(subst $(SPACE),$(COMMA),$(TARGET_LIST)) \
-e EXTRA_CONFIGURE_OPTS="$(EXTRA_CONFIGURE_OPTS)" \
+ -e TEST_COMMAND="$(TEST_COMMAND)" \
-e V=$V -e J=$J -e DEBUG=$(DEBUG) \
-e SHOW_ENV=$(SHOW_ENV) \
$(if $(NOUSER),, \
diff --git a/tests/docker/common.rc b/tests/docker/common.rc
index e6f8cee0d6..9a33df2832 100755
--- a/tests/docker/common.rc
+++ b/tests/docker/common.rc
@@ -63,12 +63,12 @@ check_qemu()
{
# default to make check unless the caller specifies
if [ $# = 0 ]; then
- INVOCATION="check"
+ INVOCATION="${TEST_COMMAND:-make $MAKEFLAGS check}"
else
- INVOCATION="$@"
+ INVOCATION="make $MAKEFLAGS $@"
fi
- make $MAKEFLAGS $INVOCATION
+ $INVOCATION
}
test_fail()
--
2.34.1
next prev parent reply other threads:[~2022-11-08 9:23 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-08 9:22 [PATCH v1 for 7.2 0/9] test and doc updates Alex Bennée
2022-11-08 9:23 ` [PATCH v1 1/9] Run docker probe only if docker or podman are available Alex Bennée
2022-11-08 9:23 ` [PATCH v1 2/9] tests/avocado: improve behaviour waiting for login prompts Alex Bennée
2022-11-08 11:23 ` Philippe Mathieu-Daudé
2022-11-08 21:19 ` John Snow
2022-11-08 9:23 ` [PATCH v1 3/9] tests/avocado/machine_aspeed.py: Reduce noise on the console for SDK tests Alex Bennée
2022-11-08 9:23 ` Alex Bennée [this message]
2022-11-08 11:12 ` [PATCH v1 4/9] tests/docker: allow user to override check target Philippe Mathieu-Daudé
2022-11-08 9:23 ` [PATCH v1 5/9] hw/virtio: introduce virtio_device_should_start Alex Bennée
2022-11-08 9:32 ` Michael S. Tsirkin
2022-11-08 10:23 ` Alex Bennée
2022-11-08 10:26 ` Michael S. Tsirkin
2022-11-08 11:21 ` Alex Bennée
2022-11-08 15:24 ` Michael S. Tsirkin
2022-11-08 16:41 ` Alex Bennée
2022-11-08 9:33 ` Michael S. Tsirkin
2022-11-14 16:18 ` Christian Borntraeger
2022-11-14 16:37 ` Michael S. Tsirkin
2022-11-14 16:55 ` Christian Borntraeger
2022-11-14 17:10 ` Michael S. Tsirkin
2022-11-14 17:15 ` Christian Borntraeger
2022-11-14 17:20 ` Michael S. Tsirkin
2022-11-15 7:44 ` Christian Borntraeger
2022-11-15 8:18 ` Christian Borntraeger
2022-11-15 9:05 ` Michael S. Tsirkin
2022-11-15 11:25 ` Michael S. Tsirkin
2022-11-15 13:25 ` Christian Borntraeger
2022-11-15 14:31 ` Alex Bennée
2022-11-15 15:09 ` Christian Borntraeger
2022-11-15 16:05 ` Alex Bennée
2022-11-15 16:40 ` Christian Borntraeger
2022-11-15 16:46 ` Christian Borntraeger
2022-11-21 22:37 ` Michael S. Tsirkin
2022-11-23 6:27 ` Christian Borntraeger
2022-11-14 16:43 ` Alex Bennée
2022-11-08 9:23 ` [PATCH v1 6/9] docs/devel: add a maintainers section to development process Alex Bennée
2022-11-08 9:23 ` [PATCH v1 7/9] docs/devel: make language a little less code centric Alex Bennée
2022-11-08 9:23 ` [PATCH v1 8/9] docs/devel: simplify the minimal checklist Alex Bennée
2022-11-08 9:23 ` [PATCH v1 9/9] docs/devel: try and improve the language around patch review Alex Bennée
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221108092308.1717426-5-alex.bennee@linaro.org \
--to=alex.bennee@linaro.org \
--cc=aurelien@aurel32.net \
--cc=berrange@redhat.com \
--cc=bleal@redhat.com \
--cc=crosa@redhat.com \
--cc=f4bug@amsat.org \
--cc=fam@euphon.net \
--cc=pbonzini@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=thuth@redhat.com \
--cc=wainersm@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).