From: Thomas Huth <thuth@redhat.com>
To: Stefan Hajnoczi <stefanha@redhat.com>, qemu-devel@nongnu.org
Cc: qemu-s390x@nongnu.org, kraxel@redhat.com,
"Cédric Le Goater" <clg@redhat.com>,
"Matthew Rosato" <mjrosato@linux.ibm.com>
Subject: [PULL 2/5] s390x/s390-virtio-ccw: Switch off zPCI enhancements on older machines
Date: Tue, 8 Nov 2022 12:33:10 +0100 [thread overview]
Message-ID: <20221108113313.467923-3-thuth@redhat.com> (raw)
In-Reply-To: <20221108113313.467923-1-thuth@redhat.com>
From: Cédric Le Goater <clg@redhat.com>
zPCI enhancement features (interpretation and forward assist) were
recently introduced to improve performance on PCI passthrough devices.
To maintain the same behaviour on older Z machines, deactivate the
features with the associated properties.
Signed-off-by: Cédric Le Goater <clg@redhat.com>
Message-Id: <20221107161349.1032730-3-clg@kaod.org>
Reviewed-by: Matthew Rosato <mjrosato@linux.ibm.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
hw/s390x/s390-virtio-ccw.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/hw/s390x/s390-virtio-ccw.c b/hw/s390x/s390-virtio-ccw.c
index bb98d40792..7d80bc1837 100644
--- a/hw/s390x/s390-virtio-ccw.c
+++ b/hw/s390x/s390-virtio-ccw.c
@@ -844,9 +844,14 @@ static void ccw_machine_7_1_instance_options(MachineState *machine)
static void ccw_machine_7_1_class_options(MachineClass *mc)
{
S390CcwMachineClass *s390mc = S390_CCW_MACHINE_CLASS(mc);
+ static GlobalProperty compat[] = {
+ { TYPE_S390_PCI_DEVICE, "interpret", "off", },
+ { TYPE_S390_PCI_DEVICE, "forwarding-assist", "off", },
+ };
ccw_machine_7_2_class_options(mc);
compat_props_add(mc->compat_props, hw_compat_7_1, hw_compat_7_1_len);
+ compat_props_add(mc->compat_props, compat, G_N_ELEMENTS(compat));
s390mc->max_threads = S390_MAX_CPUS;
}
DEFINE_CCW_MACHINE(7_1, "7.1", false);
--
2.31.1
next prev parent reply other threads:[~2022-11-08 11:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-08 11:33 [PULL 0/5] s390x fix and white space cleanup Thomas Huth
2022-11-08 11:33 ` [PULL 1/5] Revert "s390x/s390-virtio-ccw: add zpcii-disable machine property" Thomas Huth
2022-11-08 11:33 ` Thomas Huth [this message]
2022-11-08 11:33 ` [PULL 3/5] ui: fix tab indentation Thomas Huth
2022-11-08 11:33 ` [PULL 4/5] hw/display: " Thomas Huth
2022-11-08 11:33 ` [PULL 5/5] hw/usb: " Thomas Huth
2022-11-08 18:08 ` [PULL 0/5] s390x fix and white space cleanup Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221108113313.467923-3-thuth@redhat.com \
--to=thuth@redhat.com \
--cc=clg@redhat.com \
--cc=kraxel@redhat.com \
--cc=mjrosato@linux.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).