* [PATCH] qapi/block-core: Fix BlockdevOptionsNvmeIoUring @path description
@ 2022-11-08 14:23 Alberto Faria
2022-11-09 8:21 ` Stefano Garzarella
2022-11-10 13:47 ` Kevin Wolf
0 siblings, 2 replies; 3+ messages in thread
From: Alberto Faria @ 2022-11-08 14:23 UTC (permalink / raw)
To: qemu-devel
Cc: Stefan Hajnoczi, Kevin Wolf, Eric Blake, Hanna Reitz,
Markus Armbruster, qemu-block, Alberto Faria, Stefano Garzarella
The nvme-io_uring BlockDriver's path option must point at the character
device of an NVMe namespace, not at an image file.
Fixes: fd66dbd424f5 ("blkio: add libblkio block driver")
Suggested-by: Stefano Garzarella <sgarzare@redhat.com>
Signed-off-by: Alberto Faria <afaria@redhat.com>
---
qapi/block-core.json | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/qapi/block-core.json b/qapi/block-core.json
index 6d904004f8..95ac4fa634 100644
--- a/qapi/block-core.json
+++ b/qapi/block-core.json
@@ -3704,7 +3704,7 @@
#
# Driver specific block device options for the nvme-io_uring backend.
#
-# @path: path to the image file
+# @path: path to the NVMe namespace's character device (e.g. /dev/ng0n1).
#
# Since: 7.2
##
--
2.38.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] qapi/block-core: Fix BlockdevOptionsNvmeIoUring @path description
2022-11-08 14:23 [PATCH] qapi/block-core: Fix BlockdevOptionsNvmeIoUring @path description Alberto Faria
@ 2022-11-09 8:21 ` Stefano Garzarella
2022-11-10 13:47 ` Kevin Wolf
1 sibling, 0 replies; 3+ messages in thread
From: Stefano Garzarella @ 2022-11-09 8:21 UTC (permalink / raw)
To: Alberto Faria
Cc: qemu-devel, Stefan Hajnoczi, Kevin Wolf, Eric Blake, Hanna Reitz,
Markus Armbruster, qemu-block
On Tue, Nov 08, 2022 at 02:23:47PM +0000, Alberto Faria wrote:
>The nvme-io_uring BlockDriver's path option must point at the character
>device of an NVMe namespace, not at an image file.
>
>Fixes: fd66dbd424f5 ("blkio: add libblkio block driver")
>Suggested-by: Stefano Garzarella <sgarzare@redhat.com>
>Signed-off-by: Alberto Faria <afaria@redhat.com>
>---
> qapi/block-core.json | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Thanks for fixing this:
Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>
>
>diff --git a/qapi/block-core.json b/qapi/block-core.json
>index 6d904004f8..95ac4fa634 100644
>--- a/qapi/block-core.json
>+++ b/qapi/block-core.json
>@@ -3704,7 +3704,7 @@
> #
> # Driver specific block device options for the nvme-io_uring backend.
> #
>-# @path: path to the image file
>+# @path: path to the NVMe namespace's character device (e.g. /dev/ng0n1).
> #
> # Since: 7.2
> ##
>--
>2.38.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] qapi/block-core: Fix BlockdevOptionsNvmeIoUring @path description
2022-11-08 14:23 [PATCH] qapi/block-core: Fix BlockdevOptionsNvmeIoUring @path description Alberto Faria
2022-11-09 8:21 ` Stefano Garzarella
@ 2022-11-10 13:47 ` Kevin Wolf
1 sibling, 0 replies; 3+ messages in thread
From: Kevin Wolf @ 2022-11-10 13:47 UTC (permalink / raw)
To: Alberto Faria
Cc: qemu-devel, Stefan Hajnoczi, Eric Blake, Hanna Reitz,
Markus Armbruster, qemu-block, Stefano Garzarella
Am 08.11.2022 um 15:23 hat Alberto Faria geschrieben:
> The nvme-io_uring BlockDriver's path option must point at the character
> device of an NVMe namespace, not at an image file.
>
> Fixes: fd66dbd424f5 ("blkio: add libblkio block driver")
> Suggested-by: Stefano Garzarella <sgarzare@redhat.com>
> Signed-off-by: Alberto Faria <afaria@redhat.com>
Thanks, applied to the block branch.
Kevin
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-11-10 13:47 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-11-08 14:23 [PATCH] qapi/block-core: Fix BlockdevOptionsNvmeIoUring @path description Alberto Faria
2022-11-09 8:21 ` Stefano Garzarella
2022-11-10 13:47 ` Kevin Wolf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).