From: Thomas Huth <thuth@redhat.com>
To: qemu-devel@nongnu.org, Jason Wang <jasowang@redhat.com>
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
pbonzini@redhat.com,
"Marcel Apfelbaum" <marcel.apfelbaum@gmail.com>,
"Claudio Fontana" <cfontana@suse.de>,
"Alex Bennée" <alex.bennee@linaro.org>
Subject: [PATCH v2 0/3] Fix the "-nic help" option
Date: Thu, 10 Nov 2022 13:52:21 +0100 [thread overview]
Message-ID: <20221110125224.99596-1-thuth@redhat.com> (raw)
Running QEMU with "-nic help" used to work in QEMU 5.2 and earlier
versions, but since QEMU 6.0 it just complains that "help" is not
a valid value here. This patch series fixes this problem and also
extends the help output here to list the available NIC models, too.
v2:
- Add function comment in the first patch
- Add Reviewed-by in the third patch
Thomas Huth (3):
net: Move the code to collect available NIC models to a separate
function
net: Restore printing of the help text with "-nic help"
net: Replace "Supported NIC models" with "Available NIC models"
include/net/net.h | 14 +++++++++++++
hw/pci/pci.c | 29 +--------------------------
net/net.c | 50 ++++++++++++++++++++++++++++++++++++++++++++---
3 files changed, 62 insertions(+), 31 deletions(-)
--
2.31.1
next reply other threads:[~2022-11-10 12:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-10 12:52 Thomas Huth [this message]
2022-11-10 12:52 ` [PATCH v2 1/3] net: Move the code to collect available NIC models to a separate function Thomas Huth
2022-11-10 12:52 ` [PATCH v2 2/3] net: Restore printing of the help text with "-nic help" Thomas Huth
2022-11-10 12:52 ` [PATCH v2 3/3] net: Replace "Supported NIC models" with "Available NIC models" Thomas Huth
2022-12-15 15:23 ` [PATCH v2 0/3] Fix the "-nic help" option Thomas Huth
2022-12-16 7:38 ` Jason Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221110125224.99596-1-thuth@redhat.com \
--to=thuth@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=cfontana@suse.de \
--cc=jasowang@redhat.com \
--cc=marcel.apfelbaum@gmail.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).