From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 274D9C4332F for ; Thu, 10 Nov 2022 18:54:01 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1otCg2-0001XS-MG; Thu, 10 Nov 2022 13:53:26 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1otCg0-0001Ws-Lf for qemu-devel@nongnu.org; Thu, 10 Nov 2022 13:53:24 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1otCfy-0005n0-Kj for qemu-devel@nongnu.org; Thu, 10 Nov 2022 13:53:24 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1668106402; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NB1EY0bhJeMMFEOjWjNXhLdRpCbmM2+fi2awf3ykoPA=; b=fZFakKnS/5eFkAZVGtGEdMKRO7LIki8LuGmoIM58AaxYSCQcBeHkRlc27BBf8T5Lcxq4ZX eQPiTZ/eCNr9+3al9uQD/lPvznV/BDVtUldinVnL3rsG7qsy7NCHoEHbg17+lTOsyK+ovV L8xbBRoaiIG1UvnQ9LdEvXOT8wZ4DcQ= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-606-7vct8DeENrimNuuoE-MbDw-1; Thu, 10 Nov 2022 13:53:20 -0500 X-MC-Unique: 7vct8DeENrimNuuoE-MbDw-1 Received: by mail-wm1-f69.google.com with SMTP id bi19-20020a05600c3d9300b003cf9d6c4016so3085280wmb.8 for ; Thu, 10 Nov 2022 10:53:20 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=NB1EY0bhJeMMFEOjWjNXhLdRpCbmM2+fi2awf3ykoPA=; b=6helnA7Ya9/fPWyZ7lauNg7X/UuSUrWK97trX3Q/s4Wt0ohtEFHIfC1TmD6uXLqG17 TKTIUItvUqB/tvPJO4RfrjrR62/IDF871q4vSCwI1m8SdAJW+eG+dKvzPmOaQFgxFmqZ 4qbfECNBhesaWwCT/hegv2ehxGxZ/bbymD6pCA2Dewjo1I5NbwR0bUQxxf9R71Tu+pYp dEPX4FlbX42nL5BISnM0aQOp6oUwuVk5yTUtMnYy/BrwtVo/aofusjhrb94jVRfQWspz pm6NIhMv/4k+hEIlG6nC5UTdJo+13/28Kc+AaOJvyDijsRvKSwu0xspcMiv54WEC37ts Djww== X-Gm-Message-State: ACrzQf1sgUmCDQXF4MDB2VhTrZ735aFm3lcZ/qW9X+074DMxY3kCszMN ZMq7CmPHlQxARQftyH+dXyleChM0siorTywi1ejwtTQD3xC9VxVaeMNBL8pZRK3lfSs3KpPYIbM GRVPywvKxPltYCRE= X-Received: by 2002:a05:600c:4313:b0:3cf:894d:1d05 with SMTP id p19-20020a05600c431300b003cf894d1d05mr29416307wme.32.1668106399592; Thu, 10 Nov 2022 10:53:19 -0800 (PST) X-Google-Smtp-Source: AMsMyM6Q/0R16Voo6qJPy3k9PKhGIwQgys8BoMF4w/qtHm1JC3lE3JtD3McX/oXLvHT0H020AmXs4A== X-Received: by 2002:a05:600c:4313:b0:3cf:894d:1d05 with SMTP id p19-20020a05600c431300b003cf894d1d05mr29416290wme.32.1668106399306; Thu, 10 Nov 2022 10:53:19 -0800 (PST) Received: from redhat.com ([2.52.3.250]) by smtp.gmail.com with ESMTPSA id o39-20020a05600c33a700b003b47e75b401sm5522254wmp.37.2022.11.10.10.53.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Nov 2022 10:53:18 -0800 (PST) Date: Thu, 10 Nov 2022 13:53:15 -0500 From: "Michael S. Tsirkin" To: huangy81@chinatelecom.cn Cc: qemu-devel , Jason Wang , Stefano Garzarella , Raphael Norwitz Subject: Re: [PATCH v3 0/2] Fix the virtio features negotiation flaw Message-ID: <20221110135231-mutt-send-email-mst@kernel.org> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Received-SPF: pass client-ip=170.10.133.124; envelope-from=mst@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Sun, Oct 30, 2022 at 09:52:37PM +0800, huangy81@chinatelecom.cn wrote: > From: Hyman Huang(黄勇) > > v3: > -rebase on master > -code clean on [PATCH v2 1/2]: keep the commit self-consistent and > do not modify the logic of saving acked_features. Just abstract the > util function. > -modify the [PATCH v2 2/2] logic: change the behavior of saving > acked_features in chr_closed_bh: saving acked_features only if > features aren't 0. For the case of 0, we implement it in > virtio_net_set_features function, which will save the acked_features > in advance, including assign 0 to acked_features. > > Thanks Michael for the comments and suggestions about the self-consistent > of commits. :) This breaks multiple build configs: https://gitlab.com/mstredhat/qemu/-/pipelines/691382555/failures > Please review, > > Yong > > v2: > Fix the typo in subject of [PATCH v2 2/2] > > v1: > This is the version 1 of the series and it is exactly the same as > RFC version, but fixing a typo in subject, which is reported by Michael. > > As for test for the behavior suggested by Michael, IMHO, it could be > post in another series, since i found that testing the negotiation > behavior using QGraph Test Framework requires more work than i thought. > > The test patch may implement the following logic... > 1. Introduce a fresh new qmp command to query netdev info, which show > the NetClient status including guest features and acked_features. > 2. Using vhost-user QGraph Test to check the behavior of the vhost user > protocol cmd VHOST_USER_SET_FEATURES. > 3. Adding acked_features into TestServer, which receive the features > set by QEMU. > 4. Compare the acked_feature in TestServer with the acked_features > in the output of qmp query command. > > Anyway, idea above can be discussed in the future and any suggestion > are welcom. Let's fix the existing bug first, :) > > Please review, > > Yong > > Patch for RFC can be found in the following: > https://patchew.org/QEMU/20220926063641.25038-1-huangy81@chinatelecom.cn/ > > This patchset aim to fix the unexpected negotiation features for > vhost-user netdev interface. > > Steps to reproduce the issue: > Prepare a vm (CentOS 8 in my work scenario) with vhost-user > backend interface and configure qemu as server mode. So dpdk > would connect qemu's unix socket periodically. > > 1. start vm in background and restart openvswitch service > concurrently and repeatedly in the process of vm start. > > 2. check if negotiated virtio features of port is "0x40000000" at > dpdk side by executing: > ovs-vsctl list interface | grep features | grep {port_socket_path} > > 3. if features equals "0x40000000", go to the vm and check if sending > arp package works, executing: > arping {IP_ADDR} > if vm interface is configured to boot with dhcp protocol, it > would get no ip. > > After doing above steps, we'll find the arping not work, the ovs on > host side has forwarded unexpected arp packages, which be added 0x0000 > in the head of ethenet frame. Though qemu report some error when > read/write cmd of vhost protocol during the process of vm start, > like the following: > > "Failed to set msg fds" > "vhost VQ 0 ring restore failed: -22: Invalid argument (22)" > > The vm does not stop or report more suggestive error message, it > seems that everthing is ok. > > The root cause is that dpdk port negotiated nothing but only one > VHOST_USER_F_PROTOCOL_FEATURES feature with vhost-user interface at > qemu side, which is an unexpected behavior. qemu only load the > VHOST_USER_F_PROTOCOL_FEATURES when VHOST_USER_SET_FEATURES and loss > the guest features configured by front-end virtio driver using the > VIRTIO_PCI_COMMON_GF addr, which is stored in acked_features field > of struct vhost_dev. > > To explain how the acked_features disappear, we may need to know the > lifecyle of acked_features in vhost_dev during feature negotiation. > > 1. qemu init acked_features field of struct vhost_dev in vhost_net_init() > by calling vhost_net_ack_features(), the init value fetched from > acked_features field of struct NetVhostUserState, which is the backup > role after vhost stopping or unix socket closed. > In the first time, the acked_features of struct NetVhostUserState is 0 > so the init value of vhost_dev's acked_features also 0. > > 2. when guest virtio driver set features, qemu accept the features and > call virtio_set_features to store the features as acked_features in > vhost_dev. > > 3. when unix socket closed or vhost_dev device doesn't work and be > stopped unexpectedly, qemu will call chr_closed_bh or vhost_user_stop, > which will copy acked_features from vhost_dev to NetVhostUserState and > cleanup the vhost_dev. Since virtio driver not allowed to set features > once status of virtio device changes to VIRTIO_CONFIG_S_FEATURE_OK, > qemu need to backup it in case of loss. > > 4. once unix socket return to normal and get connected, qemu will > call vhost_user_start to restore the vhost_dev and fetch the > acked_features stored in NetVhostUserState previously. > > The above flow works fine in the normal scenarios, but it doesn't cover > the scenario that openvswitch service restart in the same time of > virtio features negotiation. > > Let's analyze such scenario: > qemu dpdk > > vhost_net_init() > | systemctl stop openvswitch.service > virtio_set_features() | > | systemctl start openvswitch.service > virtio_set_status() > > Ovs stop service before guset setting virtio features, chr_closed_bh() > be called and fetch acked_features in vhost_dev, if may store the > incomplete features to NetVhostUserState since it doesn't include > guest features, eg "0x40000000". > > Guest set virtio features with another features, eg "0x7060a782", > this value will store in acked_features of vhost_dev, which is the > right and up-to-date features. > > After ovs service show up, qemu unix socket get connected and call > vhost_user_start(), which will restore acked_features of vhost_dev > using NetVhostUserState and "0x40000000" be loaded, which is obsolete. > > Guest set virtio device status and therefore qemu call > virtio_net_vhost_status finally, checking if vhost-net device has > started, start it if not, consequently the obsolete acked_features > "0x40000000" be negotiated after calling vhost_dev_set_features(). > > So the key point of solving this issue making the acked_features > in NetVhostUserState up-to-date, these patchset provide this > solution. > > [PATCH 1/2]: Abstract the existing code of saving acked_features > into vhost_user_save_acked_features so the next > patch seems clean. > > [PATCH 2/2]: Save the acked_features to NetVhostUserState once > Guest virtio driver configured. This step makes > acked_features in NetVhostUserState up-to-date. > > Please review, any comments and suggestions are welcome. > > Best regard. > > Yong > > Hyman Huang (2): > vhost-user: Refactor vhost acked features saving > vhost-net: Fix the virtio features negotiation flaw > > hw/net/vhost_net.c | 9 +++++++++ > hw/net/virtio-net.c | 5 +++++ > include/net/vhost-user.h | 2 ++ > include/net/vhost_net.h | 2 ++ > net/vhost-user.c | 35 +++++++++++++++++++---------------- > 5 files changed, 37 insertions(+), 16 deletions(-) > > -- > 1.8.3.1