From: Thomas Huth <thuth@redhat.com>
To: Stefan Hajnoczi <stefanha@redhat.com>, qemu-devel@nongnu.org
Subject: [PULL 4/4] acpi/tests/avocado/bits: some misc fixes
Date: Thu, 17 Nov 2022 10:10:06 +0100 [thread overview]
Message-ID: <20221117091006.525072-5-thuth@redhat.com> (raw)
In-Reply-To: <20221117091006.525072-1-thuth@redhat.com>
From: Ani Sinha <ani@anisinha.ca>
Most of the changes are trivial. The bits test timeout has now been increased
to 200 seconds in order to accommodate slower systems and fewer unnecessary
failures. Removed of the reference to non-existent README file in docs. Some
minor corrections in the doc file.
Signed-off-by: Ani Sinha <ani@anisinha.ca>
Message-Id: <20221117053644.516649-1-ani@anisinha.ca>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
docs/devel/acpi-bits.rst | 12 ++++--------
tests/avocado/acpi-bits.py | 3 +++
2 files changed, 7 insertions(+), 8 deletions(-)
diff --git a/docs/devel/acpi-bits.rst b/docs/devel/acpi-bits.rst
index 5e22be8ef6..4a94c7d83d 100644
--- a/docs/devel/acpi-bits.rst
+++ b/docs/devel/acpi-bits.rst
@@ -16,11 +16,8 @@ end user. The other is that we have more control of what we wanted to test
and how by directly using acpica interpreter on top of the bios on a running
system. More details on the inspiration for developing biosbits and its real
life uses can be found in [#a]_ and [#b]_.
-This directory contains tests written in python using avocado framework that
-exercises the QEMU bios components using biosbits and reports test failures.
For QEMU, we maintain a fork of bios bits in gitlab along with all the
-dependent submodules:
-https://gitlab.com/qemu-project/biosbits-bits
+dependent submodules here: https://gitlab.com/qemu-project/biosbits-bits
This fork contains numerous fixes, a newer acpica and changes specific to
running this avocado QEMU tests using bits. The author of this document
is the sole maintainer of the QEMU fork of bios bits repo.
@@ -38,10 +35,9 @@ Under ``tests/avocado/`` as the root we have:
│ ├── bits-config
│ │ └── bits-cfg.txt
│ ├── bits-tests
- │ │ ├── smbios.py2
- │ │ ├── testacpi.py2
- │ │ └── testcpuid.py2
- │ └── README
+ │ ├── smbios.py2
+ │ ├── testacpi.py2
+ │ └── testcpuid.py2
├── acpi-bits.py
* ``tests/avocado``:
diff --git a/tests/avocado/acpi-bits.py b/tests/avocado/acpi-bits.py
index 8745a58a76..9ac87f01f1 100644
--- a/tests/avocado/acpi-bits.py
+++ b/tests/avocado/acpi-bits.py
@@ -134,6 +134,9 @@ class AcpiBitsTest(QemuBaseTest): #pylint: disable=too-many-instance-attributes
:avocado: tags=acpi
"""
+ # in slower systems the test can take as long as 3 minutes to complete.
+ timeout = 200
+
def __init__(self, *args, **kwargs):
super().__init__(*args, **kwargs)
self._vm = None
--
2.31.1
next prev parent reply other threads:[~2022-11-17 9:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-17 9:10 [PULL 0/4] Some small s390x and testing fixes Thomas Huth
2022-11-17 9:10 ` [PULL 1/4] s390x: Fix spelling errors Thomas Huth
2022-11-17 9:10 ` [PULL 2/4] docs/system/s390x: Document the "loadparm" machine property Thomas Huth
2022-11-17 9:10 ` [PULL 3/4] ci: replace x86_64 macos-11 with aarch64 macos-12 Thomas Huth
2022-11-17 9:10 ` Thomas Huth [this message]
2022-11-17 20:07 ` [PULL 0/4] Some small s390x and testing fixes Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221117091006.525072-5-thuth@redhat.com \
--to=thuth@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).