From: Gerd Hoffmann <kraxel@redhat.com>
To: seabios@seabios.org
Cc: qemu-devel@nongnu.org, Gerd Hoffmann <kraxel@redhat.com>
Subject: [PATCH 4/4] be less conservative with the 64bit pci io window
Date: Mon, 21 Nov 2022 11:32:13 +0100 [thread overview]
Message-ID: <20221121103213.1675568-5-kraxel@redhat.com> (raw)
In-Reply-To: <20221121103213.1675568-1-kraxel@redhat.com>
Current seabios code will only enable and use the 64bit pci io window in
case it runs out of space in the 32bit pci mmio window below 4G.
This patch will also enable the 64bit pci io window when
(a) RAM above 4G is present, and
(b) the physical address space size is known, and
(c) seabios is running on a 64bit capable processor.
This operates with the assumption that guests which are ok with memory
above 4G most likely can handle mmio above 4G too.
In case the 64bit pci io window is enabled also assign more memory to
prefetchable pci bridge windows (scale with address space).
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
src/fw/pciinit.c | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/src/fw/pciinit.c b/src/fw/pciinit.c
index ad6def93633b..3e9636b139a4 100644
--- a/src/fw/pciinit.c
+++ b/src/fw/pciinit.c
@@ -51,6 +51,7 @@ u64 pcimem_end = BUILD_PCIMEM_END;
u64 pcimem64_start = BUILD_PCIMEM64_START;
u64 pcimem64_end = BUILD_PCIMEM64_END;
u64 pci_io_low_end = 0xa000;
+u32 pci_use_64bit = 0;
struct pci_region_entry {
struct pci_device *dev;
@@ -920,6 +921,8 @@ static int pci_bios_check_devices(struct pci_bus *busses)
for (type = 0; type < PCI_REGION_TYPE_COUNT; type++) {
u64 align = (type == PCI_REGION_TYPE_IO) ?
PCI_BRIDGE_IO_MIN : PCI_BRIDGE_MEM_MIN;
+ if (pci_use_64bit && (type == PCI_REGION_TYPE_PREFMEM))
+ align = (u64)1 << (PhysBits - 11);
if (!pci_bridge_has_region(s->bus_dev, type))
continue;
u64 size = 0;
@@ -1108,7 +1111,7 @@ static void pci_bios_map_devices(struct pci_bus *busses)
panic("PCI: out of I/O address space\n");
dprintf(1, "PCI: 32: %016llx - %016llx\n", pcimem_start, pcimem_end);
- if (pci_bios_init_root_regions_mem(busses)) {
+ if (pci_use_64bit || pci_bios_init_root_regions_mem(busses)) {
struct pci_region r64_mem, r64_pref;
r64_mem.list.first = NULL;
r64_pref.list.first = NULL;
@@ -1174,6 +1177,9 @@ pci_setup(void)
dprintf(3, "pci setup\n");
+ if (PhysBits >= 36 && LongMode && RamSizeOver4G)
+ pci_use_64bit = 1;
+
dprintf(1, "=== PCI bus & bridge init ===\n");
if (pci_probe_host() != 0) {
return;
--
2.38.1
next prev parent reply other threads:[~2022-11-21 10:33 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-21 10:32 [PATCH 0/4] misc tweaks for kvm and the 64bit pci window Gerd Hoffmann
2022-11-21 10:32 ` [PATCH 1/4] better kvm detection Gerd Hoffmann
2023-01-20 12:21 ` [SeaBIOS] " David Woodhouse
2022-11-21 10:32 ` [PATCH 2/4] detect physical address space size Gerd Hoffmann
2022-11-21 10:32 ` [PATCH 3/4] move 64bit pci window to end of address space Gerd Hoffmann
2022-11-21 10:57 ` [SeaBIOS] " Paul Menzel
2022-11-23 10:39 ` Gerd Hoffmann
2022-11-21 10:32 ` Gerd Hoffmann [this message]
2022-11-22 18:43 ` [PATCH 4/4] be less conservative with the 64bit pci io window Kevin O'Connor
2022-11-23 10:25 ` Gerd Hoffmann
2022-12-08 16:01 ` [SeaBIOS] " Igor Mammedov
2022-12-09 11:51 ` Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221121103213.1675568-5-kraxel@redhat.com \
--to=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=seabios@seabios.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).