qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Alex Bennée" <alex.bennee@linaro.org>
To: qemu-devel@nongnu.org
Cc: stefanha@redhat.com, "Stefan Weil" <sw@weilnetz.de>,
	"Alex Bennée" <alex.bennee@linaro.org>,
	"Thomas Huth" <thuth@redhat.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>
Subject: [PULL v2 01/11] Run docker probe only if docker or podman are available
Date: Tue, 22 Nov 2022 09:56:00 +0000	[thread overview]
Message-ID: <20221122095610.3343175-2-alex.bennee@linaro.org> (raw)
In-Reply-To: <20221122095610.3343175-1-alex.bennee@linaro.org>

From: Stefan Weil <sw@weilnetz.de>

The docker probe uses "sudo -n" which can cause an e-mail with a security warning
each time when configure is run. Therefore run docker probe only if either docker
or podman are available.

That avoids the problematic "sudo -n" on build environments which have neither
docker nor podman installed.

Fixes: c4575b59155e2e00 ("configure: store container engine in config-host.mak")
Signed-off-by: Stefan Weil <sw@weilnetz.de>
Message-Id: <20221030083510.310584-1-sw@weilnetz.de>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Message-Id: <20221117172532.538149-2-alex.bennee@linaro.org>

diff --git a/configure b/configure
index 66928692b0..26c7bc5154 100755
--- a/configure
+++ b/configure
@@ -1780,7 +1780,7 @@ fi
 # functions to probe cross compilers
 
 container="no"
-if test $use_containers = "yes"; then
+if test $use_containers = "yes" && (has "docker" || has "podman"); then
     case $($python "$source_path"/tests/docker/docker.py probe) in
         *docker) container=docker ;;
         podman) container=podman ;;
-- 
2.34.1



  reply	other threads:[~2022-11-22  9:57 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-22  9:55 [PULL v2 for 7.2-rc2 00/11] testing and doc updates Alex Bennée
2022-11-22  9:56 ` Alex Bennée [this message]
2022-11-22  9:56 ` [PULL v2 02/11] tests/avocado/machine_aspeed.py: Reduce noise on the console for SDK tests Alex Bennée
2022-11-22  9:56 ` [PULL v2 03/11] tests/docker: allow user to override check target Alex Bennée
2022-11-22  9:56 ` [PULL v2 04/11] docs/devel: add a maintainers section to development process Alex Bennée
2022-11-22  9:56 ` [PULL v2 05/11] docs/devel: make language a little less code centric Alex Bennée
2022-11-22  9:56 ` [PULL v2 06/11] docs/devel: simplify the minimal checklist Alex Bennée
2022-11-22  9:56 ` [PULL v2 07/11] docs/devel: try and improve the language around patch review Alex Bennée
2022-11-22  9:56 ` [PULL v2 08/11] tests/avocado: Raise timeout for boot_linux.py:BootLinuxPPC64.test_pseries_tcg Alex Bennée
2022-11-22  9:56 ` [PULL v2 09/11] tests/avocado: introduce alpine virt test for CI Alex Bennée
2022-11-22  9:56 ` [PULL v2 10/11] tests/avocado: skip aarch64 cloud TCG tests in CI Alex Bennée
2022-11-22  9:56 ` [PULL v2 11/11] gitlab: integrate coverage report Alex Bennée
2022-11-22 17:09 ` [PULL v2 for 7.2-rc2 00/11] testing and doc updates Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221122095610.3343175-2-alex.bennee@linaro.org \
    --to=alex.bennee@linaro.org \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    --cc=sw@weilnetz.de \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).