From: "Alex Bennée" <alex.bennee@linaro.org>
To: qemu-devel@nongnu.org
Cc: slp@redhat.com, mst@redhat.com, marcandre.lureau@redhat.com,
stefanha@redhat.com, mathieu.poirier@linaro.org,
viresh.kumar@linaro.org, "Alex Bennée" <alex.bennee@linaro.org>
Subject: [PATCH for 7.2-rc3 v1 0/2] virtio fixes
Date: Wed, 23 Nov 2022 15:21:32 +0000 [thread overview]
Message-ID: <20221123152134.179929-1-alex.bennee@linaro.org> (raw)
Hi,
This hopefully fixes the problems with VirtIO migration caused by the
previous refactoring of virtio_device_started(). That introduced a
different order of checking which didn't give the VM state primacy but
wasn't noticed as we don't properly exercise VirtIO device migration
and caused issues when dev->started wasn't checked in the core code.
The introduction of virtio_device_should_start() split the overloaded
function up but the broken order still remained. The series finally
fixes that by restoring the original semantics but with the cleaned up
functions.
I've added more documentation to the various structures involved as
well as the functions. There is still some inconsistencies in the
VirtIO code between different devices but I think that can be looked
at over the 8.0 cycle.
Alex Bennée (2):
include/hw: attempt to document VirtIO feature variables
include/hw: VM state takes precedence in virtio_device_should_start
include/hw/virtio/vhost.h | 25 +++++++++++++++++++---
include/hw/virtio/virtio.h | 43 ++++++++++++++++++++++++++++++++------
2 files changed, 59 insertions(+), 9 deletions(-)
--
2.34.1
next reply other threads:[~2022-11-23 15:22 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-23 15:21 Alex Bennée [this message]
2022-11-23 15:21 ` [PATCH v1 1/2] include/hw: attempt to document VirtIO feature variables Alex Bennée
2022-11-23 15:21 ` [PATCH v1 2/2] include/hw: VM state takes precedence in virtio_device_should_start Alex Bennée
2022-11-23 15:26 ` [PATCH for 7.2-rc3 v1 0/2] virtio fixes Michael S. Tsirkin
2022-11-23 16:03 ` Alex Bennée
2022-11-23 16:08 ` Michael S. Tsirkin
2022-11-24 9:21 ` Alex Bennée
2022-11-24 10:53 ` Michael S. Tsirkin
2022-11-24 13:11 ` Alex Bennée
2022-11-24 22:24 ` Alex Bennée
2022-11-25 12:05 ` Michael S. Tsirkin
2022-11-25 14:51 ` Alex Bennée
2022-11-25 15:14 ` Alex Bennée
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221123152134.179929-1-alex.bennee@linaro.org \
--to=alex.bennee@linaro.org \
--cc=marcandre.lureau@redhat.com \
--cc=mathieu.poirier@linaro.org \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=slp@redhat.com \
--cc=stefanha@redhat.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).