* [PATCH 0/1] Fix some typos @ 2022-11-30 1:53 Dongdong Zhang 2022-11-30 1:53 ` [PATCH 1/1] " Dongdong Zhang 2022-12-16 3:22 ` [PING PATCH 0/1] " Dongdong Zhang 0 siblings, 2 replies; 10+ messages in thread From: Dongdong Zhang @ 2022-11-30 1:53 UTC (permalink / raw) To: qemu-devel; +Cc: jsnow, crosa, bleal, Dongdong Zhang This patch mainly fixes some typos in the 'python' directory. Dongdong Zhang (1): Fix some typos python/qemu/machine/console_socket.py | 2 +- python/qemu/machine/qtest.py | 2 +- python/qemu/qmp/protocol.py | 2 +- python/qemu/qmp/qmp_tui.py | 6 +++--- 4 files changed, 6 insertions(+), 6 deletions(-) -- 2.17.1 ^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH 1/1] Fix some typos 2022-11-30 1:53 [PATCH 0/1] Fix some typos Dongdong Zhang @ 2022-11-30 1:53 ` Dongdong Zhang 2022-11-30 8:29 ` Philippe Mathieu-Daudé 2023-01-05 23:57 ` Max Filippov 2022-12-16 3:22 ` [PING PATCH 0/1] " Dongdong Zhang 1 sibling, 2 replies; 10+ messages in thread From: Dongdong Zhang @ 2022-11-30 1:53 UTC (permalink / raw) To: qemu-devel; +Cc: jsnow, crosa, bleal, Dongdong Zhang Fix some typos in 'python' directory. Signed-off-by: Dongdong Zhang <zhangdongdong@eswincomputing.com> --- python/qemu/machine/console_socket.py | 2 +- python/qemu/machine/qtest.py | 2 +- python/qemu/qmp/protocol.py | 2 +- python/qemu/qmp/qmp_tui.py | 6 +++--- 4 files changed, 6 insertions(+), 6 deletions(-) diff --git a/python/qemu/machine/console_socket.py b/python/qemu/machine/console_socket.py index 8c4ff598ad..4e28ba9bb2 100644 --- a/python/qemu/machine/console_socket.py +++ b/python/qemu/machine/console_socket.py @@ -68,7 +68,7 @@ def _thread_start(self) -> threading.Thread: """Kick off a thread to drain the socket.""" # Configure socket to not block and timeout. # This allows our drain thread to not block - # on recieve and exit smoothly. + # on receive and exit smoothly. socket.socket.setblocking(self, False) socket.socket.settimeout(self, 1) drain_thread = threading.Thread(target=self._drain_fn) diff --git a/python/qemu/machine/qtest.py b/python/qemu/machine/qtest.py index 1a1fc6c9b0..906bd13298 100644 --- a/python/qemu/machine/qtest.py +++ b/python/qemu/machine/qtest.py @@ -42,7 +42,7 @@ class QEMUQtestProtocol: :raise socket.error: on socket connection errors .. note:: - No conection is estabalished by __init__(), this is done + No connection is estabalished by __init__(), this is done by the connect() or accept() methods. """ def __init__(self, address: SocketAddrT, diff --git a/python/qemu/qmp/protocol.py b/python/qemu/qmp/protocol.py index 6ea86650ad..15909b7dba 100644 --- a/python/qemu/qmp/protocol.py +++ b/python/qemu/qmp/protocol.py @@ -812,7 +812,7 @@ def _done(task: Optional['asyncio.Future[Any]']) -> bool: @bottom_half async def _bh_close_stream(self, error_pathway: bool = False) -> None: - # NB: Closing the writer also implcitly closes the reader. + # NB: Closing the writer also implicitly closes the reader. if not self._writer: return diff --git a/python/qemu/qmp/qmp_tui.py b/python/qemu/qmp/qmp_tui.py index ce239d8979..8369144723 100644 --- a/python/qemu/qmp/qmp_tui.py +++ b/python/qemu/qmp/qmp_tui.py @@ -71,7 +71,7 @@ def format_json(msg: str) -> str: due to an decoding error then a simple string manipulation is done to achieve a single line JSON string. - Converting into single line is more asthetically pleasing when looking + Converting into single line is more aesthetically pleasing when looking along with error messages. Eg: @@ -91,7 +91,7 @@ def format_json(msg: str) -> str: [1, true, 3]: QMP message is not a JSON object. - The single line mode is more asthetically pleasing. + The single line mode is more aesthetically pleasing. :param msg: The message to formatted into single line. @@ -498,7 +498,7 @@ def __init__(self, parent: App) -> None: class HistoryBox(urwid.ListBox): """ This widget is modelled using the ListBox widget, contains the list of - all messages both QMP messages and log messsages to be shown in the TUI. + all messages both QMP messages and log messages to be shown in the TUI. The messages are urwid.Text widgets. On every append of a message, the focus is shifted to the last appended message. -- 2.17.1 ^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH 1/1] Fix some typos 2022-11-30 1:53 ` [PATCH 1/1] " Dongdong Zhang @ 2022-11-30 8:29 ` Philippe Mathieu-Daudé 2023-01-16 18:10 ` Laurent Vivier 2023-01-05 23:57 ` Max Filippov 1 sibling, 1 reply; 10+ messages in thread From: Philippe Mathieu-Daudé @ 2022-11-30 8:29 UTC (permalink / raw) To: Dongdong Zhang, qemu-devel; +Cc: jsnow, crosa, bleal, QEMU Trivial On 30/11/22 02:53, Dongdong Zhang wrote: > Fix some typos in 'python' directory. > > Signed-off-by: Dongdong Zhang <zhangdongdong@eswincomputing.com> Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org> > --- > python/qemu/machine/console_socket.py | 2 +- > python/qemu/machine/qtest.py | 2 +- > python/qemu/qmp/protocol.py | 2 +- > python/qemu/qmp/qmp_tui.py | 6 +++--- > 4 files changed, 6 insertions(+), 6 deletions(-) > > diff --git a/python/qemu/machine/console_socket.py b/python/qemu/machine/console_socket.py > index 8c4ff598ad..4e28ba9bb2 100644 > --- a/python/qemu/machine/console_socket.py > +++ b/python/qemu/machine/console_socket.py > @@ -68,7 +68,7 @@ def _thread_start(self) -> threading.Thread: > """Kick off a thread to drain the socket.""" > # Configure socket to not block and timeout. > # This allows our drain thread to not block > - # on recieve and exit smoothly. > + # on receive and exit smoothly. > socket.socket.setblocking(self, False) > socket.socket.settimeout(self, 1) > drain_thread = threading.Thread(target=self._drain_fn) > diff --git a/python/qemu/machine/qtest.py b/python/qemu/machine/qtest.py > index 1a1fc6c9b0..906bd13298 100644 > --- a/python/qemu/machine/qtest.py > +++ b/python/qemu/machine/qtest.py > @@ -42,7 +42,7 @@ class QEMUQtestProtocol: > :raise socket.error: on socket connection errors > > .. note:: > - No conection is estabalished by __init__(), this is done > + No connection is estabalished by __init__(), this is done > by the connect() or accept() methods. > """ > def __init__(self, address: SocketAddrT, > diff --git a/python/qemu/qmp/protocol.py b/python/qemu/qmp/protocol.py > index 6ea86650ad..15909b7dba 100644 > --- a/python/qemu/qmp/protocol.py > +++ b/python/qemu/qmp/protocol.py > @@ -812,7 +812,7 @@ def _done(task: Optional['asyncio.Future[Any]']) -> bool: > > @bottom_half > async def _bh_close_stream(self, error_pathway: bool = False) -> None: > - # NB: Closing the writer also implcitly closes the reader. > + # NB: Closing the writer also implicitly closes the reader. > if not self._writer: > return > > diff --git a/python/qemu/qmp/qmp_tui.py b/python/qemu/qmp/qmp_tui.py > index ce239d8979..8369144723 100644 > --- a/python/qemu/qmp/qmp_tui.py > +++ b/python/qemu/qmp/qmp_tui.py > @@ -71,7 +71,7 @@ def format_json(msg: str) -> str: > due to an decoding error then a simple string manipulation is done to > achieve a single line JSON string. > > - Converting into single line is more asthetically pleasing when looking > + Converting into single line is more aesthetically pleasing when looking > along with error messages. > > Eg: > @@ -91,7 +91,7 @@ def format_json(msg: str) -> str: > > [1, true, 3]: QMP message is not a JSON object. > > - The single line mode is more asthetically pleasing. > + The single line mode is more aesthetically pleasing. > > :param msg: > The message to formatted into single line. > @@ -498,7 +498,7 @@ def __init__(self, parent: App) -> None: > class HistoryBox(urwid.ListBox): > """ > This widget is modelled using the ListBox widget, contains the list of > - all messages both QMP messages and log messsages to be shown in the TUI. > + all messages both QMP messages and log messages to be shown in the TUI. > > The messages are urwid.Text widgets. On every append of a message, the > focus is shifted to the last appended message. ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 1/1] Fix some typos 2022-11-30 8:29 ` Philippe Mathieu-Daudé @ 2023-01-16 18:10 ` Laurent Vivier 2023-01-16 20:06 ` John Snow 0 siblings, 1 reply; 10+ messages in thread From: Laurent Vivier @ 2023-01-16 18:10 UTC (permalink / raw) To: Philippe Mathieu-Daudé, Dongdong Zhang, qemu-devel Cc: jsnow, crosa, bleal, QEMU Trivial Le 30/11/2022 à 09:29, Philippe Mathieu-Daudé a écrit : > On 30/11/22 02:53, Dongdong Zhang wrote: >> Fix some typos in 'python' directory. >> >> Signed-off-by: Dongdong Zhang <zhangdongdong@eswincomputing.com> > > Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org> > >> --- >> python/qemu/machine/console_socket.py | 2 +- >> python/qemu/machine/qtest.py | 2 +- >> python/qemu/qmp/protocol.py | 2 +- >> python/qemu/qmp/qmp_tui.py | 6 +++--- >> 4 files changed, 6 insertions(+), 6 deletions(-) >> >> diff --git a/python/qemu/machine/console_socket.py b/python/qemu/machine/console_socket.py >> index 8c4ff598ad..4e28ba9bb2 100644 >> --- a/python/qemu/machine/console_socket.py >> +++ b/python/qemu/machine/console_socket.py >> @@ -68,7 +68,7 @@ def _thread_start(self) -> threading.Thread: >> """Kick off a thread to drain the socket.""" >> # Configure socket to not block and timeout. >> # This allows our drain thread to not block >> - # on recieve and exit smoothly. >> + # on receive and exit smoothly. >> socket.socket.setblocking(self, False) >> socket.socket.settimeout(self, 1) >> drain_thread = threading.Thread(target=self._drain_fn) >> diff --git a/python/qemu/machine/qtest.py b/python/qemu/machine/qtest.py >> index 1a1fc6c9b0..906bd13298 100644 >> --- a/python/qemu/machine/qtest.py >> +++ b/python/qemu/machine/qtest.py >> @@ -42,7 +42,7 @@ class QEMUQtestProtocol: >> :raise socket.error: on socket connection errors >> .. note:: >> - No conection is estabalished by __init__(), this is done >> + No connection is estabalished by __init__(), this is done >> by the connect() or accept() methods. >> """ >> def __init__(self, address: SocketAddrT, >> diff --git a/python/qemu/qmp/protocol.py b/python/qemu/qmp/protocol.py >> index 6ea86650ad..15909b7dba 100644 >> --- a/python/qemu/qmp/protocol.py >> +++ b/python/qemu/qmp/protocol.py >> @@ -812,7 +812,7 @@ def _done(task: Optional['asyncio.Future[Any]']) -> bool: >> @bottom_half >> async def _bh_close_stream(self, error_pathway: bool = False) -> None: >> - # NB: Closing the writer also implcitly closes the reader. >> + # NB: Closing the writer also implicitly closes the reader. >> if not self._writer: >> return >> diff --git a/python/qemu/qmp/qmp_tui.py b/python/qemu/qmp/qmp_tui.py >> index ce239d8979..8369144723 100644 >> --- a/python/qemu/qmp/qmp_tui.py >> +++ b/python/qemu/qmp/qmp_tui.py >> @@ -71,7 +71,7 @@ def format_json(msg: str) -> str: >> due to an decoding error then a simple string manipulation is done to >> achieve a single line JSON string. >> - Converting into single line is more asthetically pleasing when looking >> + Converting into single line is more aesthetically pleasing when looking >> along with error messages. >> Eg: >> @@ -91,7 +91,7 @@ def format_json(msg: str) -> str: >> [1, true, 3]: QMP message is not a JSON object. >> - The single line mode is more asthetically pleasing. >> + The single line mode is more aesthetically pleasing. >> :param msg: >> The message to formatted into single line. >> @@ -498,7 +498,7 @@ def __init__(self, parent: App) -> None: >> class HistoryBox(urwid.ListBox): >> """ >> This widget is modelled using the ListBox widget, contains the list of >> - all messages both QMP messages and log messsages to be shown in the TUI. >> + all messages both QMP messages and log messages to be shown in the TUI. >> The messages are urwid.Text widgets. On every append of a message, the >> focus is shifted to the last appended message. > > Applied to my trivial-patches branch. Thanks, Laurent ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 1/1] Fix some typos 2023-01-16 18:10 ` Laurent Vivier @ 2023-01-16 20:06 ` John Snow 0 siblings, 0 replies; 10+ messages in thread From: John Snow @ 2023-01-16 20:06 UTC (permalink / raw) To: Laurent Vivier Cc: Philippe Mathieu-Daudé, Dongdong Zhang, qemu-devel, crosa, bleal, QEMU Trivial On Mon, Jan 16, 2023 at 1:11 PM Laurent Vivier <laurent@vivier.eu> wrote: > > Le 30/11/2022 à 09:29, Philippe Mathieu-Daudé a écrit : > > On 30/11/22 02:53, Dongdong Zhang wrote: > >> Fix some typos in 'python' directory. > >> > >> Signed-off-by: Dongdong Zhang <zhangdongdong@eswincomputing.com> > > > > Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org> > > > >> --- > >> python/qemu/machine/console_socket.py | 2 +- > >> python/qemu/machine/qtest.py | 2 +- > >> python/qemu/qmp/protocol.py | 2 +- > >> python/qemu/qmp/qmp_tui.py | 6 +++--- > >> 4 files changed, 6 insertions(+), 6 deletions(-) > >> > >> diff --git a/python/qemu/machine/console_socket.py b/python/qemu/machine/console_socket.py > >> index 8c4ff598ad..4e28ba9bb2 100644 > >> --- a/python/qemu/machine/console_socket.py > >> +++ b/python/qemu/machine/console_socket.py > >> @@ -68,7 +68,7 @@ def _thread_start(self) -> threading.Thread: > >> """Kick off a thread to drain the socket.""" > >> # Configure socket to not block and timeout. > >> # This allows our drain thread to not block > >> - # on recieve and exit smoothly. > >> + # on receive and exit smoothly. > >> socket.socket.setblocking(self, False) > >> socket.socket.settimeout(self, 1) > >> drain_thread = threading.Thread(target=self._drain_fn) > >> diff --git a/python/qemu/machine/qtest.py b/python/qemu/machine/qtest.py > >> index 1a1fc6c9b0..906bd13298 100644 > >> --- a/python/qemu/machine/qtest.py > >> +++ b/python/qemu/machine/qtest.py > >> @@ -42,7 +42,7 @@ class QEMUQtestProtocol: > >> :raise socket.error: on socket connection errors > >> .. note:: > >> - No conection is estabalished by __init__(), this is done > >> + No connection is estabalished by __init__(), this is done > >> by the connect() or accept() methods. > >> """ > >> def __init__(self, address: SocketAddrT, > >> diff --git a/python/qemu/qmp/protocol.py b/python/qemu/qmp/protocol.py > >> index 6ea86650ad..15909b7dba 100644 > >> --- a/python/qemu/qmp/protocol.py > >> +++ b/python/qemu/qmp/protocol.py > >> @@ -812,7 +812,7 @@ def _done(task: Optional['asyncio.Future[Any]']) -> bool: > >> @bottom_half > >> async def _bh_close_stream(self, error_pathway: bool = False) -> None: > >> - # NB: Closing the writer also implcitly closes the reader. > >> + # NB: Closing the writer also implicitly closes the reader. > >> if not self._writer: > >> return > >> diff --git a/python/qemu/qmp/qmp_tui.py b/python/qemu/qmp/qmp_tui.py > >> index ce239d8979..8369144723 100644 > >> --- a/python/qemu/qmp/qmp_tui.py > >> +++ b/python/qemu/qmp/qmp_tui.py > >> @@ -71,7 +71,7 @@ def format_json(msg: str) -> str: > >> due to an decoding error then a simple string manipulation is done to > >> achieve a single line JSON string. > >> - Converting into single line is more asthetically pleasing when looking > >> + Converting into single line is more aesthetically pleasing when looking > >> along with error messages. > >> Eg: > >> @@ -91,7 +91,7 @@ def format_json(msg: str) -> str: > >> [1, true, 3]: QMP message is not a JSON object. > >> - The single line mode is more asthetically pleasing. > >> + The single line mode is more aesthetically pleasing. > >> :param msg: > >> The message to formatted into single line. > >> @@ -498,7 +498,7 @@ def __init__(self, parent: App) -> None: > >> class HistoryBox(urwid.ListBox): > >> """ > >> This widget is modelled using the ListBox widget, contains the list of > >> - all messages both QMP messages and log messsages to be shown in the TUI. > >> + all messages both QMP messages and log messages to be shown in the TUI. > >> The messages are urwid.Text widgets. On every append of a message, the > >> focus is shifted to the last appended message. > > > > > > Applied to my trivial-patches branch. > > Thanks, > Laurent Laurent, I'll grab this one, sorry! ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 1/1] Fix some typos 2022-11-30 1:53 ` [PATCH 1/1] " Dongdong Zhang 2022-11-30 8:29 ` Philippe Mathieu-Daudé @ 2023-01-05 23:57 ` Max Filippov 1 sibling, 0 replies; 10+ messages in thread From: Max Filippov @ 2023-01-05 23:57 UTC (permalink / raw) To: Dongdong Zhang; +Cc: qemu-devel, jsnow, crosa, bleal On Tue, Nov 29, 2022 at 6:08 PM Dongdong Zhang <zhangdongdong@eswincomputing.com> wrote: > diff --git a/python/qemu/machine/qtest.py b/python/qemu/machine/qtest.py > index 1a1fc6c9b0..906bd13298 100644 > --- a/python/qemu/machine/qtest.py > +++ b/python/qemu/machine/qtest.py > @@ -42,7 +42,7 @@ class QEMUQtestProtocol: > :raise socket.error: on socket connection errors > > .. note:: > - No conection is estabalished by __init__(), this is done > + No connection is estabalished by __init__(), this is done There are two typos in this line, the other one is 'estabalished'. -- Thanks. -- Max ^ permalink raw reply [flat|nested] 10+ messages in thread
* [PING PATCH 0/1] Fix some typos 2022-11-30 1:53 [PATCH 0/1] Fix some typos Dongdong Zhang 2022-11-30 1:53 ` [PATCH 1/1] " Dongdong Zhang @ 2022-12-16 3:22 ` Dongdong Zhang 2023-01-05 23:25 ` John Snow 1 sibling, 1 reply; 10+ messages in thread From: Dongdong Zhang @ 2022-12-16 3:22 UTC (permalink / raw) To: qemu-devel; +Cc: jsnow, crosa, bleal Hi all, I would like to ping a patch https://lists.nongnu.org/archive/html/qemu-devel/2022-11/msg04568.html https://lists.nongnu.org/archive/html/qemu-devel/2022-11/msg04570.html > -----Original Messages-----From:"Dongdong Zhang" <zhangdongdong@eswincomputing.com>Sent Time:2022-11-30 09:53:57 (Wednesday)To:qemu-devel@nongnu.orgCc:jsnow@redhat.com, crosa@redhat.com, bleal@redhat.com, "Dongdong Zhang" <zhangdongdong@eswincomputing.com>Subject:[PATCH 0/1] Fix some typos > > This patch mainly fixes some typos in the 'python' directory. > > Dongdong Zhang (1): > Fix some typos > > python/qemu/machine/console_socket.py | 2 +- > python/qemu/machine/qtest.py | 2 +- > python/qemu/qmp/protocol.py | 2 +- > python/qemu/qmp/qmp_tui.py | 6 +++--- > 4 files changed, 6 insertions(+), 6 deletions(-) > > -- > 2.17.1 ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PING PATCH 0/1] Fix some typos 2022-12-16 3:22 ` [PING PATCH 0/1] " Dongdong Zhang @ 2023-01-05 23:25 ` John Snow 2023-01-06 1:50 ` Dongdong Zhang 0 siblings, 1 reply; 10+ messages in thread From: John Snow @ 2023-01-05 23:25 UTC (permalink / raw) To: Dongdong Zhang; +Cc: qemu-devel, crosa, bleal On Thu, Dec 15, 2022 at 10:22 PM Dongdong Zhang <zhangdongdong@eswincomputing.com> wrote: > > Hi all, > > I would like to ping a patch > > https://lists.nongnu.org/archive/html/qemu-devel/2022-11/msg04568.html > https://lists.nongnu.org/archive/html/qemu-devel/2022-11/msg04570.html > > > > -----Original Messages-----From:"Dongdong Zhang" <zhangdongdong@eswincomputing.com>Sent Time:2022-11-30 09:53:57 (Wednesday)To:qemu-devel@nongnu.orgCc:jsnow@redhat.com, crosa@redhat.com, bleal@redhat.com, "Dongdong Zhang" <zhangdongdong@eswincomputing.com>Subject:[PATCH 0/1] Fix some typos > > > > This patch mainly fixes some typos in the 'python' directory. > > > > Dongdong Zhang (1): > > Fix some typos > > > > python/qemu/machine/console_socket.py | 2 +- > > python/qemu/machine/qtest.py | 2 +- > > python/qemu/qmp/protocol.py | 2 +- > > python/qemu/qmp/qmp_tui.py | 6 +++--- > > 4 files changed, 6 insertions(+), 6 deletions(-) > > > > -- > > 2.17.1 ACK to this patch. For fixes under python/qemu/qmp/, I need to relay these fixes over to https://gitlab.com/qemu-project/python-qemu-qmp -- you can do it yourself and send a small merge request, or I can do it for you, if you'd like. Please let me know what you'd prefer, and then I will stage this patch. (Apologies that the code is duplicated in two repositories right now.... I'm working on fixing that.) --js ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: Re: [PING PATCH 0/1] Fix some typos 2023-01-05 23:25 ` John Snow @ 2023-01-06 1:50 ` Dongdong Zhang 2023-01-06 18:44 ` John Snow 0 siblings, 1 reply; 10+ messages in thread From: Dongdong Zhang @ 2023-01-06 1:50 UTC (permalink / raw) To: John Snow; +Cc: qemu-devel, crosa, bleal Hi John, Could you help me relay these fixes? If I submit a pull request, I will go through company's internal review process again. Thanks a lot! Dongdong > -----原始邮件-----发件人:"John Snow" <jsnow@redhat.com>发送时间:2023-01-06 07:25:43 (星期五)收件人:"Dongdong Zhang" <zhangdongdong@eswincomputing.com>抄送:qemu-devel@nongnu.org, crosa@redhat.com, bleal@redhat.com主题:Re: [PING PATCH 0/1] Fix some typos > > On Thu, Dec 15, 2022 at 10:22 PM Dongdong Zhang > <zhangdongdong@eswincomputing.com> wrote: > > > > Hi all, > > > > I would like to ping a patch > > > > https://lists.nongnu.org/archive/html/qemu-devel/2022-11/msg04568.html > > https://lists.nongnu.org/archive/html/qemu-devel/2022-11/msg04570.html > > > > > > > -----Original Messages-----From:"Dongdong Zhang" <zhangdongdong@eswincomputing.com>Sent Time:2022-11-30 09:53:57 (Wednesday)To:qemu-devel@nongnu.orgCc:jsnow@redhat.com, crosa@redhat.com, bleal@redhat.com, "Dongdong Zhang" <zhangdongdong@eswincomputing.com>Subject:[PATCH 0/1] Fix some typos > > > > > > This patch mainly fixes some typos in the 'python' directory. > > > > > > Dongdong Zhang (1): > > > Fix some typos > > > > > > python/qemu/machine/console_socket.py | 2 +- > > > python/qemu/machine/qtest.py | 2 +- > > > python/qemu/qmp/protocol.py | 2 +- > > > python/qemu/qmp/qmp_tui.py | 6 +++--- > > > 4 files changed, 6 insertions(+), 6 deletions(-) > > > > > > -- > > > 2.17.1 > > ACK to this patch. > > For fixes under python/qemu/qmp/, I need to relay these fixes over to > https://gitlab.com/qemu-project/python-qemu-qmp -- you can do it > yourself and send a small merge request, or I can do it for you, if > you'd like. Please let me know what you'd prefer, and then I will > stage this patch. > > (Apologies that the code is duplicated in two repositories right > now.... I'm working on fixing that.) > > --js ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: Re: [PING PATCH 0/1] Fix some typos 2023-01-06 1:50 ` Dongdong Zhang @ 2023-01-06 18:44 ` John Snow 0 siblings, 0 replies; 10+ messages in thread From: John Snow @ 2023-01-06 18:44 UTC (permalink / raw) To: Dongdong Zhang; +Cc: qemu-devel, crosa, bleal On Thu, Jan 5, 2023 at 8:50 PM Dongdong Zhang <zhangdongdong@eswincomputing.com> wrote: > > Hi John, > > Could you help me relay these fixes? > If I submit a pull request, I will go through company's internal review process again. No problem at all. My apologies for the delay. Staged for QEMU, with additional fix spotted by Max: https://gitlab.com/jsnow/qemu/-/commit/4cd8db9f367e12ccd7d3980f2573fe65f9949562 Staged for qemu.qmp, preserving credit: https://gitlab.com/jsnow/python-qemu-qmp/-/commit/cd190a79bcee975d00b0334003e6dcbaf8ec9630 > > Thanks a lot! > Thank *you* :) --js > Dongdong > > > > -----原始邮件-----发件人:"John Snow" <jsnow@redhat.com>发送时间:2023-01-06 07:25:43 (星期五)收件人:"Dongdong Zhang" <zhangdongdong@eswincomputing.com>抄送:qemu-devel@nongnu.org, crosa@redhat.com, bleal@redhat.com主题:Re: [PING PATCH 0/1] Fix some typos > > > > On Thu, Dec 15, 2022 at 10:22 PM Dongdong Zhang > > <zhangdongdong@eswincomputing.com> wrote: > > > > > > Hi all, > > > > > > I would like to ping a patch > > > > > > https://lists.nongnu.org/archive/html/qemu-devel/2022-11/msg04568.html > > > https://lists.nongnu.org/archive/html/qemu-devel/2022-11/msg04570.html > > > > > > > > > > -----Original Messages-----From:"Dongdong Zhang" <zhangdongdong@eswincomputing.com>Sent Time:2022-11-30 09:53:57 (Wednesday)To:qemu-devel@nongnu.orgCc:jsnow@redhat.com, crosa@redhat.com, bleal@redhat.com, "Dongdong Zhang" <zhangdongdong@eswincomputing.com>Subject:[PATCH 0/1] Fix some typos > > > > > > > > This patch mainly fixes some typos in the 'python' directory. > > > > > > > > Dongdong Zhang (1): > > > > Fix some typos > > > > > > > > python/qemu/machine/console_socket.py | 2 +- > > > > python/qemu/machine/qtest.py | 2 +- > > > > python/qemu/qmp/protocol.py | 2 +- > > > > python/qemu/qmp/qmp_tui.py | 6 +++--- > > > > 4 files changed, 6 insertions(+), 6 deletions(-) > > > > > > > > -- > > > > 2.17.1 > > > > ACK to this patch. > > > > For fixes under python/qemu/qmp/, I need to relay these fixes over to > > https://gitlab.com/qemu-project/python-qemu-qmp -- you can do it > > yourself and send a small merge request, or I can do it for you, if > > you'd like. Please let me know what you'd prefer, and then I will > > stage this patch. > > > > (Apologies that the code is duplicated in two repositories right > > now.... I'm working on fixing that.) > > > > --js ^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2023-01-16 20:07 UTC | newest] Thread overview: 10+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2022-11-30 1:53 [PATCH 0/1] Fix some typos Dongdong Zhang 2022-11-30 1:53 ` [PATCH 1/1] " Dongdong Zhang 2022-11-30 8:29 ` Philippe Mathieu-Daudé 2023-01-16 18:10 ` Laurent Vivier 2023-01-16 20:06 ` John Snow 2023-01-05 23:57 ` Max Filippov 2022-12-16 3:22 ` [PING PATCH 0/1] " Dongdong Zhang 2023-01-05 23:25 ` John Snow 2023-01-06 1:50 ` Dongdong Zhang 2023-01-06 18:44 ` John Snow
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).