* [RFC PATCH for 8.0] configure: repeat ourselves for the benefit of CI
@ 2022-12-02 17:47 Alex Bennée
2022-12-02 19:04 ` Philippe Mathieu-Daudé
0 siblings, 1 reply; 2+ messages in thread
From: Alex Bennée @ 2022-12-02 17:47 UTC (permalink / raw)
To: qemu-devel; +Cc: Alex Bennée, Paolo Bonzini, Thomas Huth
Our CI system echos the lines it executes but not the expansions. For
the sake of a line of extra verbosity during the configure phase lets
echo the invocation of script to stdout as well as the log.
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
---
configure | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/configure b/configure
index 26c7bc5154..849ac7aed9 100755
--- a/configure
+++ b/configure
@@ -83,9 +83,10 @@ rm -f config.log
# Print a helpful header at the top of config.log
echo "# QEMU configure log $(date)" >> config.log
printf "# Configured with:" >> config.log
-printf " '%s'" "$0" "$@" >> config.log
-echo >> config.log
-echo "#" >> config.log
+# repeat the invocation to log and stdout for CI
+invoke=$(printf " '%s'" "$0" "$@")
+echo "configuring with: $invoke"
+{ echo "$invoke"; echo; echo "#"; } >> config.log
quote_sh() {
printf "%s" "$1" | sed "s,','\\\\'',g; s,.*,'&',"
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [RFC PATCH for 8.0] configure: repeat ourselves for the benefit of CI
2022-12-02 17:47 [RFC PATCH for 8.0] configure: repeat ourselves for the benefit of CI Alex Bennée
@ 2022-12-02 19:04 ` Philippe Mathieu-Daudé
0 siblings, 0 replies; 2+ messages in thread
From: Philippe Mathieu-Daudé @ 2022-12-02 19:04 UTC (permalink / raw)
To: Alex Bennée, qemu-devel; +Cc: Paolo Bonzini, Thomas Huth
On 2/12/22 18:47, Alex Bennée wrote:
> Our CI system echos the lines it executes but not the expansions. For
> the sake of a line of extra verbosity during the configure phase lets
> echo the invocation of script to stdout as well as the log.
>
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> ---
> configure | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/configure b/configure
> index 26c7bc5154..849ac7aed9 100755
> --- a/configure
> +++ b/configure
> @@ -83,9 +83,10 @@ rm -f config.log
> # Print a helpful header at the top of config.log
> echo "# QEMU configure log $(date)" >> config.log
> printf "# Configured with:" >> config.log
> -printf " '%s'" "$0" "$@" >> config.log
> -echo >> config.log
> -echo "#" >> config.log
> +# repeat the invocation to log and stdout for CI
> +invoke=$(printf " '%s'" "$0" "$@")
> +echo "configuring with: $invoke"
test -n $GITLAB_CI && ... ?
> +{ echo "$invoke"; echo; echo "#"; } >> config.log
>
> quote_sh() {
> printf "%s" "$1" | sed "s,','\\\\'',g; s,.*,'&',"
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-12-02 19:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-12-02 17:47 [RFC PATCH for 8.0] configure: repeat ourselves for the benefit of CI Alex Bennée
2022-12-02 19:04 ` Philippe Mathieu-Daudé
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).