[PATCH 0/3] python: testing fixes

[PATCH 0/3] python: testing fixes

[John Snow]

A few tiny touchups needed for cutting edge 'flake8' tooling, a minor
type touchup in iotests, and extending the python tests to cover the
recently released Python 3.11.

John Snow (3):
  Python: fix flake8 config
  iotests/check: Fix typing for sys.exit() value
  python: add 3.11 to supported list

 python/setup.cfg         | 6 ++++--
 tests/qemu-iotests/check | 2 +-
 2 files changed, 5 insertions(+), 3 deletions(-)

-- 
2.38.1

[PATCH 1/3] Python: fix flake8 config

[John Snow]

Newer flake8 versions are a bit pickier about the config file, and my
in-line comment confuses the parser. Fix it.

Signed-off-by: John Snow <jsnow@redhat.com>
---
 python/setup.cfg | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/python/setup.cfg b/python/setup.cfg
index c2c61c75190..c0d7bab168e 100644
--- a/python/setup.cfg
+++ b/python/setup.cfg
@@ -71,7 +71,8 @@ console_scripts =
     qmp-tui = qemu.qmp.qmp_tui:main [tui]
 
 [flake8]
-extend-ignore = E722  # Prefer pylint's bare-except checks to flake8's
+# Prefer pylint's bare-except checks to flake8's
+extend-ignore = E722
 exclude = __pycache__,
 
 [mypy]
-- 
2.38.1

[PATCH 2/3] iotests/check: Fix typing for sys.exit() value

[John Snow]

Signed-off-by: John Snow <jsnow@redhat.com>
---
 tests/qemu-iotests/check | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/qemu-iotests/check b/tests/qemu-iotests/check
index 75de1b4691e..9bdda1394e7 100755
--- a/tests/qemu-iotests/check
+++ b/tests/qemu-iotests/check
@@ -159,7 +159,7 @@ if __name__ == '__main__':
         if not tests:
             raise ValueError('No tests selected')
     except ValueError as e:
-        sys.exit(e)
+        sys.exit(str(e))
 
     if args.dry_run:
         print('\n'.join(tests))
-- 
2.38.1

[PATCH 3/3] python: add 3.11 to supported list

[John Snow]

Signed-off-by: John Snow <jsnow@redhat.com>
---
 python/setup.cfg | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/python/setup.cfg b/python/setup.cfg
index c0d7bab168e..56418157065 100644
--- a/python/setup.cfg
+++ b/python/setup.cfg
@@ -19,6 +19,7 @@ classifiers =
     Programming Language :: Python :: 3.8
     Programming Language :: Python :: 3.9
     Programming Language :: Python :: 3.10
+    Programming Language :: Python :: 3.11
     Typing :: Typed
 
 [options]
@@ -159,7 +160,7 @@ multi_line_output=3
 # of python available on your system to run this test.
 
 [tox:tox]
-envlist = py36, py37, py38, py39, py310
+envlist = py36, py37, py38, py39, py310, py311
 skip_missing_interpreters = true
 
 [testenv]
-- 
2.38.1

Re: [PATCH 0/3] python: testing fixes

[Wilfred Mallawa]

On Fri, 2022-12-02 at 19:52 -0500, John Snow wrote:
> A few tiny touchups needed for cutting edge 'flake8' tooling, a minor
> type touchup in iotests, and extending the python tests to cover the
> recently released Python 3.11.
> 
> John Snow (3):
>   Python: fix flake8 config
>   iotests/check: Fix typing for sys.exit() value
>   python: add 3.11 to supported list
> 
>  python/setup.cfg         | 6 ++++--
>  tests/qemu-iotests/check | 2 +-
>  2 files changed, 5 insertions(+), 3 deletions(-)
> 
> -- 
> 2.38.1
> 
I see you've left Westeros! xD

Reviewed-by: Wilfred Mallawa <wilfred.mallawa@wdc.com>
> 
> 

Re: [PATCH 0/3] python: testing fixes

[John Snow]

On Sun, Dec 4, 2022 at 5:39 PM Wilfred Mallawa <wilfred.mallawa@wdc.com> wrote:
>
> On Fri, 2022-12-02 at 19:52 -0500, John Snow wrote:
> > A few tiny touchups needed for cutting edge 'flake8' tooling, a minor
> > type touchup in iotests, and extending the python tests to cover the
> > recently released Python 3.11.
> >
> > John Snow (3):
> >   Python: fix flake8 config
> >   iotests/check: Fix typing for sys.exit() value
> >   python: add 3.11 to supported list
> >
> >  python/setup.cfg         | 6 ++++--
> >  tests/qemu-iotests/check | 2 +-
> >  2 files changed, 5 insertions(+), 3 deletions(-)
> >
> > --
> > 2.38.1
> >
> I see you've left Westeros! xD

I'm not a huge fan of these ...

>
> Reviewed-by: Wilfred Mallawa <wilfred.mallawa@wdc.com>

... but thank you for the review.

--js