From: Markus Armbruster <armbru@redhat.com>
To: qemu-devel@nongnu.org
Cc: clg@kaod.org, qemu-ppc@nongnu.org
Subject: [PATCH 0/4] hw/ppc: Clean up includes
Date: Sat, 10 Dec 2022 12:21:36 +0100 [thread overview]
Message-ID: <20221210112140.4057731-1-armbru@redhat.com> (raw)
Back in 2016, we discussed[1] rules for headers, and these were
generally liked:
1. Have a carefully curated header that's included everywhere first. We
got that already thanks to Peter: osdep.h.
2. Headers should normally include everything they need beyond osdep.h.
If exceptions are needed for some reason, they must be documented in
the header. If all that's needed from a header is typedefs, put
those into qemu/typedefs.h instead of including the header.
3. Cyclic inclusion is forbidden.
After this series, include/hw/ppc and include/hw/pci-host/pnv* conform
to these rules.
It is based on
[PATCH 0/5] include/hw/pci include/hw/cxl: Clean up includes
[PATCH 0/3] block: Clean up includes
[PATCH 0/4] coroutine: Clean up includes
[1] Message-ID: <87h9g8j57d.fsf@blackfin.pond.sub.org>
https://lists.nongnu.org/archive/html/qemu-devel/2016-03/msg03345.html
Based-on: <20221209134802.3642942-1-armbru@redhat.com>
Markus Armbruster (4):
include/hw/ppc: Split pnv_chip.h off pnv.h
include/hw/ppc: Supply a few missing includes
include/hw/ppc: Don't include hw/pci-host/pnv_phb.h from pnv.h
include/hw/ppc include/hw/pci-host: Drop extra typedefs
hw/pci-host/pnv_phb.h | 2 +-
include/hw/pci-host/pnv_phb3.h | 1 -
include/hw/pci-host/pnv_phb4.h | 5 +-
include/hw/ppc/pnv.h | 146 +-------------------------------
include/hw/ppc/pnv_chip.h | 147 +++++++++++++++++++++++++++++++++
include/hw/ppc/pnv_core.h | 3 +-
include/hw/ppc/pnv_homer.h | 2 +-
include/hw/ppc/pnv_lpc.h | 11 +--
include/hw/ppc/pnv_occ.h | 3 +-
include/hw/ppc/pnv_pnor.h | 2 +-
include/hw/ppc/pnv_sbe.h | 3 +-
include/hw/ppc/pnv_xive.h | 7 +-
include/hw/ppc/pnv_xscom.h | 3 +-
include/hw/ppc/xive2.h | 2 +
include/hw/ppc/xive2_regs.h | 2 +
hw/intc/pnv_xive.c | 1 +
hw/intc/pnv_xive2.c | 1 +
hw/pci-host/pnv_phb3.c | 1 +
hw/pci-host/pnv_phb4_pec.c | 1 +
hw/ppc/pnv.c | 3 +
hw/ppc/pnv_core.c | 1 +
hw/ppc/pnv_homer.c | 1 +
hw/ppc/pnv_lpc.c | 1 +
hw/ppc/pnv_psi.c | 1 +
hw/ppc/pnv_xscom.c | 1 +
25 files changed, 186 insertions(+), 165 deletions(-)
create mode 100644 include/hw/ppc/pnv_chip.h
--
2.37.3
next reply other threads:[~2022-12-10 11:23 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-10 11:21 Markus Armbruster [this message]
2022-12-10 11:21 ` [PATCH 1/4] include/hw/ppc: Split pnv_chip.h off pnv.h Markus Armbruster
2022-12-10 11:41 ` Cédric Le Goater
2022-12-10 11:21 ` [PATCH 2/4] include/hw/ppc: Supply a few missing includes Markus Armbruster
2022-12-10 11:42 ` Cédric Le Goater
2022-12-10 11:21 ` [PATCH 3/4] include/hw/ppc: Don't include hw/pci-host/pnv_phb.h from pnv.h Markus Armbruster
2022-12-11 7:54 ` Cédric Le Goater
2022-12-12 7:28 ` Markus Armbruster
2022-12-10 11:21 ` [PATCH 4/4] include/hw/ppc include/hw/pci-host: Drop extra typedefs Markus Armbruster
2022-12-10 12:47 ` Philippe Mathieu-Daudé
2022-12-11 7:55 ` Cédric Le Goater
2022-12-16 18:47 ` [PATCH 0/4] hw/ppc: Clean up includes Daniel Henrique Barboza
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221210112140.4057731-1-armbru@redhat.com \
--to=armbru@redhat.com \
--cc=clg@kaod.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).