qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Klaus Jensen <its@irrelevant.dk>
To: qemu-devel@nongnu.org
Cc: qemu-block@nongnu.org, Klaus Jensen <its@irrelevant.dk>,
	Keith Busch <kbusch@kernel.org>,
	Jinhao Fan <fanjinhao21s@ict.ac.cn>,
	Guenter Roeck <linux@roeck-us.net>,
	Klaus Jensen <k.jensen@samsung.com>
Subject: [PATCH v4 0/4] hw/nvme: fix broken shadow doorbells on some platforms
Date: Mon, 12 Dec 2022 12:44:05 +0100	[thread overview]
Message-ID: <20221212114409.34972-1-its@irrelevant.dk> (raw)

From: Klaus Jensen <k.jensen@samsung.com>

Guenter reports that hw/nvme is broken on riscv64[1] and big endian
platforms[2].

This is a regression since 7.1, so this does not warrent an rc5 for 7.2.
I'm sure Guenter can carry this patch in his tree, and maybe we can get
this out in a stable release.

On riscv, the issue is a missing cq eventidx update. I really wonder why
this issue only shows up on riscv64. We have not observed this on other
platforms (yet).

Further, Guenter also reported problems on big-endian platforms. The
issue here is missing endian conversions which patch 3 addresses. This
also requires a fix for the Linux kernel that I am posting separately
(can't link to it, chicken and egg problem).

  [1]: https://lore.kernel.org/qemu-devel/20221207174918.GA1151796@roeck-us.net/
  [2]: https://lore.kernel.org/qemu-devel/20221209110022.GA3396194@roeck-us.net/

v4:
 - screwed up the rebase (Philippe)

v3:
 - add patch to fix big-endian platforms

v2:
 - use QOM accessor (Philippe)
 - added some cleanup patches in front

Klaus Jensen (4):
  hw/nvme: use QOM accessors
  hw/nvme: rename shadow doorbell related trace events
  hw/nvme: fix missing endian conversions for doorbell buffers
  hw/nvme: fix missing cq eventidx update

 hw/nvme/ctrl.c       | 121 ++++++++++++++++++++++++++-----------------
 hw/nvme/trace-events |   8 +--
 2 files changed, 78 insertions(+), 51 deletions(-)

-- 
2.38.1



             reply	other threads:[~2022-12-12 11:55 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-12 11:44 Klaus Jensen [this message]
2022-12-12 11:44 ` [PATCH v4 1/4] hw/nvme: use QOM accessors Klaus Jensen
2022-12-12 11:44 ` [PATCH v4 2/4] hw/nvme: rename shadow doorbell related trace events Klaus Jensen
2022-12-14 18:33   ` Keith Busch
2022-12-12 11:44 ` [PATCH v4 3/4] hw/nvme: fix missing endian conversions for doorbell buffers Klaus Jensen
2022-12-12 12:53   ` Philippe Mathieu-Daudé
2022-12-14 18:34   ` Keith Busch
2022-12-12 11:44 ` [PATCH v4 4/4] hw/nvme: fix missing cq eventidx update Klaus Jensen
2022-12-14 18:33   ` Keith Busch
2023-01-06 10:28 ` [PATCH v4 0/4] hw/nvme: fix broken shadow doorbells on some platforms Klaus Jensen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221212114409.34972-1-its@irrelevant.dk \
    --to=its@irrelevant.dk \
    --cc=fanjinhao21s@ict.ac.cn \
    --cc=k.jensen@samsung.com \
    --cc=kbusch@kernel.org \
    --cc=linux@roeck-us.net \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).