From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: qemu-devel@nongnu.org, Peter Maydell <peter.maydell@linaro.org>
Cc: "Daniel Henrique Barboza" <danielhb413@gmail.com>,
"BALATON Zoltan" <balaton@eik.bme.hu>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Alistair Francis" <alistair@alistair23.me>,
"David Gibson" <david@gibson.dropbear.id.au>,
"Jason Wang" <jasowang@redhat.com>,
"Cédric Le Goater" <clg@kaod.org>, "Greg Kurz" <groug@kaod.org>,
qemu-arm@nongnu.org,
"Edgar E. Iglesias" <edgar.iglesias@gmail.com>,
qemu-ppc@nongnu.org, "Philippe Mathieu-Daudé" <philmd@linaro.org>
Subject: [RFC PATCH-for-8.0 1/3] hw/ppc: Replace tswap32() by const_le32()
Date: Tue, 13 Dec 2022 13:52:16 +0100 [thread overview]
Message-ID: <20221213125218.39868-2-philmd@linaro.org> (raw)
In-Reply-To: <20221213125218.39868-1-philmd@linaro.org>
Assuming the developers of commits 2c50e26efd ("powerpc: Add
a virtex5 ml507 refdesign board") and 4b387f9ee1 ("ppc: Add
aCube Sam460ex board") were testing on a little-endian setup,
they meant to use const_le32() instead of tswap32() here,
since tswap32() depends on the host endianness.
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
hw/ppc/sam460ex.c | 3 ++-
hw/ppc/virtex_ml507.c | 3 ++-
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/hw/ppc/sam460ex.c b/hw/ppc/sam460ex.c
index 4a22ce3761..88b1480138 100644
--- a/hw/ppc/sam460ex.c
+++ b/hw/ppc/sam460ex.c
@@ -15,6 +15,7 @@
#include "qemu/units.h"
#include "qemu/datadir.h"
#include "qemu/error-report.h"
+#include "qemu/bswap.h"
#include "qapi/error.h"
#include "hw/boards.h"
#include "sysemu/kvm.h"
@@ -255,7 +256,7 @@ static void main_cpu_reset(void *opaque)
/* Create a mapping for the kernel. */
mmubooke_create_initial_mapping(env, 0, 0);
- env->gpr[6] = tswap32(EPAPR_MAGIC);
+ env->gpr[6] = const_le32(EPAPR_MAGIC);
env->gpr[7] = (16 * MiB) - 8; /* bi->ima_size; */
} else {
diff --git a/hw/ppc/virtex_ml507.c b/hw/ppc/virtex_ml507.c
index 13cace229b..0f282ecaa7 100644
--- a/hw/ppc/virtex_ml507.c
+++ b/hw/ppc/virtex_ml507.c
@@ -38,6 +38,7 @@
#include "qapi/error.h"
#include "qemu/error-report.h"
#include "qemu/option.h"
+#include "qemu/bswap.h"
#include "hw/intc/ppc-uic.h"
#include "hw/ppc/ppc.h"
@@ -141,7 +142,7 @@ static void main_cpu_reset(void *opaque)
/* Create a mapping for the kernel. */
mmubooke_create_initial_mapping(env, 0, 0);
- env->gpr[6] = tswap32(EPAPR_MAGIC);
+ env->gpr[6] = const_le32(EPAPR_MAGIC);
env->gpr[7] = bi->ima_size;
}
--
2.38.1
next prev parent reply other threads:[~2022-12-13 12:53 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-13 12:52 [RFC PATCH-for-8.0 0/3] hw/ppc: Remove tswap() calls Philippe Mathieu-Daudé
2022-12-13 12:52 ` Philippe Mathieu-Daudé [this message]
2022-12-13 16:00 ` [RFC PATCH-for-8.0 1/3] hw/ppc: Replace tswap32() by const_le32() Richard Henderson
2022-12-13 16:10 ` Philippe Mathieu-Daudé
2022-12-13 16:14 ` Richard Henderson
2022-12-13 16:21 ` Peter Maydell
2022-12-13 16:27 ` Richard Henderson
2022-12-13 16:53 ` Cédric Le Goater
2022-12-13 17:23 ` Peter Maydell
2022-12-13 17:51 ` Edgar E. Iglesias
2022-12-13 18:09 ` BALATON Zoltan
2022-12-13 21:37 ` Peter Maydell
2022-12-13 18:13 ` Cédric Le Goater
2023-05-17 10:51 ` Thomas Huth
2022-12-13 12:52 ` [RFC PATCH-for-8.0 2/3] hw/ppc/spapr: Replace tswap64(HPTE) by cpu_to_be64(HPTE) Philippe Mathieu-Daudé
2022-12-13 13:51 ` Peter Maydell
2022-12-16 19:10 ` Daniel Henrique Barboza
2022-12-16 21:39 ` Peter Maydell
2022-12-19 6:31 ` David Gibson
2022-12-19 10:39 ` Peter Maydell
2022-12-21 1:16 ` David Gibson
2022-12-21 12:33 ` Peter Maydell
2022-12-21 16:03 ` Cédric Le Goater
2022-12-21 22:15 ` Peter Maydell
2022-12-22 1:56 ` David Gibson
2022-12-13 12:52 ` [RFC PATCH-for-8.0 3/3] hw/net/xilinx_ethlite: Replace tswap32() by be32_to_cpu() Philippe Mathieu-Daudé
2022-12-13 13:53 ` Peter Maydell
2022-12-13 13:54 ` Edgar E. Iglesias
2022-12-13 14:18 ` Peter Maydell
2022-12-13 14:23 ` Edgar E. Iglesias
2022-12-13 15:22 ` Peter Maydell
2022-12-13 15:41 ` Edgar E. Iglesias
2024-04-22 12:46 ` Philippe Mathieu-Daudé
2022-12-13 16:56 ` [RFC PATCH-for-8.0 0/3] hw/ppc: Remove tswap() calls Cédric Le Goater
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221213125218.39868-2-philmd@linaro.org \
--to=philmd@linaro.org \
--cc=alex.bennee@linaro.org \
--cc=alistair@alistair23.me \
--cc=balaton@eik.bme.hu \
--cc=clg@kaod.org \
--cc=danielhb413@gmail.com \
--cc=david@gibson.dropbear.id.au \
--cc=edgar.iglesias@gmail.com \
--cc=groug@kaod.org \
--cc=jasowang@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).