From: "Michael S. Tsirkin" <mst@redhat.com>
To: Jason Wang <jasowang@redhat.com>
Cc: peterx@redhat.com, qemu-devel@nongnu.org, eric.auger@redhat.com,
viktor@daynix.com
Subject: Re: [PATCH 0/3] Fix UNMAP notifier for intel-iommu
Date: Tue, 20 Dec 2022 08:53:25 -0500 [thread overview]
Message-ID: <20221220085253-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20221129081037.12099-1-jasowang@redhat.com>
On Tue, Nov 29, 2022 at 04:10:34PM +0800, Jason Wang wrote:
> Hi All:
>
> According to ATS, device should work if ATS is disabled. This is not
> correctly implemented in the current intel-iommu since it doesn't
> handle the UNMAP notifier correctly. This breaks the vhost-net +
> vIOMMU without dt.
>
> The root casue is that the when there's a device IOTLB miss (note that
> it's not specific to PCI so it can work without ATS), Qemu doesn't
> build the IOVA tree, so when guest start an IOTLB invalidation, Qemu
> won't trigger the UNMAP notifier.
>
> Fixing by build IOVA tree during IOMMU translsation.
>
> Thanks
IIUC you were going to post v2? At least commit log fixes.
> Jason Wang (3):
> intel-iommu: fail MAP notifier without caching mode
> intel-iommu: fail DEVIOTLB_UNMAP without dt mode
> intel-iommu: build iova tree during IOMMU translation
>
> hw/i386/intel_iommu.c | 58 ++++++++++++++++++++++++-------------------
> 1 file changed, 33 insertions(+), 25 deletions(-)
>
> --
> 2.25.1
next prev parent reply other threads:[~2022-12-20 13:55 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-29 8:10 [PATCH 0/3] Fix UNMAP notifier for intel-iommu Jason Wang
2022-11-29 8:10 ` [PATCH 1/3] intel-iommu: fail MAP notifier without caching mode Jason Wang
2022-11-29 15:35 ` Peter Xu
2022-11-30 6:23 ` Jason Wang
2022-11-30 15:06 ` Peter Xu
2022-12-01 8:46 ` Jason Wang
2022-12-06 13:23 ` Eric Auger
2022-11-29 8:10 ` [PATCH 2/3] intel-iommu: fail DEVIOTLB_UNMAP without dt mode Jason Wang
2022-11-29 15:38 ` Peter Xu
2022-12-01 16:03 ` Peter Xu
2023-02-23 3:19 ` Jason Wang
2022-12-06 13:33 ` Eric Auger
2023-02-03 9:08 ` Laurent Vivier
2023-02-07 16:17 ` Laurent Vivier
2023-02-07 16:35 ` Peter Xu
2022-11-29 8:10 ` [PATCH 3/3] intel-iommu: build iova tree during IOMMU translation Jason Wang
2022-11-29 15:57 ` Peter Xu
2022-11-30 6:33 ` Jason Wang
2022-11-30 15:17 ` Peter Xu
2022-12-01 8:35 ` Jason Wang
2022-12-01 14:58 ` Peter Xu
2022-12-05 4:12 ` Jason Wang
2022-12-05 23:18 ` Peter Xu
2022-12-06 3:18 ` Jason Wang
2022-12-06 13:58 ` Peter Xu
2022-12-23 8:02 ` Jason Wang
2022-12-23 16:22 ` Peter Xu
2022-11-30 16:37 ` [PATCH 0/3] Fix UNMAP notifier for intel-iommu Michael S. Tsirkin
2022-12-01 8:29 ` Jason Wang
2022-12-20 13:53 ` Michael S. Tsirkin [this message]
2022-12-21 3:17 ` Jason Wang
2023-01-15 23:30 ` Viktor Prutyanov
2023-01-16 7:06 ` Jason Wang
2023-01-27 13:17 ` Michael S. Tsirkin
2023-01-29 5:43 ` Jason Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221220085253-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=eric.auger@redhat.com \
--cc=jasowang@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=viktor@daynix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).