* [PATCH] qom/object_interfaces: Fix QAPI headers included
@ 2022-12-20 11:57 Philippe Mathieu-Daudé
2022-12-21 0:57 ` Richard Henderson
0 siblings, 1 reply; 2+ messages in thread
From: Philippe Mathieu-Daudé @ 2022-12-20 11:57 UTC (permalink / raw)
To: qemu-devel
Cc: Markus Armbruster, Daniel P. Berrangé, Paolo Bonzini,
Eduardo Habkost, Philippe Mathieu-Daudé
Since commit a0e61807a3 ("qapi: Remove QMP events and commands from
user-mode builds") we don't generate the "qapi-commands-qom.h"
header in a user-emulation-only build.
Commit f375026606 ("qom: Factor out user_creatable_process_cmdline")
incorrectly added a dependency on this "qapi/qapi-commands-qom.h"
header (the QMP handlers are still defined in qom/qom-qmp-cmds.c).
Remove it, and add "qapi/qmp/qobject.h" which declares qobject_unref.
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
qom/object_interfaces.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/qom/object_interfaces.c b/qom/object_interfaces.c
index f94b6c3193..7d31589b04 100644
--- a/qom/object_interfaces.c
+++ b/qom/object_interfaces.c
@@ -2,8 +2,8 @@
#include "qemu/cutils.h"
#include "qapi/error.h"
-#include "qapi/qapi-commands-qom.h"
#include "qapi/qapi-visit-qom.h"
+#include "qapi/qmp/qobject.h"
#include "qapi/qmp/qdict.h"
#include "qapi/qmp/qerror.h"
#include "qapi/qmp/qjson.h"
--
2.38.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] qom/object_interfaces: Fix QAPI headers included
2022-12-20 11:57 [PATCH] qom/object_interfaces: Fix QAPI headers included Philippe Mathieu-Daudé
@ 2022-12-21 0:57 ` Richard Henderson
0 siblings, 0 replies; 2+ messages in thread
From: Richard Henderson @ 2022-12-21 0:57 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, qemu-devel
Cc: Markus Armbruster, Daniel P. Berrangé, Paolo Bonzini,
Eduardo Habkost
On 12/20/22 03:57, Philippe Mathieu-Daudé wrote:
> Since commit a0e61807a3 ("qapi: Remove QMP events and commands from
> user-mode builds") we don't generate the "qapi-commands-qom.h"
> header in a user-emulation-only build.
>
> Commit f375026606 ("qom: Factor out user_creatable_process_cmdline")
> incorrectly added a dependency on this "qapi/qapi-commands-qom.h"
> header (the QMP handlers are still defined in qom/qom-qmp-cmds.c).
> Remove it, and add "qapi/qmp/qobject.h" which declares qobject_unref.
>
> Signed-off-by: Philippe Mathieu-Daudé<philmd@linaro.org>
> ---
> qom/object_interfaces.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-12-21 0:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-12-20 11:57 [PATCH] qom/object_interfaces: Fix QAPI headers included Philippe Mathieu-Daudé
2022-12-21 0:57 ` Richard Henderson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).