qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: David Woodhouse <dwmw2@infradead.org>
To: qemu-devel@nongnu.org
Cc: "Paolo Bonzini" <pbonzini@redhat.com>,
	"Paul Durrant" <paul@xen.org>,
	"Joao Martins" <joao.m.martins@oracle.com>,
	"Ankur Arora" <ankur.a.arora@oracle.com>,
	"Philippe Mathieu-Daudé" <philmd@linaro.org>,
	"Thomas Huth" <thuth@redhat.com>,
	"Alex Bennée" <alex.bennee@linaro.org>,
	"Juan Quintela" <quintela@redhat.com>,
	"Dr . David Alan Gilbert" <dgilbert@redhat.com>,
	"Claudio Fontana" <cfontana@suse.de>
Subject: [RFC PATCH v4 23/47] i386/xen: handle VCPUOP_register_runstate_memory_area
Date: Wed, 21 Dec 2022 01:05:59 +0000	[thread overview]
Message-ID: <20221221010623.1000191-24-dwmw2@infradead.org> (raw)
In-Reply-To: <20221221010623.1000191-1-dwmw2@infradead.org>

From: Joao Martins <joao.m.martins@oracle.com>

Allow guest to setup the vcpu runstates which is used as
steal clock.

Signed-off-by: Joao Martins <joao.m.martins@oracle.com>
Signed-off-by: David Woodhouse <dwmw@amazon.co.uk>
---
 target/i386/cpu.h         |  1 +
 target/i386/kvm/xen-emu.c | 57 +++++++++++++++++++++++++++++++++++++++
 target/i386/machine.c     |  1 +
 3 files changed, 59 insertions(+)

diff --git a/target/i386/cpu.h b/target/i386/cpu.h
index 96c2d0d5cb..bf44a87ddb 100644
--- a/target/i386/cpu.h
+++ b/target/i386/cpu.h
@@ -1791,6 +1791,7 @@ typedef struct CPUArchState {
     uint64_t xen_vcpu_info_gpa;
     uint64_t xen_vcpu_info_default_gpa;
     uint64_t xen_vcpu_time_info_gpa;
+    uint64_t xen_vcpu_runstate_gpa;
 #endif
 #if defined(CONFIG_HVF)
     HVFX86LazyFlags hvf_lflags;
diff --git a/target/i386/kvm/xen-emu.c b/target/i386/kvm/xen-emu.c
index ebb5d1296a..6521df0461 100644
--- a/target/i386/kvm/xen-emu.c
+++ b/target/i386/kvm/xen-emu.c
@@ -161,6 +161,7 @@ int kvm_xen_init_vcpu(CPUState *cs)
     env->xen_vcpu_info_gpa = INVALID_GPA;
     env->xen_vcpu_info_default_gpa = INVALID_GPA;
     env->xen_vcpu_time_info_gpa = INVALID_GPA;
+    env->xen_vcpu_runstate_gpa = INVALID_GPA;
 
     return 0;
 }
@@ -255,6 +256,17 @@ static void do_set_vcpu_time_info_gpa(CPUState *cs, run_on_cpu_data data)
                           env->xen_vcpu_time_info_gpa);
 }
 
+static void do_set_vcpu_runstate_gpa(CPUState *cs, run_on_cpu_data data)
+{
+    X86CPU *cpu = X86_CPU(cs);
+    CPUX86State *env = &cpu->env;
+
+    env->xen_vcpu_runstate_gpa = data.host_ulong;
+
+    kvm_xen_set_vcpu_attr(cs, KVM_XEN_VCPU_ATTR_TYPE_RUNSTATE_ADDR,
+                          env->xen_vcpu_runstate_gpa);
+}
+
 static void do_vcpu_soft_reset(CPUState *cs, run_on_cpu_data data)
 {
     X86CPU *cpu = X86_CPU(cs);
@@ -263,10 +275,14 @@ static void do_vcpu_soft_reset(CPUState *cs, run_on_cpu_data data)
     env->xen_vcpu_info_gpa = INVALID_GPA;
     env->xen_vcpu_info_default_gpa = INVALID_GPA;
     env->xen_vcpu_time_info_gpa = INVALID_GPA;
+    env->xen_vcpu_runstate_gpa = INVALID_GPA;
 
     kvm_xen_set_vcpu_attr(cs, KVM_XEN_VCPU_ATTR_TYPE_VCPU_INFO, INVALID_GPA);
     kvm_xen_set_vcpu_attr(cs, KVM_XEN_VCPU_ATTR_TYPE_VCPU_TIME_INFO,
                           INVALID_GPA);
+    kvm_xen_set_vcpu_attr(cs, KVM_XEN_VCPU_ATTR_TYPE_RUNSTATE_ADDR,
+                          INVALID_GPA);
+
 }
 
 static int xen_set_shared_info(uint64_t gfn)
@@ -516,6 +532,35 @@ static int vcpuop_register_vcpu_time_info(CPUState *cs, CPUState *target,
     return 0;
 }
 
+static int vcpuop_register_runstate_info(CPUState *cs, CPUState *target,
+                                         uint64_t arg)
+{
+    struct vcpu_register_runstate_memory_area rma;
+    uint64_t gpa;
+    size_t len;
+
+    /* No need for 32/64 compat handling */
+    qemu_build_assert(sizeof(rma) == 8);
+    /* The runstate area actually does change size, but Linux copes. */
+
+    if (!target) {
+        return -ENOENT;
+    }
+
+    if (kvm_copy_from_gva(cs, arg, &rma, sizeof(rma))) {
+        return -EFAULT;
+    }
+
+    /* As with vcpu_time_info, Xen actually uses the GVA but KVM doesn't. */
+    if (!kvm_gva_to_gpa(cs, rma.addr.p, &gpa, &len, false)) {
+        return -EFAULT;
+    }
+
+    async_run_on_cpu(target, do_set_vcpu_runstate_gpa,
+                     RUN_ON_CPU_HOST_ULONG(gpa));
+    return 0;
+}
+
 static bool kvm_xen_hcall_vcpu_op(struct kvm_xen_exit *exit, X86CPU *cpu,
                                   int cmd, int vcpu_id, uint64_t arg)
 {
@@ -524,6 +569,9 @@ static bool kvm_xen_hcall_vcpu_op(struct kvm_xen_exit *exit, X86CPU *cpu,
     int err;
 
     switch (cmd) {
+    case VCPUOP_register_runstate_memory_area:
+        err = vcpuop_register_runstate_info(cs, dest, arg);
+        break;
     case VCPUOP_register_vcpu_time_memory_area:
         err = vcpuop_register_vcpu_time_info(cs, dest, arg);
         break;
@@ -722,6 +770,15 @@ int kvm_put_xen_state(CPUState *cs)
         }
     }
 
+    gpa = env->xen_vcpu_runstate_gpa;
+    if (gpa != INVALID_GPA) {
+        ret = kvm_xen_set_vcpu_attr(cs, KVM_XEN_VCPU_ATTR_TYPE_RUNSTATE_ADDR,
+                                    gpa);
+        if (ret < 0) {
+            return ret;
+        }
+    }
+
     return 0;
 }
 
diff --git a/target/i386/machine.c b/target/i386/machine.c
index eb657907ca..3f3d436aaa 100644
--- a/target/i386/machine.c
+++ b/target/i386/machine.c
@@ -1273,6 +1273,7 @@ static const VMStateDescription vmstate_xen_vcpu = {
         VMSTATE_UINT64(env.xen_vcpu_info_gpa, X86CPU),
         VMSTATE_UINT64(env.xen_vcpu_info_default_gpa, X86CPU),
         VMSTATE_UINT64(env.xen_vcpu_time_info_gpa, X86CPU),
+        VMSTATE_UINT64(env.xen_vcpu_runstate_gpa, X86CPU),
         VMSTATE_END_OF_LIST()
     }
 };
-- 
2.35.3



  parent reply	other threads:[~2022-12-21  1:07 UTC|newest]

Thread overview: 51+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-21  1:05 [RFC PATCH v4 01/47] Xen HVM support under KVM David Woodhouse
2022-12-21  1:05 ` [RFC PATCH v4 01/47] include: import Xen public headers to include/standard-headers/ David Woodhouse
2022-12-21  1:05 ` [RFC PATCH v4 02/47] xen: add CONFIG_XENFV_MACHINE and CONFIG_XEN_EMU options for Xen emulation David Woodhouse
2022-12-21  1:05 ` [RFC PATCH v4 03/47] xen: Add XEN_DISABLED mode and make it default David Woodhouse
2022-12-21 17:54   ` Paul Durrant
2022-12-21  1:05 ` [RFC PATCH v4 04/47] i386/kvm: Add xen-version KVM accelerator property and init KVM Xen support David Woodhouse
2022-12-21  1:05 ` [RFC PATCH v4 05/47] i386/kvm: handle Xen HVM cpuid leaves David Woodhouse
2022-12-21  1:05 ` [RFC PATCH v4 06/47] i386/hvm: Set Xen vCPU ID in KVM David Woodhouse
2022-12-21 18:00   ` Paul Durrant
2022-12-21  1:05 ` [RFC PATCH v4 07/47] xen-platform: exclude vfio-pci from the PCI platform unplug David Woodhouse
2022-12-21  1:05 ` [RFC PATCH v4 08/47] xen-platform: allow its creation with XEN_EMULATE mode David Woodhouse
2022-12-21  1:05 ` [RFC PATCH v4 09/47] hw/xen_backend: refactor xen_be_init() David Woodhouse
2022-12-21  1:05 ` [RFC PATCH v4 10/47] i386/xen: handle guest hypercalls David Woodhouse
2022-12-21  1:05 ` [RFC PATCH v4 11/47] i386/xen: implement HYPERVISOR_xen_version David Woodhouse
2022-12-21 18:03   ` Paul Durrant
2022-12-21  1:05 ` [RFC PATCH v4 12/47] i386/xen: implement HYPERVISOR_sched_op, SCHEDOP_shutdown David Woodhouse
2022-12-21  1:05 ` [RFC PATCH v4 13/47] i386/xen: Implement SCHEDOP_poll and SCHEDOP_yield David Woodhouse
2022-12-21  1:05 ` [RFC PATCH v4 14/47] hw/xen: Add xen_overlay device for emulating shared xenheap pages David Woodhouse
2022-12-21  1:05 ` [RFC PATCH v4 15/47] i386/xen: add pc_machine_kvm_type to initialize XEN_EMULATE mode David Woodhouse
2022-12-21  1:05 ` [RFC PATCH v4 16/47] i386/xen: manage and save/restore Xen guest long_mode setting David Woodhouse
2022-12-21  1:05 ` [RFC PATCH v4 17/47] i386/xen: implement HYPERVISOR_memory_op David Woodhouse
2022-12-21  1:05 ` [RFC PATCH v4 18/47] i386/xen: implement XENMEM_add_to_physmap_batch David Woodhouse
2022-12-21  1:05 ` [RFC PATCH v4 19/47] i386/xen: implement HYPERVISOR_hvm_op David Woodhouse
2022-12-21  1:05 ` [RFC PATCH v4 20/47] i386/xen: implement HYPERVISOR_vcpu_op David Woodhouse
2022-12-21  1:05 ` [RFC PATCH v4 21/47] i386/xen: handle VCPUOP_register_vcpu_info David Woodhouse
2022-12-21  1:05 ` [RFC PATCH v4 22/47] i386/xen: handle VCPUOP_register_vcpu_time_info David Woodhouse
2022-12-21  1:05 ` David Woodhouse [this message]
2022-12-21  1:06 ` [RFC PATCH v4 24/47] i386/xen: implement HYPERVISOR_event_channel_op David Woodhouse
2022-12-21  1:06 ` [RFC PATCH v4 25/47] i386/xen: implement HVMOP_set_evtchn_upcall_vector David Woodhouse
2022-12-21  1:06 ` [RFC PATCH v4 26/47] i386/xen: implement HVMOP_set_param David Woodhouse
2022-12-21  1:06 ` [RFC PATCH v4 27/47] hw/xen: Add xen_evtchn device for event channel emulation David Woodhouse
2022-12-21  1:06 ` [RFC PATCH v4 28/47] i386/xen: Add support for Xen event channel delivery to vCPU David Woodhouse
2022-12-21  1:06 ` [RFC PATCH v4 29/47] hw/xen: Implement EVTCHNOP_status David Woodhouse
2022-12-21  1:06 ` [RFC PATCH v4 30/47] hw/xen: Implement EVTCHNOP_close David Woodhouse
2022-12-21  1:06 ` [RFC PATCH v4 31/47] hw/xen: Implement EVTCHNOP_unmask David Woodhouse
2022-12-21  1:06 ` [RFC PATCH v4 32/47] hw/xen: Implement EVTCHNOP_bind_virq David Woodhouse
2022-12-21  1:06 ` [RFC PATCH v4 33/47] hw/xen: Implement EVTCHNOP_bind_ipi David Woodhouse
2022-12-21  1:06 ` [RFC PATCH v4 34/47] hw/xen: Implement EVTCHNOP_send David Woodhouse
2022-12-21  1:06 ` [RFC PATCH v4 35/47] hw/xen: Implement EVTCHNOP_alloc_unbound David Woodhouse
2022-12-21  1:06 ` [RFC PATCH v4 36/47] hw/xen: Implement EVTCHNOP_bind_interdomain David Woodhouse
2022-12-21  1:06 ` [RFC PATCH v4 37/47] hw/xen: Implement EVTCHNOP_bind_vcpu David Woodhouse
2022-12-21  1:06 ` [RFC PATCH v4 38/47] hw/xen: Implement EVTCHNOP_reset David Woodhouse
2022-12-21  1:06 ` [RFC PATCH v4 39/47] i386/xen: add monitor commands to test event injection David Woodhouse
2022-12-21  1:06 ` [RFC PATCH v4 40/47] hw/xen: Support HVM_PARAM_CALLBACK_TYPE_GSI callback David Woodhouse
2022-12-21  1:06 ` [RFC PATCH v4 41/47] hw/xen: Support HVM_PARAM_CALLBACK_TYPE_PCI_INTX callback David Woodhouse
2022-12-21  1:06 ` [RFC PATCH v4 42/47] kvm/i386: Add xen-gnttab-max-frames property David Woodhouse
2022-12-21  1:06 ` [RFC PATCH v4 43/47] hw/xen: Add xen_gnttab device for grant table emulation David Woodhouse
2022-12-21  1:06 ` [RFC PATCH v4 44/47] hw/xen: Support mapping grant frames David Woodhouse
2022-12-21  1:06 ` [RFC PATCH v4 45/47] i386/xen: Implement HYPERVISOR_grant_table_op and GNTTABOP_[gs]et_verson David Woodhouse
2022-12-21  1:06 ` [RFC PATCH v4 46/47] hw/xen: Implement GNTTABOP_query_size David Woodhouse
2022-12-21  1:06 ` [RFC PATCH v4 47/47] i386/xen: handle PV timer hypercalls David Woodhouse

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221221010623.1000191-24-dwmw2@infradead.org \
    --to=dwmw2@infradead.org \
    --cc=alex.bennee@linaro.org \
    --cc=ankur.a.arora@oracle.com \
    --cc=cfontana@suse.de \
    --cc=dgilbert@redhat.com \
    --cc=joao.m.martins@oracle.com \
    --cc=paul@xen.org \
    --cc=pbonzini@redhat.com \
    --cc=philmd@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).