From: Richard Henderson <richard.henderson@linaro.org>
To: qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Alex Bennée" <alex.bennee@linaro.org>
Subject: [PULL v2 12/14] accel/tcg: Rename tb_invalidate_phys_page_fast{, __locked}()
Date: Tue, 20 Dec 2022 21:03:11 -0800 [thread overview]
Message-ID: <20221221050313.2950701-13-richard.henderson@linaro.org> (raw)
In-Reply-To: <20221221050313.2950701-1-richard.henderson@linaro.org>
From: Philippe Mathieu-Daudé <philmd@linaro.org>
Emphasize this function is called with pages locked.
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20221209093649.43738-4-philmd@linaro.org>
[rth: Use "__locked" suffix, to match other instances.]
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
accel/tcg/internal.h | 6 +++---
accel/tcg/cputlb.c | 2 +-
accel/tcg/tb-maint.c | 6 +++---
3 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/accel/tcg/internal.h b/accel/tcg/internal.h
index 35419f3fe1..d10ab69ed0 100644
--- a/accel/tcg/internal.h
+++ b/accel/tcg/internal.h
@@ -37,9 +37,9 @@ void page_table_config_init(void);
#ifdef CONFIG_SOFTMMU
struct page_collection;
-void tb_invalidate_phys_page_fast(struct page_collection *pages,
- tb_page_addr_t start, int len,
- uintptr_t retaddr);
+void tb_invalidate_phys_page_fast__locked(struct page_collection *pages,
+ tb_page_addr_t start, int len,
+ uintptr_t retaddr);
struct page_collection *page_collection_lock(tb_page_addr_t start,
tb_page_addr_t end);
void page_collection_unlock(struct page_collection *set);
diff --git a/accel/tcg/cputlb.c b/accel/tcg/cputlb.c
index ac459478f4..f7963d3af8 100644
--- a/accel/tcg/cputlb.c
+++ b/accel/tcg/cputlb.c
@@ -1510,7 +1510,7 @@ static void notdirty_write(CPUState *cpu, vaddr mem_vaddr, unsigned size,
if (!cpu_physical_memory_get_dirty_flag(ram_addr, DIRTY_MEMORY_CODE)) {
struct page_collection *pages
= page_collection_lock(ram_addr, ram_addr + size);
- tb_invalidate_phys_page_fast(pages, ram_addr, size, retaddr);
+ tb_invalidate_phys_page_fast__locked(pages, ram_addr, size, retaddr);
page_collection_unlock(pages);
}
diff --git a/accel/tcg/tb-maint.c b/accel/tcg/tb-maint.c
index 1676d359f2..8edfd910c4 100644
--- a/accel/tcg/tb-maint.c
+++ b/accel/tcg/tb-maint.c
@@ -1190,9 +1190,9 @@ void tb_invalidate_phys_range(tb_page_addr_t start, tb_page_addr_t end)
*
* Call with all @pages in the range [@start, @start + len[ locked.
*/
-void tb_invalidate_phys_page_fast(struct page_collection *pages,
- tb_page_addr_t start, int len,
- uintptr_t retaddr)
+void tb_invalidate_phys_page_fast__locked(struct page_collection *pages,
+ tb_page_addr_t start, int len,
+ uintptr_t retaddr)
{
PageDesc *p;
--
2.34.1
next prev parent reply other threads:[~2022-12-21 5:09 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-21 5:02 [PULL v2 00/14] accel/tcg: Rewrite user-only vma tracking Richard Henderson
2022-12-21 5:03 ` [PULL v2 01/14] util: Add interval-tree.c Richard Henderson
2022-12-21 5:03 ` [PULL v2 02/14] accel/tcg: Rename page_flush_tb Richard Henderson
2022-12-21 5:03 ` [PULL v2 03/14] accel/tcg: Use interval tree for TBs in user-only mode Richard Henderson
2022-12-21 5:03 ` [PULL v2 04/14] accel/tcg: Use interval tree for TARGET_PAGE_DATA_SIZE Richard Henderson
2022-12-21 5:03 ` [PULL v2 05/14] accel/tcg: Drop PAGE_RESERVED for CONFIG_BSD Richard Henderson
2022-12-21 5:03 ` [PULL v2 06/14] accel/tcg: Move page_{get,set}_flags to user-exec.c Richard Henderson
2022-12-21 5:03 ` [PULL v2 07/14] accel/tcg: Use interval tree for user-only page tracking Richard Henderson
2022-12-23 14:32 ` Ilya Leoshkevich
2022-12-24 14:45 ` Richard Henderson
2022-12-21 5:03 ` [PULL v2 08/14] accel/tcg: Move PageDesc tree into tb-maint.c for system Richard Henderson
2022-12-21 5:03 ` [PULL v2 09/14] accel/tcg: Move remainder of page locking to tb-maint.c Richard Henderson
2022-12-21 5:03 ` [PULL v2 10/14] accel/tcg: Restrict cpu_io_recompile() to system emulation Richard Henderson
2022-12-21 5:03 ` [PULL v2 11/14] accel/tcg: Remove trace events from trace-root.h Richard Henderson
2022-12-21 5:03 ` Richard Henderson [this message]
2022-12-21 5:03 ` [PULL v2 13/14] accel/tcg: Factor tb_invalidate_phys_range_fast() out Richard Henderson
2022-12-21 5:03 ` [PULL v2 14/14] accel/tcg: Restrict page_collection structure to system TB maintainance Richard Henderson
2022-12-21 15:43 ` [PULL v2 00/14] accel/tcg: Rewrite user-only vma tracking Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221221050313.2950701-13-richard.henderson@linaro.org \
--to=richard.henderson@linaro.org \
--cc=alex.bennee@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).