qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Bernhard Beschow <shentey@gmail.com>
To: qemu-devel@nongnu.org
Cc: "Richard Henderson" <richard.henderson@linaro.org>,
	"Igor Mammedov" <imammedo@redhat.com>,
	"Aurelien Jarno" <aurelien@aurel32.net>,
	"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	qemu-block@nongnu.org, "Hervé Poussineau" <hpoussin@reactos.org>,
	"Jiaxun Yang" <jiaxun.yang@flygoat.com>,
	"Ani Sinha" <ani@anisinha.ca>, "John Snow" <jsnow@redhat.com>,
	"Gerd Hoffmann" <kraxel@redhat.com>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	"Eduardo Habkost" <eduardo@habkost.net>,
	"Philippe Mathieu-Daudé" <philmd@linaro.org>,
	"Marcel Apfelbaum" <marcel.apfelbaum@gmail.com>,
	"Bernhard Beschow" <shentey@gmail.com>
Subject: [PATCH v4 15/30] hw/isa/piix3: Wire up ACPI interrupt internally
Date: Wed, 21 Dec 2022 17:59:48 +0100	[thread overview]
Message-ID: <20221221170003.2929-16-shentey@gmail.com> (raw)
In-Reply-To: <20221221170003.2929-1-shentey@gmail.com>

Now that PIIX3 has the PIC integrated, the ACPI controller can be wired
up internally.

Signed-off-by: Bernhard Beschow <shentey@gmail.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Message-Id: <20221022150508.26830-18-shentey@gmail.com>
---
 hw/i386/pc_piix.c | 1 -
 hw/isa/piix3.c    | 2 ++
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c
index 8c3d3698eb..3ff84209fe 100644
--- a/hw/i386/pc_piix.c
+++ b/hw/i386/pc_piix.c
@@ -329,7 +329,6 @@ static void pc_init1(MachineState *machine,
     if (piix4_pm) {
         smi_irq = qemu_allocate_irq(pc_acpi_smi_interrupt, first_cpu, 0);
 
-        qdev_connect_gpio_out(DEVICE(piix4_pm), 0, x86ms->gsi[9]);
         qdev_connect_gpio_out_named(DEVICE(piix4_pm), "smi-irq", 0, smi_irq);
         pcms->smbus = I2C_BUS(qdev_get_child_bus(DEVICE(piix4_pm), "i2c"));
         /* TODO: Populate SPD eeprom data.  */
diff --git a/hw/isa/piix3.c b/hw/isa/piix3.c
index d6d36db01e..c33a3faa2f 100644
--- a/hw/isa/piix3.c
+++ b/hw/isa/piix3.c
@@ -343,6 +343,8 @@ static void pci_piix3_realize(PCIDevice *dev, Error **errp)
         if (!qdev_realize(DEVICE(&d->pm), BUS(pci_bus), errp)) {
             return;
         }
+        qdev_connect_gpio_out(DEVICE(&d->pm), 0,
+                              qdev_get_gpio_in(DEVICE(&d->pic), 9));
     }
 }
 
-- 
2.39.0



  parent reply	other threads:[~2022-12-21 17:05 UTC|newest]

Thread overview: 49+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-21 16:59 [PATCH v4 00/30] This series consolidates the implementations of the PIIX3 and PIIX4 south Bernhard Beschow
2022-12-21 16:59 ` [PATCH v4 01/30] hw/mips/malta: Introduce PIIX4_PCI_DEVFN definition Bernhard Beschow
2022-12-21 16:59 ` [PATCH v4 02/30] hw/mips/malta: Set PIIX4 IRQ routes in embedded bootloader Bernhard Beschow
2022-12-21 16:59 ` [PATCH v4 03/30] hw/isa/piix4: Correct IRQRC[A:D] reset values Bernhard Beschow
2022-12-21 16:59 ` [PATCH v4 04/30] hw/mips/Kconfig: Track Malta's PIIX dependencies via Kconfig Bernhard Beschow
2022-12-21 16:59 ` [PATCH v4 05/30] hw/usb/hcd-uhci: Introduce TYPE_ defines for device models Bernhard Beschow
2022-12-21 16:59 ` [PATCH v4 06/30] hw/i386/pc_piix: Associate pci_map_irq_fn as soon as PCI bus is created Bernhard Beschow
2023-01-04 19:42   ` Bernhard Beschow
2022-12-21 16:59 ` [PATCH v4 07/30] hw/i386/pc_piix: Allow for setting properties before realizing PIIX3 south bridge Bernhard Beschow
2022-12-21 16:59 ` [PATCH v4 08/30] hw/i386/pc: Create RTC controllers in south bridges Bernhard Beschow
2023-01-02 17:03   ` Thomas Huth
2023-01-02 18:25     ` Bernhard Beschow
2023-01-03  8:51       ` Thomas Huth
2022-12-21 16:59 ` [PATCH v4 09/30] hw/i386/pc: No need for rtc_state to be an out-parameter Bernhard Beschow
2023-01-03  8:52   ` Thomas Huth
2022-12-21 16:59 ` [PATCH v4 10/30] hw/isa/piix3: Create USB controller in host device Bernhard Beschow
2022-12-21 16:59 ` [PATCH v4 11/30] hw/isa/piix3: Create power management " Bernhard Beschow
2022-12-21 16:59 ` [PATCH v4 12/30] hw/core: Introduce proxy-pic Bernhard Beschow
2023-01-04 14:37   ` Philippe Mathieu-Daudé
2023-01-04 16:01     ` Bernhard Beschow
2023-01-04 16:35       ` Philippe Mathieu-Daudé
2023-01-04 16:51         ` Mark Cave-Ayland
2023-01-04 20:12         ` Bernhard Beschow
2023-01-04 20:31           ` Philippe Mathieu-Daudé
2023-01-04 20:57             ` Bernhard Beschow
2023-01-04 19:53   ` [PATCH] " Bernhard Beschow
2023-01-04 22:22     ` Mark Cave-Ayland
2023-01-05  9:50       ` Bernhard Beschow
2023-01-05 14:45         ` Bernhard Beschow
2022-12-21 16:59 ` [PATCH v4 13/30] hw/isa/piix3: Create Proxy PIC in host device Bernhard Beschow
2022-12-21 16:59 ` [PATCH v4 14/30] hw/isa/piix3: Create IDE controller " Bernhard Beschow
2022-12-21 16:59 ` Bernhard Beschow [this message]
2022-12-21 16:59 ` [PATCH v4 16/30] hw/isa/piix3: Resolve redundant PIIX_NUM_PIC_IRQS Bernhard Beschow
2022-12-21 16:59 ` [PATCH v4 17/30] hw/isa/piix3: Rename pci_piix3_props for sharing with PIIX4 Bernhard Beschow
2022-12-21 16:59 ` [PATCH v4 18/30] hw/isa/piix3: Rename piix3_reset() " Bernhard Beschow
2022-12-21 16:59 ` [PATCH v4 19/30] hw/isa/piix3: Drop the "3" from PIIX base class Bernhard Beschow
2022-12-21 16:59 ` [PATCH v4 20/30] hw/isa/piix4: Make PIIX4's ACPI and USB functions optional Bernhard Beschow
2022-12-21 16:59 ` [PATCH v4 21/30] hw/isa/piix4: Remove unused inbound ISA interrupt lines Bernhard Beschow
2022-12-21 16:59 ` [PATCH v4 22/30] hw/isa/piix4: Use Proxy PIC device Bernhard Beschow
2022-12-21 16:59 ` [PATCH v4 23/30] hw/isa/piix4: Reuse struct PIIXState from PIIX3 Bernhard Beschow
2022-12-21 16:59 ` [PATCH v4 24/30] hw/isa/piix4: Rename reset control operations to match PIIX3 Bernhard Beschow
2022-12-21 16:59 ` [PATCH v4 25/30] hw/isa/piix3: Merge hw/isa/piix4.c Bernhard Beschow
2022-12-21 16:59 ` [PATCH v4 26/30] hw/isa/piix: Harmonize names of reset control memory regions Bernhard Beschow
2022-12-21 17:00 ` [PATCH v4 27/30] hw/isa/piix: Reuse PIIX3 base class' realize method in PIIX4 Bernhard Beschow
2022-12-21 17:00 ` [PATCH v4 28/30] hw/isa/piix: Rename functions to be shared for interrupt triggering Bernhard Beschow
2022-12-21 17:00 ` [PATCH v4 29/30] hw/isa/piix: Consolidate IRQ triggering Bernhard Beschow
2022-12-21 17:00 ` [PATCH v4 30/30] hw/isa/piix: Share PIIX3's base class with PIIX4 Bernhard Beschow
2022-12-21 19:15 ` [PATCH v4 00/30] This series consolidates the implementations of the PIIX3 and PIIX4 south Philippe Mathieu-Daudé
2022-12-21 23:13   ` Bernhard Beschow

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221221170003.2929-16-shentey@gmail.com \
    --to=shentey@gmail.com \
    --cc=ani@anisinha.ca \
    --cc=aurelien@aurel32.net \
    --cc=eduardo@habkost.net \
    --cc=f4bug@amsat.org \
    --cc=hpoussin@reactos.org \
    --cc=imammedo@redhat.com \
    --cc=jiaxun.yang@flygoat.com \
    --cc=jsnow@redhat.com \
    --cc=kraxel@redhat.com \
    --cc=marcel.apfelbaum@gmail.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=philmd@linaro.org \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).