From: David Hildenbrand <david@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Igor Mammedov" <imammedo@redhat.com>,
"Michael S . Tsirkin" <mst@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"David Hildenbrand" <david@redhat.com>,
"Chenyi Qiang" <chenyi.qiang@intel.com>,
"Michal Privoznik" <mprivozn@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
qemu-stable@nongnu.org
Subject: [GIT PULL 2/4] virtio-mem: Fix the iterator variable in a vmem->rdl_list loop
Date: Mon, 2 Jan 2023 12:29:19 +0100 [thread overview]
Message-ID: <20230102112921.68077-3-david@redhat.com> (raw)
In-Reply-To: <20230102112921.68077-1-david@redhat.com>
From: Chenyi Qiang <chenyi.qiang@intel.com>
It should be the variable rdl2 to revert the already-notified listeners.
Fixes: 2044969f0b ("virtio-mem: Implement RamDiscardManager interface")
Signed-off-by: Chenyi Qiang <chenyi.qiang@intel.com>
Message-Id: <20221228090312.17276-1-chenyi.qiang@intel.com>
Cc: qemu-stable@nongnu.org
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Signed-off-by: David Hildenbrand <david@redhat.com>
---
hw/virtio/virtio-mem.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/virtio/virtio-mem.c b/hw/virtio/virtio-mem.c
index 5c22c4b876..2b0271442b 100644
--- a/hw/virtio/virtio-mem.c
+++ b/hw/virtio/virtio-mem.c
@@ -341,7 +341,7 @@ static int virtio_mem_notify_plug(VirtIOMEM *vmem, uint64_t offset,
if (ret) {
/* Notify all already-notified listeners. */
QLIST_FOREACH(rdl2, &vmem->rdl_list, next) {
- MemoryRegionSection tmp = *rdl->section;
+ MemoryRegionSection tmp = *rdl2->section;
if (rdl2 == rdl) {
break;
--
2.39.0
next prev parent reply other threads:[~2023-01-02 11:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-02 11:29 [GIT PULL 0/4] Host Memory Backends and Memory devices queue 2023-01-02 David Hildenbrand
2023-01-02 11:29 ` [GIT PULL 1/4] virtio-mem: Fix the bitmap index of the section offset David Hildenbrand
2023-01-02 11:29 ` David Hildenbrand [this message]
2023-01-02 11:29 ` [GIT PULL 3/4] virtio-mem: Fix typo in function name David Hildenbrand
2023-01-02 11:29 ` [GIT PULL 4/4] hostmem: Honor multiple preferred nodes if possible David Hildenbrand
2023-01-05 16:58 ` [GIT PULL 0/4] Host Memory Backends and Memory devices queue 2023-01-02 Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230102112921.68077-3-david@redhat.com \
--to=david@redhat.com \
--cc=chenyi.qiang@intel.com \
--cc=imammedo@redhat.com \
--cc=mprivozn@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).