From: Igor Mammedov <imammedo@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>
Cc: Laszlo Ersek <lersek@redhat.com>,
qemu devel list <qemu-devel@nongnu.org>,
"Michael S. Tsirkin" <mst@redhat.com>,
Ani Sinha <ani@anisinha.ca>, Ard Biesheuvel <ardb@kernel.org>,
Paolo Bonzini <pbonzini@redhat.com>,
Peter Maydell <peter.maydell@linaro.org>,
qemu-stable@nongnu.org, Zhu Guihua <zhugh.fnst@cn.fujitsu.com>,
Gu Zheng <guz.fnst@cn.fujitsu.com>,
Li Zhijian <lizhijian@cn.fujitsu.com>
Subject: Re: [PATCH] acpi: cpuhp: fix guest-visible maximum access size to the legacy reg block
Date: Wed, 4 Jan 2023 11:38:22 +0100 [thread overview]
Message-ID: <20230104113822.35d23254@imammedo.users.ipa.redhat.com> (raw)
In-Reply-To: <e81f78e2-301e-d920-cd03-6e17c591d677@linaro.org>
On Wed, 4 Jan 2023 10:34:09 +0100
Philippe Mathieu-Daudé <philmd@linaro.org> wrote:
> On 4/1/23 10:01, Laszlo Ersek wrote:
[...]
> > diff --git a/hw/acpi/cpu_hotplug.c b/hw/acpi/cpu_hotplug.c
> > index 53654f863830..ff14c3f4106f 100644
> > --- a/hw/acpi/cpu_hotplug.c
> > +++ b/hw/acpi/cpu_hotplug.c
> > @@ -52,6 +52,9 @@ static const MemoryRegionOps AcpiCpuHotplug_ops = {
> > .endianness = DEVICE_LITTLE_ENDIAN,
> > .valid = {
> > .min_access_size = 1,
> > + .max_access_size = 4,
> > + },
> > + .impl = {
> > .max_access_size = 1,
>
> Arguably:
> Fixes: b8622725cf ("acpi_piix4: Add infrastructure to send CPU hot-plug
> GPE to guest")
nope, this one is correct, as legacy interface used 1 byte access only
>
> > },
> > };
next prev parent reply other threads:[~2023-01-04 10:39 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-04 9:01 [PATCH] acpi: cpuhp: fix guest-visible maximum access size to the legacy reg block Laszlo Ersek
2023-01-04 9:33 ` Ard Biesheuvel
2023-01-04 10:26 ` Laszlo Ersek
2023-01-04 9:34 ` Philippe Mathieu-Daudé
2023-01-04 10:29 ` Laszlo Ersek
2023-01-04 10:38 ` Igor Mammedov [this message]
2023-01-04 12:27 ` Philippe Mathieu-Daudé
2023-01-04 10:35 ` Igor Mammedov
2023-01-04 12:13 ` Laszlo Ersek
2023-01-04 12:35 ` Michael S. Tsirkin
2023-01-05 7:13 ` Laszlo Ersek
2023-01-05 9:00 ` Philippe Mathieu-Daudé
2023-01-05 9:51 ` Michael S. Tsirkin
2023-03-01 7:17 ` Christian Ehrhardt
2023-03-01 8:03 ` Laszlo Ersek
2023-03-02 8:32 ` Christian Ehrhardt
2023-03-02 10:38 ` Laszlo Ersek
-- strict thread matches above, loose matches on Subject: below --
2023-01-05 16:18 Laszlo Ersek
2023-01-05 16:21 ` Laszlo Ersek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230104113822.35d23254@imammedo.users.ipa.redhat.com \
--to=imammedo@redhat.com \
--cc=ani@anisinha.ca \
--cc=ardb@kernel.org \
--cc=guz.fnst@cn.fujitsu.com \
--cc=lersek@redhat.com \
--cc=lizhijian@cn.fujitsu.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
--cc=zhugh.fnst@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).