qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Bernhard Beschow <shentey@gmail.com>
To: qemu-devel@nongnu.org
Cc: "Richard Henderson" <richard.henderson@linaro.org>,
	"Stefano Stabellini" <sstabellini@kernel.org>,
	xen-devel@lists.xenproject.org,
	"Hervé Poussineau" <hpoussin@reactos.org>,
	"Aurelien Jarno" <aurelien@aurel32.net>,
	"Paul Durrant" <paul@xen.org>,
	"Marcel Apfelbaum" <marcel.apfelbaum@gmail.com>,
	"Anthony Perard" <anthony.perard@citrix.com>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Eduardo Habkost" <eduardo@habkost.net>,
	"Philippe Mathieu-Daudé" <philmd@linaro.org>,
	"Chuck Zmudzinski" <brchuckz@aol.com>,
	"Bernhard Beschow" <shentey@gmail.com>
Subject: [PATCH v2 5/6] hw/isa/piix: Resolve redundant k->config_write assignments
Date: Wed,  4 Jan 2023 15:44:36 +0100	[thread overview]
Message-ID: <20230104144437.27479-6-shentey@gmail.com> (raw)
In-Reply-To: <20230104144437.27479-1-shentey@gmail.com>

The previous patch unified handling of piix_write_config() accross all
PIIX device models which allows for assigning k->config_write once in the
base class.

Signed-off-by: Bernhard Beschow <shentey@gmail.com>
---
 hw/isa/piix.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/hw/isa/piix.c b/hw/isa/piix.c
index d4cdb3dadb..98e9b12661 100644
--- a/hw/isa/piix.c
+++ b/hw/isa/piix.c
@@ -396,6 +396,7 @@ static void pci_piix_class_init(ObjectClass *klass, void *data)
     PCIDeviceClass *k = PCI_DEVICE_CLASS(klass);
     AcpiDevAmlIfClass *adevc = ACPI_DEV_AML_IF_CLASS(klass);
 
+    k->config_write = piix_write_config;
     dc->reset       = piix_reset;
     dc->desc        = "ISA bridge";
     dc->hotpluggable   = false;
@@ -451,7 +452,6 @@ static void piix3_class_init(ObjectClass *klass, void *data)
     DeviceClass *dc = DEVICE_CLASS(klass);
     PCIDeviceClass *k = PCI_DEVICE_CLASS(klass);
 
-    k->config_write = piix_write_config;
     k->realize = piix3_realize;
     /* 82371SB PIIX3 PCI-to-ISA bridge (Step A1) */
     k->device_id = PCI_DEVICE_ID_INTEL_82371SB_0;
@@ -470,7 +470,6 @@ static void piix3_xen_class_init(ObjectClass *klass, void *data)
     DeviceClass *dc = DEVICE_CLASS(klass);
     PCIDeviceClass *k = PCI_DEVICE_CLASS(klass);
 
-    k->config_write = piix_write_config;
     k->realize = piix3_realize;
     /* 82371SB PIIX3 PCI-to-ISA bridge (Step A1) */
     k->device_id = PCI_DEVICE_ID_INTEL_82371SB_0;
@@ -519,7 +518,6 @@ static void piix4_class_init(ObjectClass *klass, void *data)
     DeviceClass *dc = DEVICE_CLASS(klass);
     PCIDeviceClass *k = PCI_DEVICE_CLASS(klass);
 
-    k->config_write = piix_write_config;
     k->realize = piix4_realize;
     k->device_id = PCI_DEVICE_ID_INTEL_82371AB_0;
     dc->vmsd = &vmstate_piix4;
-- 
2.39.0



  parent reply	other threads:[~2023-01-04 14:47 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-04 14:44 [PATCH v2 0/6] Resolve TYPE_PIIX3_XEN_DEVICE Bernhard Beschow
2023-01-04 14:44 ` [PATCH v2 1/6] include/hw/xen/xen: Rename xen_piix3_set_irq() to xen_intx_set_irq() Bernhard Beschow
2023-01-04 15:17   ` Philippe Mathieu-Daudé
2023-01-04 14:44 ` [PATCH v2 2/6] hw/isa/piix: Reuse piix3_realize() in piix3_xen_realize() Bernhard Beschow
2023-01-04 14:44 ` [PATCH v2 3/6] hw/isa/piix: Wire up Xen PCI IRQ handling outside of PIIX3 Bernhard Beschow
2023-01-04 15:18   ` Philippe Mathieu-Daudé
2023-01-06 17:35   ` David Woodhouse
2023-01-06 17:46     ` Chuck Zmudzinski
2023-01-06 18:39       ` Chuck Zmudzinski
2023-01-07 10:58     ` Bernhard Beschow
2023-01-04 14:44 ` [PATCH v2 4/6] hw/isa/piix: Avoid Xen-specific variant of piix_write_config() Bernhard Beschow
2023-01-04 14:44 ` Bernhard Beschow [this message]
2023-01-04 15:19   ` [PATCH v2 5/6] hw/isa/piix: Resolve redundant k->config_write assignments Philippe Mathieu-Daudé
2023-01-04 14:44 ` [PATCH v2 6/6] hw/isa/piix: Resolve redundant TYPE_PIIX3_XEN_DEVICE Bernhard Beschow
2023-01-04 15:35   ` Philippe Mathieu-Daudé
2023-01-04 17:54     ` Chuck Zmudzinski
2023-01-04 18:48       ` Philippe Mathieu-Daudé
2023-01-04 19:29         ` Chuck Zmudzinski
2023-01-04 20:31           ` Bernhard Beschow
2023-01-04 20:57             ` Chuck Zmudzinski
2023-01-04 22:18           ` Philippe Mathieu-Daudé
2023-01-05  2:34             ` Chuck Zmudzinski
2023-01-04 20:44       ` Bernhard Beschow
2023-01-04 20:50         ` Chuck Zmudzinski
2023-01-06 11:57     ` Bernhard Beschow
2023-01-06 12:25       ` Philippe Mathieu-Daudé
2023-01-06 19:08         ` Chuck Zmudzinski
2023-01-06 23:04           ` Chuck Zmudzinski
2023-01-07  1:08             ` Chuck Zmudzinski
2023-01-07 11:05               ` Bernhard Beschow
2023-01-07 18:08                 ` Chuck Zmudzinski
2023-01-04 16:42   ` Chuck Zmudzinski
2023-01-04 19:45     ` Bernhard Beschow
2023-01-04 22:35     ` Philippe Mathieu-Daudé
2023-01-05  1:57       ` Chuck Zmudzinski
2023-01-05  2:25       ` Chuck Zmudzinski
2023-01-17 22:51 ` [PATCH v2 0/6] Resolve TYPE_PIIX3_XEN_DEVICE Bernhard Beschow
2023-01-18 10:13 ` Michael S. Tsirkin
2023-01-24 16:11   ` Anthony PERARD via
2023-01-24 17:07     ` Bernhard Beschow
2023-02-01  8:11       ` Bernhard Beschow
2023-02-09 21:53         ` Bernhard Beschow
2023-03-11 22:20           ` Chuck Zmudzinski
2023-03-12  9:22             ` Bernhard Beschow
2023-03-12 21:02               ` Chuck Zmudzinski
2023-03-12 22:46                 ` Bernhard Beschow

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230104144437.27479-6-shentey@gmail.com \
    --to=shentey@gmail.com \
    --cc=anthony.perard@citrix.com \
    --cc=aurelien@aurel32.net \
    --cc=brchuckz@aol.com \
    --cc=eduardo@habkost.net \
    --cc=hpoussin@reactos.org \
    --cc=marcel.apfelbaum@gmail.com \
    --cc=mst@redhat.com \
    --cc=paul@xen.org \
    --cc=pbonzini@redhat.com \
    --cc=philmd@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    --cc=sstabellini@kernel.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).