From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 01434C3DA7D for ; Thu, 5 Jan 2023 16:22:21 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pDT0K-00038f-DX; Thu, 05 Jan 2023 11:22:08 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pDT0G-00034f-8w for qemu-devel@nongnu.org; Thu, 05 Jan 2023 11:22:04 -0500 Received: from [163.114.132.7] (helo=pdel-mbp.localdomain) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pDT0E-0004hB-Fy for qemu-devel@nongnu.org; Thu, 05 Jan 2023 11:22:03 -0500 Received: by pdel-mbp.localdomain (Postfix, from userid 501) id 1CD6CC3BBBF; Thu, 5 Jan 2023 01:13:49 -0800 (PST) From: Peter Delevoryas To: Cc: samuel.thibault@ens-lyon.org, jasowang@redhat.com, eblake@redhat.com, armbru@redhat.com, qemu-devel@nongnu.org, Peter Delevoryas Subject: [PATCH 0/1] net/slirp: Add mfr-id and oob-eth-addr parameters Date: Thu, 5 Jan 2023 01:13:44 -0800 Message-Id: <20230105091345.49757-1-peter@pjd.dev> X-Mailer: git-send-email 2.39.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Host-Lookup-Failed: Reverse DNS lookup failed for 163.114.132.7 (failed) Received-SPF: none client-ip=163.114.132.7; envelope-from=pdel@pdel-mbp.localdomain; helo=pdel-mbp.localdomain X-Spam_score_int: -8 X-Spam_score: -0.9 X-Spam_bar: / X-Spam_report: (-0.9 / 5.0 requ) BAYES_00=-1.9, HEADER_FROM_DIFFERENT_DOMAINS=0.25, NO_DNS_FOR_FROM=0.001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org This adds mfr-id and oob-eth-addr parameters to the userspace netdev backend. -netdev user,id=[str],mfr-id=[uint32],oob-eth-addr=[MAC address] I introduced mfr-id and oob-eth-addr to slirp a while ago, as part of Slirp config version 5, but never managed to get the options exposed in upstream QEMU (I've just been maintaining my own patches). This is useful for testing NC-SI OEM commands, which are critical for bringing up the network path for lots of BMC's in data centers. So like, OpenBMC devs would be interested in this. I tried to submit this change a long time ago, but failed cause I wasn't sure exactly how to gate this on the slirp version. My strategy was actually not to use the slirp version (e.g. 4.7.0) to check for this, but to use the slirp config version. This is different, but correct, I think? If we don't use the slirp config version, we have to create a new slirp release, 4.8.0. But, I don't see the point of that, because we already have a version number exposed for the SlirpConfig. Thanks, Peter Peter Delevoryas (1): net/slirp: Add mfr-id and oob-eth-addr parameters net/slirp.c | 19 ++++++++++++++++--- qapi/net.json | 9 ++++++++- 2 files changed, 24 insertions(+), 4 deletions(-) -- 2.31.1