From: Richard Henderson <richard.henderson@linaro.org>
To: qemu-devel@nongnu.org
Cc: qemu-arm@nongnu.org
Subject: [PATCH 0/2] target/arm: Look up ARMCPRegInfo at runtime
Date: Fri, 6 Jan 2023 11:44:49 -0800 [thread overview]
Message-ID: <20230106194451.1213153-1-richard.henderson@linaro.org> (raw)
Here's a short-to-medium term alternative to moving all of the ARMCPU
cp_regs hash table to the ARMCPUClass, so that we're no longer leaving
dangling pointers to freed objects encoded in the compiled
TranslationBlocks. (I still think we ought to do less work at
object_{init,realize}, but that may be a much longer term project.)
Instead of giving the helper a direct pointer, pass the cpreg hash key,
which will be constant across cpus. Perform this lookup in the existing
helper_access_check_cp_reg (which had a return value going spare), or a
new helper_lookup_cp_reg. The other cp_regs functions are unchanged,
because they still get a pointer.
This ought to be enough to re-instate Alex's linux-user patch
to free the cpu object after thread termination.
r~
Richard Henderson (2):
target/arm: Reorg do_coproc_insn
target/arm: Look up ARMCPRegInfo at runtime
target/arm/helper.h | 11 +-
target/arm/translate.h | 7 +
target/arm/op_helper.c | 27 ++-
target/arm/translate-a64.c | 49 +++--
target/arm/translate.c | 430 +++++++++++++++++++------------------
5 files changed, 285 insertions(+), 239 deletions(-)
--
2.34.1
next reply other threads:[~2023-01-06 19:46 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-06 19:44 Richard Henderson [this message]
2023-01-06 19:44 ` [PATCH 1/2] target/arm: Reorg do_coproc_insn Richard Henderson
2023-01-17 15:42 ` Alex Bennée
2023-01-06 19:44 ` [PATCH 2/2] target/arm: Look up ARMCPRegInfo at runtime Richard Henderson
2023-01-23 12:53 ` Peter Maydell
2023-01-24 0:20 ` Richard Henderson
2023-01-24 9:48 ` Peter Maydell
2023-01-24 10:39 ` Alex Bennée
2023-01-16 20:16 ` [PATCH 0/2] " Richard Henderson
2023-01-17 10:28 ` Peter Maydell
2023-01-17 15:20 ` Richard Henderson
2023-01-23 12:55 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230106194451.1213153-1-richard.henderson@linaro.org \
--to=richard.henderson@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).