* Re: [PATCH] hw/display/xlnx_dp: fix overflow in xlnx_dp_aux_push_tx_fifo()
2023-01-09 5:59 [PATCH] hw/display/xlnx_dp: fix overflow in xlnx_dp_aux_push_tx_fifo() Qiang Liu
@ 2023-01-09 22:58 ` Alistair Francis
2023-01-10 12:02 ` Edgar E. Iglesias
2023-01-10 13:57 ` Konrad, Frederic
2 siblings, 0 replies; 5+ messages in thread
From: Alistair Francis @ 2023-01-09 22:58 UTC (permalink / raw)
To: Qiang Liu
Cc: qemu-devel, Alistair Francis, Edgar E. Iglesias, Peter Maydell,
open list:Xilinx ZynqMP and...
On Mon, Jan 9, 2023 at 4:01 PM Qiang Liu <cyruscyliu@gmail.com> wrote:
>
> This patch checks if the s->tx_fifo is full.
>
> Fixes: 58ac482a66de ("introduce xlnx-dp")
> Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1424
> Reported-by: Qiang Liu <cyruscyliu@gmail.com>
> Signed-off-by: Qiang Liu <cyruscyliu@gmail.com>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Alistair
> ---
> hw/display/xlnx_dp.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/hw/display/xlnx_dp.c b/hw/display/xlnx_dp.c
> index 972473d94f..617b394af2 100644
> --- a/hw/display/xlnx_dp.c
> +++ b/hw/display/xlnx_dp.c
> @@ -854,7 +854,11 @@ static void xlnx_dp_write(void *opaque, hwaddr offset, uint64_t value,
> break;
> case DP_AUX_WRITE_FIFO: {
> uint8_t c = value;
> - xlnx_dp_aux_push_tx_fifo(s, &c, 1);
> + if (fifo8_is_full(&s->tx_fifo)) {
> + qemu_log_mask(LOG_GUEST_ERROR, "xlnx_dp: TX fifo is full");
> + } else {
> + xlnx_dp_aux_push_tx_fifo(s, &c, 1);
> + }
> break;
> }
> case DP_AUX_CLOCK_DIVIDER:
> --
> 2.25.1
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] hw/display/xlnx_dp: fix overflow in xlnx_dp_aux_push_tx_fifo()
2023-01-09 5:59 [PATCH] hw/display/xlnx_dp: fix overflow in xlnx_dp_aux_push_tx_fifo() Qiang Liu
2023-01-09 22:58 ` Alistair Francis
@ 2023-01-10 12:02 ` Edgar E. Iglesias
2023-01-10 13:57 ` Konrad, Frederic
2 siblings, 0 replies; 5+ messages in thread
From: Edgar E. Iglesias @ 2023-01-10 12:02 UTC (permalink / raw)
To: Qiang Liu
Cc: qemu-devel, Alistair Francis, Peter Maydell,
open list:Xilinx ZynqMP and..., Frederic Konrad
On Mon, Jan 09, 2023 at 01:59:33PM +0800, Qiang Liu wrote:
> This patch checks if the s->tx_fifo is full.
+ CC: Fred
Reviewed-by: Edgar E. Iglesias <edgar@zeroasic.com>
>
> Fixes: 58ac482a66de ("introduce xlnx-dp")
> Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1424
> Reported-by: Qiang Liu <cyruscyliu@gmail.com>
> Signed-off-by: Qiang Liu <cyruscyliu@gmail.com>
> ---
> hw/display/xlnx_dp.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/hw/display/xlnx_dp.c b/hw/display/xlnx_dp.c
> index 972473d94f..617b394af2 100644
> --- a/hw/display/xlnx_dp.c
> +++ b/hw/display/xlnx_dp.c
> @@ -854,7 +854,11 @@ static void xlnx_dp_write(void *opaque, hwaddr offset, uint64_t value,
> break;
> case DP_AUX_WRITE_FIFO: {
> uint8_t c = value;
> - xlnx_dp_aux_push_tx_fifo(s, &c, 1);
> + if (fifo8_is_full(&s->tx_fifo)) {
> + qemu_log_mask(LOG_GUEST_ERROR, "xlnx_dp: TX fifo is full");
> + } else {
> + xlnx_dp_aux_push_tx_fifo(s, &c, 1);
> + }
> break;
> }
> case DP_AUX_CLOCK_DIVIDER:
> --
> 2.25.1
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread* RE: [PATCH] hw/display/xlnx_dp: fix overflow in xlnx_dp_aux_push_tx_fifo()
2023-01-09 5:59 [PATCH] hw/display/xlnx_dp: fix overflow in xlnx_dp_aux_push_tx_fifo() Qiang Liu
2023-01-09 22:58 ` Alistair Francis
2023-01-10 12:02 ` Edgar E. Iglesias
@ 2023-01-10 13:57 ` Konrad, Frederic
2023-01-11 2:01 ` Qiang Liu
2 siblings, 1 reply; 5+ messages in thread
From: Konrad, Frederic @ 2023-01-10 13:57 UTC (permalink / raw)
To: Qiang Liu, qemu-devel@nongnu.org
Cc: Alistair Francis, Edgar E. Iglesias, Peter Maydell,
open list:Xilinx ZynqMP and...
Hi,
> -----Original Message-----
> From: qemu-devel-bounces+fkonrad=amd.com@nongnu.org <qemu-devel-bounces+fkonrad=amd.com@nongnu.org> On Behalf Of
> Qiang Liu
> Sent: 09 January 2023 07:00
> To: qemu-devel@nongnu.org
> Cc: Qiang Liu <cyruscyliu@gmail.com>; Alistair Francis <alistair@alistair23.me>; Edgar E. Iglesias <edgar.iglesias@gmail.com>; Peter
> Maydell <peter.maydell@linaro.org>; open list:Xilinx ZynqMP and... <qemu-arm@nongnu.org>
> Subject: [PATCH] hw/display/xlnx_dp: fix overflow in xlnx_dp_aux_push_tx_fifo()
>
> This patch checks if the s->tx_fifo is full.
>
> Fixes: 58ac482a66de ("introduce xlnx-dp")
> Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1424
> Reported-by: Qiang Liu <cyruscyliu@gmail.com>
> Signed-off-by: Qiang Liu <cyruscyliu@gmail.com>
> ---
> hw/display/xlnx_dp.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/hw/display/xlnx_dp.c b/hw/display/xlnx_dp.c
> index 972473d94f..617b394af2 100644
> --- a/hw/display/xlnx_dp.c
> +++ b/hw/display/xlnx_dp.c
> @@ -854,7 +854,11 @@ static void xlnx_dp_write(void *opaque, hwaddr offset, uint64_t value,
> break;
> case DP_AUX_WRITE_FIFO: {
> uint8_t c = value;
> - xlnx_dp_aux_push_tx_fifo(s, &c, 1);
> + if (fifo8_is_full(&s->tx_fifo)) {
> + qemu_log_mask(LOG_GUEST_ERROR, "xlnx_dp: TX fifo is full");
> + } else {
> + xlnx_dp_aux_push_tx_fifo(s, &c, 1);
> + }
I'd rather move the check in xlnx_dp_aux_push_tx_fifo, like xlnx_dp_aux_pop_tx_fifo.
Otherwise looks good to me.
Thanks,
Fred
> break;
> }
> case DP_AUX_CLOCK_DIVIDER:
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] hw/display/xlnx_dp: fix overflow in xlnx_dp_aux_push_tx_fifo()
2023-01-10 13:57 ` Konrad, Frederic
@ 2023-01-11 2:01 ` Qiang Liu
0 siblings, 0 replies; 5+ messages in thread
From: Qiang Liu @ 2023-01-11 2:01 UTC (permalink / raw)
To: Konrad, Frederic
Cc: qemu-devel@nongnu.org, Alistair Francis, Edgar E. Iglesias,
Peter Maydell, open list:Xilinx ZynqMP and...
[-- Attachment #1: Type: text/plain, Size: 1808 bytes --]
Dear Fred,
On Tue, Jan 10, 2023 at 9:57 PM Konrad, Frederic <Frederic.Konrad@amd.com>
wrote:
> Hi,
>
> > -----Original Message-----
> > From: qemu-devel-bounces+fkonrad=amd.com@nongnu.org
> <qemu-devel-bounces+fkonrad=amd.com@nongnu.org> On Behalf Of
> > Qiang Liu
> > Sent: 09 January 2023 07:00
> > To: qemu-devel@nongnu.org
> > Cc: Qiang Liu <cyruscyliu@gmail.com>; Alistair Francis <
> alistair@alistair23.me>; Edgar E. Iglesias <edgar.iglesias@gmail.com>;
> Peter
> > Maydell <peter.maydell@linaro.org>; open list:Xilinx ZynqMP and... <
> qemu-arm@nongnu.org>
> > Subject: [PATCH] hw/display/xlnx_dp: fix overflow in
> xlnx_dp_aux_push_tx_fifo()
> >
> > This patch checks if the s->tx_fifo is full.
> >
> > Fixes: 58ac482a66de ("introduce xlnx-dp")
> > Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1424
> > Reported-by: Qiang Liu <cyruscyliu@gmail.com>
> > Signed-off-by: Qiang Liu <cyruscyliu@gmail.com>
> > ---
> > hw/display/xlnx_dp.c | 6 +++++-
> > 1 file changed, 5 insertions(+), 1 deletion(-)
> >
> > diff --git a/hw/display/xlnx_dp.c b/hw/display/xlnx_dp.c
> > index 972473d94f..617b394af2 100644
> > --- a/hw/display/xlnx_dp.c
> > +++ b/hw/display/xlnx_dp.c
> > @@ -854,7 +854,11 @@ static void xlnx_dp_write(void *opaque, hwaddr
> offset, uint64_t value,
> > break;
> > case DP_AUX_WRITE_FIFO: {
> > uint8_t c = value;
> > - xlnx_dp_aux_push_tx_fifo(s, &c, 1);
> > + if (fifo8_is_full(&s->tx_fifo)) {
> > + qemu_log_mask(LOG_GUEST_ERROR, "xlnx_dp: TX fifo is full");
> > + } else {
> > + xlnx_dp_aux_push_tx_fifo(s, &c, 1);
> > + }
>
> I'd rather move the check in xlnx_dp_aux_push_tx_fifo, like
> xlnx_dp_aux_pop_tx_fifo.
> Otherwise looks good to me.
>
Sounds fine. Let me resend a patch.
Best,
Qiang
[-- Attachment #2: Type: text/html, Size: 3186 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread