qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: qemu-devel@nongnu.org
Cc: "Edgar E. Iglesias" <edgar.iglesias@gmail.com>,
	"Yoshinori Sato" <ysato@users.sourceforge.jp>,
	"Aurelien Jarno" <aurelien@aurel32.net>,
	"Philippe Mathieu-Daudé" <philmd@linaro.org>,
	"Jiaxun Yang" <jiaxun.yang@flygoat.com>,
	"Magnus Damm" <magnus.damm@gmail.com>,
	qemu-ppc@nongnu.org, "BALATON Zoltan" <balaton@eik.bme.hu>
Subject: [PATCH 3/5] hw/mips/malta: Add the FLASH_SECTOR_SIZE definition
Date: Mon,  9 Jan 2023 13:01:52 +0100	[thread overview]
Message-ID: <20230109120154.2868-4-philmd@linaro.org> (raw)
In-Reply-To: <20230109120154.2868-1-philmd@linaro.org>

Ease code review by using the IEC binary prefix definition
for the FLASH_SIZE.

Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
 hw/mips/malta.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/hw/mips/malta.c b/hw/mips/malta.c
index c0a2e0ab04..e645ba1322 100644
--- a/hw/mips/malta.c
+++ b/hw/mips/malta.c
@@ -69,7 +69,8 @@
 #define FPGA_ADDRESS        0x1f000000ULL
 #define RESET_ADDRESS       0x1fc00000ULL
 
-#define FLASH_SIZE          0x400000
+#define FLASH_SIZE          (4 * MiB)
+#define FLASH_SECTOR_SIZE   (64 * KiB)
 
 typedef struct {
     MemoryRegion iomem;
@@ -1289,7 +1290,7 @@ void mips_malta_init(MachineState *machine)
     fl = pflash_cfi01_register(FLASH_ADDRESS, "mips_malta.bios",
                                FLASH_SIZE,
                                dinfo ? blk_by_legacy_dinfo(dinfo) : NULL,
-                               65536,
+                               FLASH_SECTOR_SIZE,
                                4, 0x0000, 0x0000, 0x0000, 0x0000, be);
     bios = pflash_cfi01_get_memory(fl);
     fl_idx++;
-- 
2.38.1



  parent reply	other threads:[~2023-01-09 12:59 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-09 12:01 [PATCH 0/5] hw: Cleanups around PFLASH use Philippe Mathieu-Daudé
2023-01-09 12:01 ` [PATCH 1/5] hw/ppc/sam460ex: Remove unreachable code calling pflash_cfi01_register() Philippe Mathieu-Daudé
2023-01-09 12:38   ` BALATON Zoltan
2023-01-09 16:42   ` Bernhard Beschow
2023-01-09 16:51     ` Philippe Mathieu-Daudé
2023-01-09 12:01 ` [PATCH 2/5] hw/microblaze/petalogix: Add FLASH_SECTOR_SIZE definitions Philippe Mathieu-Daudé
2023-01-09 12:01 ` Philippe Mathieu-Daudé [this message]
2023-01-09 12:01 ` [PATCH 4/5] hw/sh4/r2d: Use the IEC binary prefix definitions Philippe Mathieu-Daudé
2023-01-09 12:46   ` BALATON Zoltan
2023-01-09 13:12     ` Philippe Mathieu-Daudé
2023-01-09 14:02       ` BALATON Zoltan
2023-01-09 12:01 ` [PATCH 5/5] hw/sh4/r2d: Add the FLASH_SECTOR_SIZE definition Philippe Mathieu-Daudé
2023-01-09 12:49   ` BALATON Zoltan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230109120154.2868-4-philmd@linaro.org \
    --to=philmd@linaro.org \
    --cc=aurelien@aurel32.net \
    --cc=balaton@eik.bme.hu \
    --cc=edgar.iglesias@gmail.com \
    --cc=jiaxun.yang@flygoat.com \
    --cc=magnus.damm@gmail.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    --cc=ysato@users.sourceforge.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).