qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Markus Armbruster <armbru@redhat.com>
To: qemu-devel@nongnu.org
Cc: kraxel@redhat.com, dgilbert@redhat.com, berrange@redhat.com,
	philmd@linaro.org
Subject: [PATCH v4 03/17] ui/spice: Require spice-protocol >= 0.14.0
Date: Mon,  9 Jan 2023 20:03:07 +0100	[thread overview]
Message-ID: <20230109190321.1056914-4-armbru@redhat.com> (raw)
In-Reply-To: <20230109190321.1056914-1-armbru@redhat.com>

Version 0.14.0 is now old enough to have made it into the major
distributions:

   Debian 11: 0.14.3
   RHEL-8: 0.14.2
   FreeBSD (ports): 0.14.4
   Fedora 35: 0.14.0
   Ubuntu 20.04: 0.14.0
   OpenSUSE Leap 15.3: 0.14.3

Requiring it lets us drop two version checks in ui/vdagent.c.  It also
enables the next commit.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
---
 meson.build  | 2 +-
 ui/vdagent.c | 4 ----
 2 files changed, 1 insertion(+), 5 deletions(-)

diff --git a/meson.build b/meson.build
index 175517eafd..8fabfbcf95 100644
--- a/meson.build
+++ b/meson.build
@@ -742,7 +742,7 @@ endif
 
 spice_protocol = not_found
 if not get_option('spice_protocol').auto() or have_system
-  spice_protocol = dependency('spice-protocol', version: '>=0.12.3',
+  spice_protocol = dependency('spice-protocol', version: '>=0.14.0',
                               required: get_option('spice_protocol'),
                               method: 'pkg-config', kwargs: static_kwargs)
 endif
diff --git a/ui/vdagent.c b/ui/vdagent.c
index 4bf50f0c4d..1f51a78da1 100644
--- a/ui/vdagent.c
+++ b/ui/vdagent.c
@@ -87,9 +87,7 @@ static const char *cap_name[] = {
     [VD_AGENT_CAP_MONITORS_CONFIG_POSITION]       = "monitors-config-position",
     [VD_AGENT_CAP_FILE_XFER_DISABLED]             = "file-xfer-disabled",
     [VD_AGENT_CAP_FILE_XFER_DETAILED_ERRORS]      = "file-xfer-detailed-errors",
-#if CHECK_SPICE_PROTOCOL_VERSION(0, 14, 0)
     [VD_AGENT_CAP_GRAPHICS_DEVICE_INFO]           = "graphics-device-info",
-#endif
 #if CHECK_SPICE_PROTOCOL_VERSION(0, 14, 1)
     [VD_AGENT_CAP_CLIPBOARD_NO_RELEASE_ON_REGRAB] = "clipboard-no-release-on-regrab",
     [VD_AGENT_CAP_CLIPBOARD_GRAB_SERIAL]          = "clipboard-grab-serial",
@@ -112,9 +110,7 @@ static const char *msg_name[] = {
     [VD_AGENT_CLIENT_DISCONNECTED]   = "client-disconnected",
     [VD_AGENT_MAX_CLIPBOARD]         = "max-clipboard",
     [VD_AGENT_AUDIO_VOLUME_SYNC]     = "audio-volume-sync",
-#if CHECK_SPICE_PROTOCOL_VERSION(0, 14, 0)
     [VD_AGENT_GRAPHICS_DEVICE_INFO]  = "graphics-device-info",
-#endif
 };
 
 static const char *sel_name[] = {
-- 
2.39.0



  parent reply	other threads:[~2023-01-09 19:08 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-09 19:03 [PATCH v4 00/17] ui: Move and clean up monitor command code Markus Armbruster
2023-01-09 19:03 ` [PATCH v4 01/17] ui: Check numeric part of expire_password argument @time properly Markus Armbruster
2023-01-09 19:03 ` [PATCH v4 02/17] ui: Fix silent truncation of numeric keys in HMP sendkey Markus Armbruster
2023-01-10  7:22   ` Philippe Mathieu-Daudé
2023-01-09 19:03 ` Markus Armbruster [this message]
2023-01-09 19:03 ` [PATCH v4 04/17] Revert "hmp: info spice: take out webdav" Markus Armbruster
2023-01-09 19:03 ` [PATCH v4 05/17] ui/spice: Require spice-server >= 0.14.0 Markus Armbruster
2023-01-09 19:03 ` [PATCH v4 06/17] ui/spice: QXLInterface method set_mm_time() is now dead, drop Markus Armbruster
2023-01-09 19:03 ` [PATCH v4 07/17] ui/spice: Give hmp_info_spice()'s channel_names[] static linkage Markus Armbruster
2023-01-09 19:03 ` [PATCH v4 08/17] ui: Clean up a few things checkpatch.pl would flag later on Markus Armbruster
2023-01-09 19:03 ` [PATCH v4 09/17] ui: Move QMP commands from monitor to new ui/ui-qmp-cmds.c Markus Armbruster
2023-01-09 19:03 ` [PATCH v4 10/17] ui: Factor out qmp_add_client() parts and move to ui/ui-qmp-cmds.c Markus Armbruster
2023-01-09 19:03 ` [PATCH v4 11/17] ui: Move HMP commands from monitor to new ui/ui-hmp-cmds.c Markus Armbruster
2023-01-09 19:03 ` [PATCH v4 12/17] ui: Improve "change vnc" error reporting Markus Armbruster
2023-01-09 19:03 ` [PATCH v4 13/17] ui: Factor out hmp_change_vnc(), and move to ui/ui-hmp-cmds.c Markus Armbruster
2023-01-09 19:03 ` [PATCH v4 14/17] ui: Reduce nesting in hmp_change_vnc() slightly Markus Armbruster
2023-01-09 19:03 ` [PATCH v4 15/17] ui: Don't check for mode change after mouse_set error Markus Armbruster
2023-01-10  7:23   ` Philippe Mathieu-Daudé
2023-01-10  9:04   ` Daniel P. Berrangé
2023-01-09 19:03 ` [PATCH v4 16/17] ui: Split hmp_mouse_set() and move the HMP part to ui/ Markus Armbruster
2023-01-10  7:24   ` Philippe Mathieu-Daudé
2023-01-10  9:05   ` Daniel P. Berrangé
2023-01-09 19:03 ` [PATCH v4 17/17] ui: Simplify control flow in qemu_mouse_set() Markus Armbruster
2023-01-10  7:25   ` Philippe Mathieu-Daudé
2023-01-10  9:06   ` Daniel P. Berrangé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230109190321.1056914-4-armbru@redhat.com \
    --to=armbru@redhat.com \
    --cc=berrange@redhat.com \
    --cc=dgilbert@redhat.com \
    --cc=kraxel@redhat.com \
    --cc=philmd@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).