From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: qemu-devel@nongnu.org, Eduardo Habkost <eduardo@habkost.net>,
Markus Armbruster <armbru@redhat.com>,
"Daniel P . Berrange" <berrange@redhat.com>
Cc: "Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Thomas Huth" <thuth@redhat.com>,
"Stefan Hajnoczi" <stefanha@redhat.com>,
"Kevin Wolf" <kwolf@redhat.com>,
qemu-block@nongnu.org, "Paolo Bonzini" <pbonzini@redhat.com>,
"Hanna Reitz" <hreitz@redhat.com>
Subject: [RFC PATCH 0/4] qom: Introduce object_class_property_deprecate()
Date: Mon, 9 Jan 2023 23:54:15 +0100 [thread overview]
Message-ID: <20230109225419.22621-1-philmd@linaro.org> (raw)
Hi,
There will always be a need to deprecate things. Here I'm
tackling the QOM (class) properties, since they can be set
from some CLI options (-object -device -global ...).
As an experiment, we add object_class_property_deprecate()
to register a class property as deprecated (since some version),
then we deprecate the TYPE_PFLASH_CFI02 'width' property, and
finally as a bonus we emit a warning when the deprecation period
is over, as a reminder. (For that we introduce few 'versions'
helpers).
Output example:
$ qemu-system-arm -M musicpal,accel=qtest -S \
-drive if=pflash,driver=null-co,read-zeroes=on,size=8M \
-global driver=cfi.pflash02,property=width,value=2
qemu-system-arm: warning: Property 'cfi.pflash02.width' is deprecated (renamed as 'cfi.pflash02.device-width').
$ qemu-system-arm -M musicpal,accel=qtest -S \
-drive if=pflash,driver=null-co,read-zeroes=on,size=8M \
-global driver=cfi.pflash02,property=device-width,value=2
qemu-system-arm: warning: Property 'cfi.pflash02.width' has been deprecated in release v8.0 and can be removed.
Thought?
Regards,
Phil.
[earlier inspiration: https://lore.kernel.org/qemu-devel/Y7wlnqwU+/auE0Jj@redhat.com/]
Philippe Mathieu-Daudé (4):
qom: Introduce object_class_property_deprecate()
hw/block: Rename TYPE_PFLASH_CFI02 'width' property as 'device-width'
util: Introduce helpers to compare QEMU versions
qom: Warn when deprecated class property can be removed
hw/block/pflash_cfi02.c | 8 +++++++-
include/qemu/qemu-version.h | 36 ++++++++++++++++++++++++++++++++++++
include/qom/object.h | 17 +++++++++++++++++
qom/object.c | 30 ++++++++++++++++++++++++++++++
util/meson.build | 1 +
util/qemu-version.c | 37 +++++++++++++++++++++++++++++++++++++
6 files changed, 128 insertions(+), 1 deletion(-)
create mode 100644 include/qemu/qemu-version.h
create mode 100644 util/qemu-version.c
--
2.38.1
next reply other threads:[~2023-01-09 22:55 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-09 22:54 Philippe Mathieu-Daudé [this message]
2023-01-09 22:54 ` [RFC PATCH 1/4] qom: Introduce object_class_property_deprecate() Philippe Mathieu-Daudé
2023-01-10 9:52 ` Daniel P. Berrangé
2023-01-10 9:55 ` Daniel P. Berrangé
2023-01-09 22:54 ` [RFC PATCH 2/4] hw/block: Rename TYPE_PFLASH_CFI02 'width' property as 'device-width' Philippe Mathieu-Daudé
2023-01-10 9:50 ` Daniel P. Berrangé
2023-01-09 22:54 ` [RFC PATCH 3/4] util: Introduce helpers to compare QEMU versions Philippe Mathieu-Daudé
2023-01-09 22:54 ` [RFC PATCH 4/4] qom: Warn when deprecated class property can be removed Philippe Mathieu-Daudé
2023-01-10 9:34 ` Bernhard Beschow
2023-01-10 9:49 ` Daniel P. Berrangé
2023-01-10 13:02 ` [RFC PATCH 0/4] qom: Introduce object_class_property_deprecate() Kevin Wolf
2023-01-11 9:55 ` Philippe Mathieu-Daudé
2023-01-11 9:59 ` Daniel P. Berrangé
2023-01-11 10:08 ` Philippe Mathieu-Daudé
2023-01-11 10:29 ` Daniel P. Berrangé
2023-01-11 11:29 ` Markus Armbruster
2023-01-11 13:15 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230109225419.22621-1-philmd@linaro.org \
--to=philmd@linaro.org \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=eduardo@habkost.net \
--cc=hreitz@redhat.com \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).