From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 03EAEC46467 for ; Tue, 10 Jan 2023 18:47:26 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pFIb7-0003Wt-3L; Tue, 10 Jan 2023 12:39:41 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pFIb4-0003UX-V7 for qemu-devel@nongnu.org; Tue, 10 Jan 2023 12:39:38 -0500 Received: from mail-wr1-x430.google.com ([2a00:1450:4864:20::430]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pFIb1-0001Gh-5H for qemu-devel@nongnu.org; Tue, 10 Jan 2023 12:39:38 -0500 Received: by mail-wr1-x430.google.com with SMTP id v2so1584590wrw.10 for ; Tue, 10 Jan 2023 09:39:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=MXFxyJRI2iR/xunMULJui4KM0BQsyU2Vc+mAIPXoOSM=; b=Q9FXpp+LMQLJXSxBjuap6LoOG11HDSKTDs6+gotY7/qiJySt0pxepIoHKpTXpHATP3 GIhv1cqEb5DmeWuCJY8rMbHJLGYDwiR2f1QSRSYmvRVqDd9vuy0jpBQarZs9y08S6Yq5 IkUOnHntASQRzK7T6vy6Y/WdZodftWcE1BoBguvw2r+qHCMxj61U5gYbZpA5MNMwfjGe Ib1obRxtofIpx+AxcsOO9ClJk9TyZfehlgsBX2uaNWM+sPewF406WU7z/L18vSBupsGm 8460NuVzrAG3yYegyMpNxDbusLAs+E++okQIwz1/8+bbezPGlVHq/mjCwsf3Vx5VyAX2 R7tg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=MXFxyJRI2iR/xunMULJui4KM0BQsyU2Vc+mAIPXoOSM=; b=dhbfIqKdLWEOrSQGMWnegzVwrQgXYg6IjLkJDwXxd1zzqevas0JWRUtCF4G7u2iRF1 fs7kfNpqIgrbhkJpE0CtxW4CTu8+rOJvF9gKH66ZF6bNmr9mrmV48wscwrGD3nfrr4Ev 22RBibncg09dC3hCTZbOIGCbvIOuhlaJsFZAGIqVRQIzwV1iBF8bDQELbBakfLYOaE0p zQDSPVbxzPT54PZZu6I8y4GiEhf/nBSvDgZKm7R8pgOFKVSjBZCI+wmwhQS44YH/o+AS E1Mn9Gg/b8oY8EIS2NNKx8pCAb+PbZEgR5+QaiwehdyHoGEN4KQ2xqllygwB6fE7bxaC aDkA== X-Gm-Message-State: AFqh2kqjk+YTsxmUQT9OTsXi4ctefxz7ybmIsBKYqQS+mHgAUjKMvGpH xdlJqcXZZEhCjlIvInbaR1lGlQ== X-Google-Smtp-Source: AMrXdXucUtTQ/RuZ+GO6N1CwMWOshR5t4BJN/1buLLw/Q8YSQNbgHC3FgTlbxNiHVRfu7ayxEqvmKQ== X-Received: by 2002:a05:6000:705:b0:273:7d1b:7337 with SMTP id bs5-20020a056000070500b002737d1b7337mr40397725wrb.7.1673372373543; Tue, 10 Jan 2023 09:39:33 -0800 (PST) Received: from zen.linaroharston ([185.81.254.11]) by smtp.gmail.com with ESMTPSA id r10-20020adfda4a000000b0029a06f11022sm11796931wrl.112.2023.01.10.09.39.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Jan 2023 09:39:32 -0800 (PST) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 5EBC61FFBB; Tue, 10 Jan 2023 17:39:25 +0000 (GMT) From: =?UTF-8?q?Alex=20Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: Richard Henderson , Alexandre Iooss , Beraldo Leal , Thomas Huth , John Snow , Eduardo Habkost , Elena Ufimtseva , Ed Maste , Yanan Wang , Cleber Rosa , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Li-Wen Hsu , Markus Armbruster , Jagannathan Raman , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Michael Roth , Wainer dos Santos Moschetta , =?UTF-8?q?Alex=20Benn=C3=A9e?= , qemu-arm@nongnu.org, Marcel Apfelbaum , Peter Maydell , Paolo Bonzini , Mahmoud Mandour , John G Johnson , Emilio Cota Subject: [PATCH 19/26] util/qht: add missing atomic_set(hashes[i]) Date: Tue, 10 Jan 2023 17:39:15 +0000 Message-Id: <20230110173922.265055-20-alex.bennee@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230110173922.265055-1-alex.bennee@linaro.org> References: <20230110173922.265055-1-alex.bennee@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::430; envelope-from=alex.bennee@linaro.org; helo=mail-wr1-x430.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org From: Emilio Cota We forgot to add this one in "a890643958 util/qht: atomically set b->hashes". Detected with tsan. Reviewed-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Emilio Cota Reviewed-by: Alex Bennée Message-Id: <20230109224954.161672-3-cota@braap.org> Signed-off-by: Alex Bennée --- util/qht.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/util/qht.c b/util/qht.c index 065fc501f4..15866299e6 100644 --- a/util/qht.c +++ b/util/qht.c @@ -688,7 +688,7 @@ static inline void qht_bucket_remove_entry(struct qht_bucket *orig, int pos) int i; if (qht_entry_is_last(orig, pos)) { - orig->hashes[pos] = 0; + qatomic_set(&orig->hashes[pos], 0); qatomic_set(&orig->pointers[pos], NULL); return; } -- 2.34.1