From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: qemu-devel@nongnu.org
Cc: "Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Ryo ONODERA" <ryoon@netbsd.org>,
"Daniel P. Berrangé" <berrange@redhat.com>,
"Thomas Huth" <thuth@redhat.com>,
"Ira Weiny" <ira.weiny@intel.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Kamil Rytarowski" <kamil@netbsd.org>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Reinoud Zandijk" <reinoud@netbsd.org>,
"Jonathan Cameron" <Jonathan.Cameron@huawei.com>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>,
"Richard Henderson" <richard.henderson@linaro.org>
Subject: [PATCH v3 1/6] qemu/bswap: Replace bswapXX() by compiler __builtin_bswap()
Date: Wed, 11 Jan 2023 17:31:42 +0100 [thread overview]
Message-ID: <20230111163147.71761-2-philmd@linaro.org> (raw)
In-Reply-To: <20230111163147.71761-1-philmd@linaro.org>
From: Philippe Mathieu-Daudé <philmd@redhat.com>
Use the compiler built-in function to byte swap values,
as the compiler is clever and will fold constants.
Suggested-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
include/qemu/bswap.h | 31 ++++++-------------------------
1 file changed, 6 insertions(+), 25 deletions(-)
diff --git a/include/qemu/bswap.h b/include/qemu/bswap.h
index 346d05f2aa..ca2b4c3f15 100644
--- a/include/qemu/bswap.h
+++ b/include/qemu/bswap.h
@@ -37,31 +37,12 @@ static inline uint64_t bswap64(uint64_t x)
#endif
#ifdef BSWAP_FROM_FALLBACKS
-static inline uint16_t bswap16(uint16_t x)
-{
- return (((x & 0x00ff) << 8) |
- ((x & 0xff00) >> 8));
-}
-
-static inline uint32_t bswap32(uint32_t x)
-{
- return (((x & 0x000000ffU) << 24) |
- ((x & 0x0000ff00U) << 8) |
- ((x & 0x00ff0000U) >> 8) |
- ((x & 0xff000000U) >> 24));
-}
-
-static inline uint64_t bswap64(uint64_t x)
-{
- return (((x & 0x00000000000000ffULL) << 56) |
- ((x & 0x000000000000ff00ULL) << 40) |
- ((x & 0x0000000000ff0000ULL) << 24) |
- ((x & 0x00000000ff000000ULL) << 8) |
- ((x & 0x000000ff00000000ULL) >> 8) |
- ((x & 0x0000ff0000000000ULL) >> 24) |
- ((x & 0x00ff000000000000ULL) >> 40) |
- ((x & 0xff00000000000000ULL) >> 56));
-}
+#undef bswap16
+#define bswap16(_x) __builtin_bswap16(_x)
+#undef bswap32
+#define bswap32(_x) __builtin_bswap32(_x)
+#undef bswap64
+#define bswap64(_x) __builtin_bswap64(_x)
#endif
#undef BSWAP_FROM_BYTESWAP
--
2.38.1
next prev parent reply other threads:[~2023-01-11 16:32 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-11 16:31 [PATCH v3 0/6] qemu/bswap: Use compiler __builtin_bswap() Philippe Mathieu-Daudé
2023-01-11 16:31 ` Philippe Mathieu-Daudé [this message]
2023-01-11 16:31 ` [PATCH v3 2/6] qemu/bswap: Replace bswapXXs() by " Philippe Mathieu-Daudé
2023-01-11 16:31 ` [PATCH v3 3/6] qemu/bswap: Remove <byteswap.h> dependency Philippe Mathieu-Daudé
2023-01-11 16:31 ` [PATCH v3 4/6] qemu/bswap: Use compiler __builtin_bswap() on Haiku Philippe Mathieu-Daudé
2023-01-11 16:31 ` [PATCH v3 5/6] qemu/bswap: Use compiler __builtin_bswap() on FreeBSD Philippe Mathieu-Daudé
2023-01-11 16:31 ` [PATCH v3 6/6] qemu/bswap: Use compiler __builtin_bswap() on NetBSD Philippe Mathieu-Daudé
2023-01-13 1:05 ` [PATCH v3 0/6] qemu/bswap: Use compiler __builtin_bswap() Richard Henderson
2023-01-13 7:05 ` Philippe Mathieu-Daudé
2023-01-13 7:20 ` Thomas Huth
2023-01-17 8:24 ` Philippe Mathieu-Daudé
2023-01-18 2:17 ` Richard Henderson
2023-01-26 12:47 ` Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230111163147.71761-2-philmd@linaro.org \
--to=philmd@linaro.org \
--cc=Jonathan.Cameron@huawei.com \
--cc=berrange@redhat.com \
--cc=ira.weiny@intel.com \
--cc=kamil@netbsd.org \
--cc=marcandre.lureau@redhat.com \
--cc=pbonzini@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=reinoud@netbsd.org \
--cc=richard.henderson@linaro.org \
--cc=ryoon@netbsd.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).