qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: qemu-devel@nongnu.org
Cc: "Marc-André Lureau" <marcandre.lureau@redhat.com>,
	"Ryo ONODERA" <ryoon@netbsd.org>,
	"Daniel P. Berrangé" <berrange@redhat.com>,
	"Thomas Huth" <thuth@redhat.com>,
	"Ira Weiny" <ira.weiny@intel.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Kamil Rytarowski" <kamil@netbsd.org>,
	"Philippe Mathieu-Daudé" <philmd@linaro.org>,
	"Reinoud Zandijk" <reinoud@netbsd.org>,
	"Jonathan Cameron" <Jonathan.Cameron@huawei.com>,
	"Philippe Mathieu-Daudé" <philmd@redhat.com>,
	"Richard Henderson" <richard.henderson@linaro.org>
Subject: [PATCH v3 3/6] qemu/bswap: Remove <byteswap.h> dependency
Date: Wed, 11 Jan 2023 17:31:44 +0100	[thread overview]
Message-ID: <20230111163147.71761-4-philmd@linaro.org> (raw)
In-Reply-To: <20230111163147.71761-1-philmd@linaro.org>

From: Philippe Mathieu-Daudé <philmd@redhat.com>

Since commit efc6c070aca ("configure: Add a test for the minimum
compiler version") the minimum compiler version required for GCC
is 4.8, which supports __builtin_bswap().
Drop the <byteswap.h> dependency.

Suggested-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
 include/qemu/bswap.h | 21 ---------------------
 meson.build          |  2 --
 2 files changed, 23 deletions(-)

diff --git a/include/qemu/bswap.h b/include/qemu/bswap.h
index d2dafdc54c..fd5a98125a 100644
--- a/include/qemu/bswap.h
+++ b/include/qemu/bswap.h
@@ -8,9 +8,6 @@
 # include <sys/endian.h>
 #elif defined(__HAIKU__)
 # include <endian.h>
-#elif defined(CONFIG_BYTESWAP_H)
-# include <byteswap.h>
-#define BSWAP_FROM_BYTESWAP
 # else
 #define BSWAP_FROM_FALLBACKS
 #endif /* ! CONFIG_MACHINE_BSWAP_H */
@@ -19,23 +16,6 @@
 extern "C" {
 #endif
 
-#ifdef BSWAP_FROM_BYTESWAP
-static inline uint16_t bswap16(uint16_t x)
-{
-    return bswap_16(x);
-}
-
-static inline uint32_t bswap32(uint32_t x)
-{
-    return bswap_32(x);
-}
-
-static inline uint64_t bswap64(uint64_t x)
-{
-    return bswap_64(x);
-}
-#endif
-
 #ifdef BSWAP_FROM_FALLBACKS
 #undef  bswap16
 #define bswap16(_x) __builtin_bswap16(_x)
@@ -45,7 +25,6 @@ static inline uint64_t bswap64(uint64_t x)
 #define bswap64(_x) __builtin_bswap64(_x)
 #endif
 
-#undef BSWAP_FROM_BYTESWAP
 #undef BSWAP_FROM_FALLBACKS
 
 static inline void bswap16s(uint16_t *s)
diff --git a/meson.build b/meson.build
index 175517eafd..697059d2c8 100644
--- a/meson.build
+++ b/meson.build
@@ -2006,8 +2006,6 @@ if rdma.found()
 endif
 
 # has_header_symbol
-config_host_data.set('CONFIG_BYTESWAP_H',
-                     cc.has_header_symbol('byteswap.h', 'bswap_32'))
 config_host_data.set('CONFIG_EPOLL_CREATE1',
                      cc.has_header_symbol('sys/epoll.h', 'epoll_create1'))
 config_host_data.set('CONFIG_FALLOCATE_PUNCH_HOLE',
-- 
2.38.1



  parent reply	other threads:[~2023-01-11 16:32 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-11 16:31 [PATCH v3 0/6] qemu/bswap: Use compiler __builtin_bswap() Philippe Mathieu-Daudé
2023-01-11 16:31 ` [PATCH v3 1/6] qemu/bswap: Replace bswapXX() by " Philippe Mathieu-Daudé
2023-01-11 16:31 ` [PATCH v3 2/6] qemu/bswap: Replace bswapXXs() " Philippe Mathieu-Daudé
2023-01-11 16:31 ` Philippe Mathieu-Daudé [this message]
2023-01-11 16:31 ` [PATCH v3 4/6] qemu/bswap: Use compiler __builtin_bswap() on Haiku Philippe Mathieu-Daudé
2023-01-11 16:31 ` [PATCH v3 5/6] qemu/bswap: Use compiler __builtin_bswap() on FreeBSD Philippe Mathieu-Daudé
2023-01-11 16:31 ` [PATCH v3 6/6] qemu/bswap: Use compiler __builtin_bswap() on NetBSD Philippe Mathieu-Daudé
2023-01-13  1:05 ` [PATCH v3 0/6] qemu/bswap: Use compiler __builtin_bswap() Richard Henderson
2023-01-13  7:05   ` Philippe Mathieu-Daudé
2023-01-13  7:20     ` Thomas Huth
2023-01-17  8:24     ` Philippe Mathieu-Daudé
2023-01-18  2:17       ` Richard Henderson
2023-01-26 12:47 ` Thomas Huth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230111163147.71761-4-philmd@linaro.org \
    --to=philmd@linaro.org \
    --cc=Jonathan.Cameron@huawei.com \
    --cc=berrange@redhat.com \
    --cc=ira.weiny@intel.com \
    --cc=kamil@netbsd.org \
    --cc=marcandre.lureau@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=philmd@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=reinoud@netbsd.org \
    --cc=richard.henderson@linaro.org \
    --cc=ryoon@netbsd.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).