From: Maksim Davydov <davydov-max@yandex-team.ru>
To: qemu-devel@nongnu.org
Cc: vsementsov@yandex-team.ru, jsnow@redhat.com, eduardo@habkost.net,
marcel.apfelbaum@gmail.com, philmd@linaro.org,
wangyanan55@huawei.com, crosa@redhat.com, bleal@redhat.com,
eblake@redhat.com, armbru@redhat.com, pbonzini@redhat.com,
berrange@redhat.com, alxndr@bu.edu, bsd@redhat.com,
stefanha@redhat.com, thuth@redhat.com, darren.kenny@oracle.com,
Qiuhao.Li@outlook.com, lvivier@redhat.com
Subject: [PATCH v5 1/4] qom: add default value
Date: Thu, 12 Jan 2023 18:28:02 +0300 [thread overview]
Message-ID: <20230112152805.33109-2-davydov-max@yandex-team.ru> (raw)
In-Reply-To: <20230112152805.33109-1-davydov-max@yandex-team.ru>
qmp_qom_list_properties can print default values if they are available
as qmp_device_list_properties does, because both of them use the
ObjectPropertyInfo structure with default_value field. This can be useful
when working with "not device" types.
Signed-off-by: Maksim Davydov <davydov-max@yandex-team.ru>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
---
qom/qom-qmp-cmds.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/qom/qom-qmp-cmds.c b/qom/qom-qmp-cmds.c
index 7c087299de..e91a235347 100644
--- a/qom/qom-qmp-cmds.c
+++ b/qom/qom-qmp-cmds.c
@@ -212,6 +212,7 @@ ObjectPropertyInfoList *qmp_qom_list_properties(const char *typename,
info->name = g_strdup(prop->name);
info->type = g_strdup(prop->type);
info->description = g_strdup(prop->description);
+ info->default_value = qobject_ref(prop->defval);
QAPI_LIST_PREPEND(prop_list, info);
}
--
2.25.1
next prev parent reply other threads:[~2023-01-12 15:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-12 15:28 [PATCH v5 0/4] compare machine type compat_props Maksim Davydov
2023-01-12 15:28 ` Maksim Davydov [this message]
2023-01-12 15:28 ` [PATCH v5 2/4] python/qmp: increase read buffer size Maksim Davydov
2023-01-17 22:42 ` John Snow
2023-01-12 15:28 ` [PATCH v5 3/4] qmp: add dump machine type compatible properties Maksim Davydov
2023-01-12 15:28 ` [PATCH v5 4/4] scripts: add script to compare " Maksim Davydov
2023-02-06 18:42 ` Maksim Davydov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230112152805.33109-2-davydov-max@yandex-team.ru \
--to=davydov-max@yandex-team.ru \
--cc=Qiuhao.Li@outlook.com \
--cc=alxndr@bu.edu \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=bleal@redhat.com \
--cc=bsd@redhat.com \
--cc=crosa@redhat.com \
--cc=darren.kenny@oracle.com \
--cc=eblake@redhat.com \
--cc=eduardo@habkost.net \
--cc=jsnow@redhat.com \
--cc=lvivier@redhat.com \
--cc=marcel.apfelbaum@gmail.com \
--cc=pbonzini@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=thuth@redhat.com \
--cc=vsementsov@yandex-team.ru \
--cc=wangyanan55@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).