From: "Michael S. Tsirkin" <mst@redhat.com>
To: Bernhard Beschow <shentey@gmail.com>
Cc: "Chuck Zmudzinski" <brchuckz@aol.com>,
qemu-devel@nongnu.org,
"Stefano Stabellini" <sstabellini@kernel.org>,
"Anthony Perard" <anthony.perard@citrix.com>,
"Paul Durrant" <paul@xen.org>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Richard Henderson" <richard.henderson@linaro.org>,
"Eduardo Habkost" <eduardo@habkost.net>,
"Marcel Apfelbaum" <marcel.apfelbaum@gmail.com>,
xen-devel@lists.xenproject.org,
"Philippe Mathieu-Daudé" <philmd@linaro.org>
Subject: Re: [PATCH v8] xen/pt: reserve PCI slot 2 for Intel igd-passthru
Date: Thu, 12 Jan 2023 18:03:34 -0500 [thread overview]
Message-ID: <20230112180314-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <7208A064-2A25-4DBB-BF19-6797E96AB00C@gmail.com>
On Thu, Jan 12, 2023 at 10:55:25PM +0000, Bernhard Beschow wrote:
> I think the change Michael suggests is very minimalistic: Move the if
> condition around xen_igd_reserve_slot() into the function itself and
> always call it there unconditionally -- basically turning three lines
> into one. Since xen_igd_reserve_slot() seems very problem specific,
> Michael further suggests to rename it to something more general. All
> in all no big changes required.
yes, exactly.
--
MST
next prev parent reply other threads:[~2023-01-12 23:04 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <a09d2427397621eaecee4c46b33507a99cc5f161.1673334040.git.brchuckz.ref@aol.com>
2023-01-10 7:08 ` [PATCH v8] xen/pt: reserve PCI slot 2 for Intel igd-passthru Chuck Zmudzinski
2023-01-10 8:16 ` Michael S. Tsirkin
2023-01-10 13:09 ` Chuck Zmudzinski
2023-01-11 15:40 ` Chuck Zmudzinski
2023-01-12 19:18 ` Bernhard Beschow
2023-01-12 20:11 ` Chuck Zmudzinski
2023-01-12 22:55 ` Bernhard Beschow
2023-01-12 23:03 ` Michael S. Tsirkin [this message]
2023-01-13 4:14 ` Chuck Zmudzinski
2023-01-13 9:33 ` Igor Mammedov
2023-01-13 21:31 ` Chuck Zmudzinski
2023-01-16 15:33 ` Igor Mammedov
2023-01-16 18:00 ` Chuck Zmudzinski
2023-01-17 10:35 ` Igor Mammedov
2023-01-17 14:43 ` Chuck Zmudzinski
2023-01-20 15:53 ` Igor Mammedov
2023-01-17 14:50 ` Chuck Zmudzinski
2023-01-20 16:01 ` Igor Mammedov
2023-01-20 19:50 ` Chuck Zmudzinski
2023-01-17 11:04 ` Igor Mammedov
2023-01-18 0:15 ` Chuck Zmudzinski
2023-01-18 4:27 ` Alex Williamson
2023-01-18 22:39 ` Chuck Zmudzinski
2023-01-20 16:57 ` Stefano Stabellini
2023-01-20 19:26 ` Chuck Zmudzinski
2023-01-14 2:55 ` Chuck Zmudzinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230112180314-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=anthony.perard@citrix.com \
--cc=brchuckz@aol.com \
--cc=eduardo@habkost.net \
--cc=marcel.apfelbaum@gmail.com \
--cc=paul@xen.org \
--cc=pbonzini@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=shentey@gmail.com \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).