From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3BB7AC677F1 for ; Thu, 12 Jan 2023 21:05:05 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pG4k5-0007kE-Iw; Thu, 12 Jan 2023 16:04:09 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pG4k0-0007jr-0E for qemu-devel@nongnu.org; Thu, 12 Jan 2023 16:04:04 -0500 Received: from nylar.uni-paderborn.de ([2001:638:502:c003::18]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pG4jx-0000hN-Fc for qemu-devel@nongnu.org; Thu, 12 Jan 2023 16:04:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mail.uni-paderborn.de; s=20170601; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=h0iiuQ8HWDb47MZ2UpouMpJ6VpyJ3mTUyb+PoUtwKyw=; b=RLhxF4d5mGz5/VWJcrqL76BjuE xA9itfEbHs0/fqdKVOrf8IEhqNHv7nKaFBlsLN1UJsRBuy5zyhOfbzQ4EDpCrqyF7QttbmPNKwkoJ 2dEoJkOpp5hcVYZfYsWkryhCtwaids5QV95k330UwGXyn2/K1GymKGMdY9bsHYblp/o8=; Date: Thu, 12 Jan 2023 22:03:50 +0100 From: Bastian Koppelmann To: Anton Kochkov Cc: qemu-devel@nongnu.org, eitan_eliahu@hotmail.com Subject: Re: [PATCH] target/tricore: Fix OPC1_16_SRO_LD_H translation Message-ID: <20230112210350.2y67zmep37menm6d@schnipp-desktop> References: <20230112142258.514079-1-anton.kochkov@proton.me> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230112142258.514079-1-anton.kochkov@proton.me> X-IMT-Source: Extern X-IMT-Spam-Score: 0.0 () X-PMX-Version: 6.4.9.2830568, Antispam-Engine: 2.7.2.2107409, Antispam-Data: 2023.1.12.205123, AntiVirus-Engine: 5.96.0, AntiVirus-Data: 2022.12.20.5960002 X-Sophos-SenderHistory: ip=84.154.186.130, fs=13959064, da=161166500, mc=63, sc=0, hc=63, sp=0, fso=13959064, re=0, sd=0, hd=0 X-IMT-Authenticated-Sender: kbastian@UNI-PADERBORN.DE Received-SPF: pass client-ip=2001:638:502:c003::18; envelope-from=kbastian@mail.uni-paderborn.de; helo=nylar.uni-paderborn.de X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Thu, Jan 12, 2023 at 02:24:02PM +0000, Anton Kochkov wrote: > Signed-off-by: Eitan Eliahu > Resolves: https://gitlab.com/qemu-project/qemu/-/issues/652 > --- > target/tricore/translate.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/target/tricore/translate.c b/target/tricore/translate.c > index df9e46c649..b2a5e11778 100644 > --- a/target/tricore/translate.c > +++ b/target/tricore/translate.c > @@ -3878,7 +3878,7 @@ static void decode_sro_opc(DisasContext *ctx, int op1) > gen_offset_ld(ctx, cpu_gpr_d[15], cpu_gpr_a[r2], address, MO_UB); > break; > case OPC1_16_SRO_LD_H: > - gen_offset_ld(ctx, cpu_gpr_d[15], cpu_gpr_a[r2], address, MO_LESW); > + gen_offset_ld(ctx, cpu_gpr_d[15], cpu_gpr_a[r2], address * 2, MO_LESW); > break; > case OPC1_16_SRO_LD_W: > gen_offset_ld(ctx, cpu_gpr_d[15], cpu_gpr_a[r2], address * 4, MO_LESL); > -- > 2.39.0 Reviewed-by: Bastian Koppelmann As Phil said, good catch. I added it to my TriCore queue. I saw on the bugtracker that you have testcase. Are you interested in adding it to tests/tcg/tricore? Cheers, Bastian